Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 Jan 2022 12:37:44 -0800
From:   Benson Leung <bleung@google.com>
To:     Won Chung <wonchung@google.com>
Cc:     "Rafael J . Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        Benson Leung <bleung@chromium.org>,
        Prashant Malani <pmalani@chromium.org>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: device_sysfs: Add sysfs support for _PLD
Message-ID: <YfMCmCb47zocYXCA@google.com>
References: <20220126235807.3164317-1-wonchung@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="yN0c5RbogYywFKuv"
Content-Disposition: inline
In-Reply-To: <20220126235807.3164317-1-wonchung@google.com>
Precedence: bulk


--yN0c5RbogYywFKuv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Won,

On Wed, Jan 26, 2022 at 11:58:07PM +0000, Won Chung wrote:
> When ACPI table includes _PLD fields for a device, create a new file
> (pld) in sysfs to share _PLD fields.

If you're adding a new attribute, you should also update the Documentation
file here: Documentation/ABI/testing/sysfs-bus-acpi

Thanks,
Benson


>=20
> Signed-off-by: Won Chung <wonchung@google.com>
> ---
>  drivers/acpi/device_sysfs.c | 42 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>=20
> diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
> index d5d6403ba07b..8d4df5fb1c45 100644
> --- a/drivers/acpi/device_sysfs.c
> +++ b/drivers/acpi/device_sysfs.c
> @@ -509,6 +509,40 @@ static ssize_t status_show(struct device *dev, struc=
t device_attribute *attr,
>  }
>  static DEVICE_ATTR_RO(status);
> =20
> +static ssize_t pld_show(struct device *dev, struct device_attribute *att=
r,
> +			char *buf)
> +{
> +	struct acpi_device *acpi_dev =3D to_acpi_device(dev);
> +	acpi_status status;
> +	struct acpi_pld_info *pld;
> +
> +	status =3D acpi_get_physical_device_location(acpi_dev->handle, &pld);
> +	if (ACPI_FAILURE(status))
> +		return -ENODEV;
> +
> +	return sprintf(buf, "GROUP_TOKEN=3D%u\n"
> +		"GROUP_POSITION=3D%u\n"
> +		"USER_VISIBLE=3D%u\n"
> +		"DOCK=3D%u\n"
> +		"BAY=3D%u\n"
> +		"LID=3D%u\n"
> +		"PANEL=3D%u\n"
> +		"HORIZONTAL_POSITION=3D%u\n"
> +		"VERTICAL_POSITION=3D%u\n"
> +		"SHAPE=3D%u\n",
> +		pld->group_token,
> +		pld->group_position,
> +		pld->user_visible,
> +		pld->dock,
> +		pld->bay,
> +		pld->lid,
> +		pld->panel,
> +		pld->horizontal_position,
> +		pld->vertical_position,
> +		pld->shape);
> +}
> +static DEVICE_ATTR_RO(pld);
> +
>  /**
>   * acpi_device_setup_files - Create sysfs attributes of an ACPI device.
>   * @dev: ACPI device object.
> @@ -595,6 +629,12 @@ int acpi_device_setup_files(struct acpi_device *dev)
>  						    &dev_attr_real_power_state);
>  	}
> =20
> +	if (acpi_has_method(dev->handle, "_PLD")) {
> +		result =3D device_create_file(&dev->dev, &dev_attr_pld);
> +		if (result)
> +			goto end;
> +	}
> +
>  	acpi_expose_nondev_subnodes(&dev->dev.kobj, &dev->data);
> =20
>  end:
> @@ -645,4 +685,6 @@ void acpi_device_remove_files(struct acpi_device *dev)
>  		device_remove_file(&dev->dev, &dev_attr_status);
>  	if (dev->handle)
>  		device_remove_file(&dev->dev, &dev_attr_path);
> +	if (acpi_has_method(dev->handle, "_PLD"))
> +		device_remove_file(&dev->dev, &dev_attr_pld);
>  }
> --=20
> 2.35.0.rc0.227.g00780c9af4-goog
>=20

--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--yN0c5RbogYywFKuv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCYfMCmAAKCRBzbaomhzOw
wv/lAP0fZ4J1IJCrLit7NHh8xFteID06c/Ga76+iIXX+6x6MjwEAox9Fhj77FOn1
QH3TPybVr1ADTo0TiUmRtUQbDxVpfAA=
=c5Dl
-----END PGP SIGNATURE-----

--yN0c5RbogYywFKuv--