Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 Jan 2022 22:31:50 +0100
From:   Wolfram Sang <wsa@kernel.org>
To:     =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>
Cc:     Laxman Dewangan <ldewangan@nvidia.com>,
        Dmitry Osipenko <digetx@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] i2c: tegra: allow DVC support to be compiled out
Message-ID: <YfMPRj8H8nT4rFZb@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        Dmitry Osipenko <digetx@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>, linux-i2c@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1642535860.git.mirq-linux@rere.qmqm.pl>
 <ebe847bb25016e743c28bd38a10c966b04b06cc8.1642535860.git.mirq-linux@rere.qmqm.pl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kSuXyQOCCZh8UNsS"
Content-Disposition: inline
In-Reply-To: <ebe847bb25016e743c28bd38a10c966b04b06cc8.1642535860.git.mirq-linux@rere.qmqm.pl>
Precedence: bulk


--kSuXyQOCCZh8UNsS
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Micha=C5=82,

> ---
> v2: remove KConfig symbol as per Dmitry Osipenko's suggestion.
>     (Assuming that for Tegra20 the DVC part will be used anyway.)
>=20
> Signed-off-by: Micha=C5=82 Miros=C5=82aw <mirq-linux@rere.qmqm.pl>

Your SoB should be above the "---" line.

> +#define IS_DVC(dev) (IS_ENABLED(CONFIG_ARCH_TEGRA_2x_SOC) && dev->is_dvc)

'checkpatch --strict' IMO rightfully mentions that 'dev' should be in
paranthesis when being used.

Both comments apply to patch 2 as well. Otherwise looks good!

Thanks,

   Wolfram


--kSuXyQOCCZh8UNsS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmHzD0MACgkQFA3kzBSg
Kba05Q//aApAEPO2ippzR1+1dZRRovc97ePxoYqtSHbgz5J5WKE3sRjWHzqU2XQJ
WzF2YVS/RNtyDbAE/DN7zQamQ2ch9YwCguaNQPLaefoSr0EhShIUVdysR1+MeMk1
XPFr9eIJ1oxApaLfGo7TWCrpdV5jMjZ0lnvTPAkPaIvDygaygcozhFqPB6O5z3MS
EFOzpFNeu7O8t2ZD5muO6Yxk7i+CUqeVYmJFKMQuFPYORben3j7/ZB8/L22AqS79
o4+L7oxzddcKLyIC1L3kzydCc/2zrnV8k9+7l4cq7TLqBr+msd6VGJzakUP/OXRI
1FaIL3FHtoQbuxmUqGywgdNiu5gl2jRtyEKkfgFd3LuY5+yLhBxkZvhy2i8S73hM
wFbCL8GgPh1GXKtQEqdyK6BCvjpdKlUId78fCl+RvviCYJ1YOk95q2Dgk85jcIIG
C9HNl/VhKkaUG4uwdRgFSXdFkm1a6Kz7yJDLC4VVMqeKXxsyGCEXru3mwW1K/ndV
7pBhJED8+PUixjd0j3yeA4fUZIMTLLRzoR+SW36mWI+gF5CQGKfKzTM7dOjJBtrF
0Cu9vNnlxouVf/DHYuFM5mu0Hp8SeRCNrIAMZjxZ+r+7D0TFOnV2NGCd2WN0zto0
JWMN9Bz+q02DVHOPuHz7beYHF/zpc6f9istwbL2T/ULRORVaHBk=
=x6er
-----END PGP SIGNATURE-----

--kSuXyQOCCZh8UNsS--