Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 Jan 2022 22:57:25 +0100
From:   Wolfram Sang <wsa@kernel.org>
To:     Akhil R <akhilrajeev@nvidia.com>
Cc:     u.kleine-koenig@pengutronix.de, andy.shevchenko@gmail.com,
        christian.koenig@amd.com, digetx@gmail.com,
        gregkh@linuxfoundation.org, jonathanh@nvidia.com,
        ldewangan@nvidia.com, lenb@kernel.org, linux-acpi@vger.kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, rafael@kernel.org,
        sumit.semwal@linaro.org, thierry.reding@gmail.com
Subject: Re: [PATCH v4 3/3] i2c: smbus: Use device_*() functions instead of
 of_*()
Message-ID: <YfMVRasTSQrr1ob+@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Akhil R <akhilrajeev@nvidia.com>, u.kleine-koenig@pengutronix.de,
        andy.shevchenko@gmail.com, christian.koenig@amd.com,
        digetx@gmail.com, gregkh@linuxfoundation.org, jonathanh@nvidia.com,
        ldewangan@nvidia.com, lenb@kernel.org, linux-acpi@vger.kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, rafael@kernel.org,
        sumit.semwal@linaro.org, thierry.reding@gmail.com
References: <1642851166-27096-1-git-send-email-akhilrajeev@nvidia.com>
 <1642851166-27096-4-git-send-email-akhilrajeev@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cP1k5dLGG5uGlg4g"
Content-Disposition: inline
In-Reply-To: <1642851166-27096-4-git-send-email-akhilrajeev@nvidia.com>
Precedence: bulk


--cP1k5dLGG5uGlg4g
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

> +	irq = device_property_match_string(adapter->dev.parent, "interrupt-names",
> +					   "smbus_alert");

I think we should include "linux/property.h" for it. Interesting, the of
header was never included.

> -		irq = of_irq_get_byname(adapter->dev.of_node, "smbus_alert");
> +		irq = fwnode_irq_get_byname(dev_fwnode(adapter->dev.parent),
> +					    "smbus_alert");

Here we should replace of_irq.h with property.h.

Rest looks good!

Happy hacking,

   Wolfram


--cP1k5dLGG5uGlg4g
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmHzFUUACgkQFA3kzBSg
KbaXLg/+NbejI22/3hLSSXg4aRbnAL2/VIok3hgahxmZb3KDl0VGicsM+YLDpUT6
gEc1ZEOvmqhPNiQim+ixd/BeIgAiOlg5Iq2EJPYHroFbWr8olecna4CK+c1Eqjtv
Esutk0oo0kVDci5N0JTKjvYkN78DsJiPthfl84jRDzQCpIRisx+wV/eskNOAJyVD
sUbPdR0KG5OyBbayXq5nM0sDWalGXidOXE83BBD87BmETRXQxGEefQH9Cz4JzoMr
51JM16YkR1ePtGbsmlvzhh/0QImpEFa2iBr1hq0ka3ssM8t8As7nfx1NS+WH67iz
eiGn51FkX0GVBrHLVNNY3KWymB/leFagHbD8HPx1ULGfxb0WzmqNtpCVq6+sxqug
D7jcUrLaFynK5a5+grd4UAvciM8vABA69ckm6sQ7DrvvcTn4oLf2ELchKtUBTAJt
OdGEs67m0gVvM/39kQy1QYBDN5ACj4IQgFMJ1uKzw12G+fFSLZGYGRJOdThwh9YA
Fjz/Fc2NTft2OH6QhK60o7y4jGz33bLKlILCmTKXraTGQ98dkAO6h3D/uRgoe/7u
3gEw7GGwyswnPNCXMC15w0HgBIzCxC346TAxu0vteT4pNEiHNlvKWSBXWh2gOPOx
QV94/mEFUOEvWNUGZTEOF73S0WlSp/M9O3yL/EPkWsU/PwkzrMk=
=g1E6
-----END PGP SIGNATURE-----

--cP1k5dLGG5uGlg4g--