Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: +XBjZvEBIa1A9pV2GM/XwazOS4ZBCBfZzas4C3ey2+TTVupWit3JgfFX3Joo34J78gZXRCeBFs
 JelndTl8nuSOyNzhHaonqoePGBdJGF1qHKvGqPD7qv/FDmpf8xm3FnioQ/MuPTBwOLOtN+fZpH
 3fv7pWlpkicJB3589fQMnxDBA5ppza03kr+ooGp1z4zt95NyaAsanZnTHhiRj3fuF8d9AUDzoL
 N+YzrnsTsEsfCVNdpHgnWnckwgptVUy2ZFgB5TMFcOefHQOA7hfEGUeZLLoHxE0G7aYn4wZJM7
 EFnjhgeDtaLsZSfWIsVmcUXO
IronPort-SDR: rcGeXFVH4e8oCA4qfbZq3Nx1u2BXlGXVFFR7AMgt2TJYztVIYe+obyEhY1bnFnUIFIorKJbKgG
 6XNl12e1q7F6sD+Mvs0S4+VFJRTUrqG965EZ/iSVGYrcoogZdgpT/nlRuC7mswcGxUAd+NmNGN
 y4z7Xi9gZFbx3pfmniv/3zn41fQ/84wfiMG5N//0b5x91lr/FSQDA0DoLY5ValASAMPEmlXL1s
 6yvNJeybOXLBbC477gFgswYXTzdIbo0FYo93OertlvWVapMHXne//M+CwglXSZMa0+I/Qt3xDa
 Z8s=
WDCIronportException: Internal
Message-ID: <6e698ebf-e592-dd44-95a2-8d86416277f7@opensource.wdc.com>
Date:   Fri, 28 Jan 2022 08:07:57 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 2/3] scsi: pm8001: Fix use-after-free for aborted TMF
 sas_task
Content-Language: en-US
To:     John Garry <john.garry@huawei.com>, jinpu.wang@cloud.ionos.com,
        jejb@linux.ibm.com, martin.petersen@oracle.com,
        Ajish.Koshy@microchip.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Viswas.G@microchip.com, chenxiang66@hisilicon.com
References: <1643289172-165636-1-git-send-email-john.garry@huawei.com>
 <1643289172-165636-3-git-send-email-john.garry@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <1643289172-165636-3-git-send-email-john.garry@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/27/22 22:12, John Garry wrote:
> Currently a use-after-free may occur if a TMF sas_task is aborted before
> we handle the IO completion in mpi_ssp_completion(). The abort occurs due
> to timeout.
> 
> When the timeout occurs, the SAS_TASK_STATE_ABORTED flag is set and the
> sas_task is freed in pm8001_exec_internal_tmf_task().
> 
> However, if the IO completion occurs later, the IO completion still thinks
> that the sas_task is available. Fix this by clearing the ccb->task if
> the TMF times out - the IO completion handler does nothing if this pointer
> is cleared.
> 
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
> 
> Note: For hisi_sas driver we already do something similar. However there
> we also flush the completion queue interrupt to ensure that there is no
> race in clearing the task pointer. Please advise if/how something similar
> can be done here.
> 
>  drivers/scsi/pm8001/pm8001_sas.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c
> index 160ee8b228c9..32edda3e55c6 100644
> --- a/drivers/scsi/pm8001/pm8001_sas.c
> +++ b/drivers/scsi/pm8001/pm8001_sas.c
> @@ -769,8 +769,13 @@ static int pm8001_exec_internal_tmf_task(struct domain_device *dev,
>  		res = -TMF_RESP_FUNC_FAILED;
>  		/* Even TMF timed out, return direct. */
>  		if (task->task_state_flags & SAS_TASK_STATE_ABORTED) {
> +			struct pm8001_ccb_info *ccb = task->lldd_task;
> +
>  			pm8001_dbg(pm8001_ha, FAIL, "TMF task[%x]timeout.\n",
>  				   tmf->tmf);
> +
> +			if (ccb)
> +				ccb->task = NULL;
>  			goto ex_err;
>  		}
>  

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research