Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp933889pxb; Fri, 28 Jan 2022 13:33:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJyni30Uu3F7E1dfiDdqYsBXM07Vj1MaWvahb8qh9VFPmpvNoDQed+u1BapJ784zTF7XUTLf X-Received: by 2002:a17:903:110c:: with SMTP id n12mr10376513plh.127.1643405638583; Fri, 28 Jan 2022 13:33:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643405638; cv=none; d=google.com; s=arc-20160816; b=hUQMFIyQsjgW2A1pp35FnSCQ5Njr0ZNClN3inytd/x3/5F2yyYYidMzaXQpVyQGmWb NrZl7sf2tJ6+9bOxrKrus03rcaQOZzJBotptHyq1bU5XDtQNob5xRJkyJ78589RS5B1o mUSbUYx1p1Pjm9BxxknnnU6BSrYcq/7uU0NdZx+bs+kDMDc/WKqg22i8Ua2GlOLSfoEV eNe0DGam/rm3xcD57fpppR2wCwvN/bKlhZstlrccAna4L27f2ksonOPGNZcrolAhQrAw tr6N+tUN8JYBCD7+j2lb6vb4qSHNSxI6XH58n4CRwKRMAgr5nRyPAPmaaVFGjMGIcf5w cM9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=S7JkzSF7lxJgCpd6ZXDkhdvjrfqNJJ5Wge2dT4ZFw7o=; b=fVo8x48cE6o4ekTGVofX/laVbL76VWkHYFaSvL2VSZsmBeMVbMpLIuPRRF4XlGFEjv nINhOg0Tr+jvrR8dyMUSWOfpsYI3gCR6bZLj1cd6Gw+pgCEiSD4cCZsCF2NEH72/BY6x t7v1A1irp2vQogF2UIXPIEFXmcJ0m4jKCkQBptYidzScYxowwWunXap856xqa3Qnn/qs 7/JIkYLQCbVDNlu2xuH+NdkPGmx1uGFzoMDqicOa6Pq4A8sJAm4eboWctBBkoRTsg9Ot EzqGERtPYTBl9cWW/9Mj++y3KmxYYARfDru5TequR/8gS4DZTy9+cJsvQwSS63w/F7uC xmTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=QkHrDYVu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l70si755096pgd.619.2022.01.28.13.33.14; Fri, 28 Jan 2022 13:33:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=QkHrDYVu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344234AbiA0XIs (ORCPT + 99 others); Thu, 27 Jan 2022 18:08:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344174AbiA0XIk (ORCPT ); Thu, 27 Jan 2022 18:08:40 -0500 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 538EFC061751 for ; Thu, 27 Jan 2022 15:08:36 -0800 (PST) Received: by mail-pg1-x52d.google.com with SMTP id e9so3680426pgb.3 for ; Thu, 27 Jan 2022 15:08:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=S7JkzSF7lxJgCpd6ZXDkhdvjrfqNJJ5Wge2dT4ZFw7o=; b=QkHrDYVuucq5tGrwY+7ofVKvafE8N1vG6K7wssS8MFOLQ8A+qT44Pw8OkxznULsPLE fU0ppcxIbnnoe3DkKlONgnWitZdR6bHPjT1zDXJKdypl9iivtwyPlKX/9eCq/YqaK+Iu BWm6b0pbXYtrWPXRj7GPsRq0ghVWt5Gr/dEag= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=S7JkzSF7lxJgCpd6ZXDkhdvjrfqNJJ5Wge2dT4ZFw7o=; b=mUKcIbNdfjR0LNA2BV8Jrd/Mi8E89+l6plr1LyyqoCI7h29KbnsEOmH1jfyIMFuRc/ TiqzmHMvGE6TdmMPF4R4hXW3dEPTQPlPS1SwOMxgauBSRyET+vGrCvarmMws+pFNWpS+ 1M0EHkca96HQUYsToZ3iognZWwxngWwIZ+4iQWbA0bDIBUcbBfl2YNB18vLO/cHFYwfI 5BMij0J7INr0TGzCC/9NWErZCzT2z94yq3Cw8ZWn0BD2bquyrlbL3KcicrvG0NpteBoG ghVaiQQuivwhyWssYpkjQ7o6s7nKmdnlY+qv28FdryJLh2tvX2mCqxDaHxB6WJuHhtqJ Zr+g== X-Gm-Message-State: AOAM532khKOzRs+P2GzO7K8UK+o6BzOALXr9KYnh+2iiOdVYBxDJVsTL 6cX8zsdKp1eyArLgt0PReb8yiA== X-Received: by 2002:a63:6c44:: with SMTP id h65mr4438729pgc.100.1643324915912; Thu, 27 Jan 2022 15:08:35 -0800 (PST) Received: from localhost ([2620:15c:202:201:723d:38a9:9e7f:3435]) by smtp.gmail.com with UTF8SMTPSA id f8sm4740841pfe.204.2022.01.27.15.08.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jan 2022 15:08:35 -0800 (PST) From: Brian Norris To: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Rob Herring Cc: linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Lin Huang , linux-arm-kernel@lists.infradead.org, Derek Basehore , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Heiko Stuebner , Brian Norris Subject: [PATCH v2 06/15] PM / devfreq: rk3399_dmc: Drop undocumented ondemand DT props Date: Thu, 27 Jan 2022 15:07:17 -0800 Message-Id: <20220127150615.v2.6.I4bd77eb751d5bfce8346bfed576bcacb28e4550f@changeid> X-Mailer: git-send-email 2.35.0.rc0.227.g00780c9af4-goog In-Reply-To: <20220127230727.3369358-1-briannorris@chromium.org> References: <20220127230727.3369358-1-briannorris@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These properties are: * undocumented * directly representing software properties, not hardware properties * unused (no in-tree users, yet; this IP block has so far only been used in downstream kernels) Let's just stick the values that downstream users have been using directly in the driver and call it a day. Signed-off-by: Brian Norris --- (no changes since v1) drivers/devfreq/rk3399_dmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c index 293857ebfd75..e982862f6ac2 100644 --- a/drivers/devfreq/rk3399_dmc.c +++ b/drivers/devfreq/rk3399_dmc.c @@ -430,10 +430,8 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) goto err_edev; } - of_property_read_u32(np, "upthreshold", - &data->ondemand_data.upthreshold); - of_property_read_u32(np, "downdifferential", - &data->ondemand_data.downdifferential); + data->ondemand_data.upthreshold = 25; + data->ondemand_data.downdifferential = 15; data->rate = clk_get_rate(data->dmc_clk); -- 2.35.0.rc0.227.g00780c9af4-goog