Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <61f35591.1c69fb81.48dad.3244@mx.google.com>
Date:   Fri, 28 Jan 2022 02:31:42 +0000
From:   CGEL <cgel.zte@gmail.com>
To:     Johannes Weiner <hannes@cmpxchg.org>
Cc:     akpm@linux-foundation.org, sfr@canb.auug.org.au,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Yang Yang <yang.yang29@zte.com.cn>
Subject: Re: [PATCH] psi: Treat ksm swapping in copy as memstall
References: <20220116152150.859520-1-yang.yang29@zte.com.cn>
 <YeVdvVVBvrXH5U0L@cmpxchg.org>
 <61e7ac25.1c69fb81.e8938.bc67@mx.google.com>
 <YegK7+oKFG8EPRp9@cmpxchg.org>
 <61ea820f.1c69fb81.e79d5.09c9@mx.google.com>
 <YfNG5KAog6fI0kYu@cmpxchg.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YfNG5KAog6fI0kYu@cmpxchg.org>
Precedence: bulk

On Thu, Jan 27, 2022 at 08:29:08PM -0500, Johannes Weiner wrote:
> On Fri, Jan 21, 2022 at 09:51:08AM +0000, CGEL wrote:
> >  Wed, Jan 19, 2022 at 07:58:23AM -0500, Johannes Weiner wrote:
> > > On Wed, Jan 19, 2022 at 06:13:54AM +0000, CGEL wrote:
> > > > I did a test, when we use zram, it takes longer time for ksm copying than
> > > > swap_readpage(). Ksm copying average takes 147263ns, swap_readpage()
> > > > average takes 55639ns. So I think this patch is reasonable.
> > > 
> > > Ok, that sounds reasonable to me as well. Please add the
> > > PageWorkingset() check and resubmit the patch. Thanks!
> > I am a litte confused about adding PageWorkingset(), since I
> > think ksm_might_need_to_copy() memstall is like swap_readpage()
> > memstall and swap_readpage() doesn't add PageWorkingset().
> 
> That's actually a bug! It should do that.
I recently found that too. Please CC to me your new patch, thanks!
And I will send V2 of this patch "psi: Treat ksm swapping in copy
as memstall" with PageWorkingset().

> That psi_memstall_enter() in swap_readpage() was added by commit
> 937790699be9c8100e5358625e7dfa8b32bd33f2. It's for catching the
> scenarios that don't go through submit_bio(). When you look at
> submit_bio(), it counts stalls only if we have workingset pages:
> 
> 	/*
> 	 * If we're reading data that is part of the userspace workingset, count
> 	 * submission time as memory stall.  When the device is congested, or
> 	 * the submitting cgroup IO-throttled, submission can be a significant
> 	 * part of overall IO time.
> 	 */
> 	if (unlikely(bio_op(bio) == REQ_OP_READ &&
> 	    bio_flagged(bio, BIO_WORKINGSET))) {
> 		unsigned long pflags;
> 
> 		psi_memstall_enter(&pflags);
> 		submit_bio_noacct(bio);
> 		psi_memstall_leave(&pflags);
> 		return;
> 	}
> 
> I hope that clarifies it. I'll send a patch to fix up swap_readpage().
> 
> Thanks