Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <b773a0ab-e226-6acb-eab5-24036b0cf6f4@nvidia.com>
Date:   Thu, 27 Jan 2022 21:57:34 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] mm: Fix invalid page pointer returned with FOLL_PIN gups
Content-Language: en-US
To:     Peter Xu <peterx@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Jan Kara <jack@suse.cz>,
        =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Alex Williamson <alex.williamson@redhat.com>
References: <20220125033700.69705-1-peterx@redhat.com>
 <f5400544-f602-0bb4-5cb1-5ac682e41974@nvidia.com>
 <20220127004206.GP8034@ziepe.ca> <YfJjhop3senAUjue@xz-m1.local>
 <20220127152538.GQ8034@ziepe.ca> <YfNIjqPpty0YkLJP@xz-m1.local>
 <20220128023127.GR8034@ziepe.ca> <YfNiWHDYH0dtj9rK@xz-m1.local>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <YfNiWHDYH0dtj9rK@xz-m1.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1ZvMXpWMnVkY01jd1htdHlvVUEyUjV5Yi9jRXBNRHAzbTZrNFltanYvSkM5?=
 =?utf-8?B?UG9TYzQxSGUyUmRIZUtaKzFLdkgwNE9FUG9vMXgyZWtIYUVJSERTamljVVlX?=
 =?utf-8?B?cjA4akZZcXVwWUhpN3B4eitzWkJQMlN0emM5NVVDaVI0MEFyOVkva2RPb29p?=
 =?utf-8?B?K0t6VW9sUERIRWZKKzZxWVo2ZVJyeW5QRHRVeWtlWTUxVUtKSHE3UGNVRk9V?=
 =?utf-8?B?ZlJUMk9WbVprcHdIWFdwSFMwN3hlUThXTjhVdVhxbjFaYmRkMkZ6WFlCSExz?=
 =?utf-8?B?NDN6RFIyS1U2WlozZTY1VjUxR1JkSEZxQTZVZUR5NEFHVVhJRVZQekRyc08y?=
 =?utf-8?B?T1I5d2lyK2krSllPM2dTUG9NdzdEeFgxK01hMUNiWjdIbyt4K2JSc3QzOW9B?=
 =?utf-8?B?b2N2SnJGUlNUTTV0dEdnMEp0SnRlMWIyN04vSkhCanBTM0hXS2o4bWRlSzZq?=
 =?utf-8?B?MTY2WnQ1dlQyM2FnbGduQkg4V215QzdkMkQvUmw4UUhMOE96MFl6NlRxQ2RO?=
 =?utf-8?B?U2V5S2V5RHk5dDlPZUZxZG9IOVc5eHRNelJGTGpmOVlVQ3VTWE9WNC9vWm1m?=
 =?utf-8?B?V09QblZtaE1aU0thaGt2b0lYYTBWbGJ2UWk5QlpGRFZSM2tjV0tTdTRrV2VC?=
 =?utf-8?B?UHp1WnlTSmR1UTdyV25YdjJsU3ZrMG5oMWM1eFNoZlFNa3l0ODBPckZkRWxq?=
 =?utf-8?B?aUorTktsYWxMY0ZGRm5lekYyWVpkeG8rUFNqazgveWVZRXZSSzBUanlFei9u?=
 =?utf-8?B?Y3pxWitxdWtINy91YVFkNUIvRXNyb0FibGRJZlVTbStDaURKdWFPUm4zdmMz?=
 =?utf-8?B?UFUvMXIrTm05SWJBYUNyeGloajhENmFTU3RiTlJlY1o2MzhaN1VmeDkzWVlx?=
 =?utf-8?B?KzJFNXo5OEJBTmJVQThqd2pqTnRUUE1jZHdtOTdoclVyOG9UdE1LanExamQv?=
 =?utf-8?B?WVJZSE1RTi9FTi91SDdXWE1iQ1dyWlk0Ulh3d2ZKQW5reHNaN1NvT2RKWWVX?=
 =?utf-8?B?T01hNmhXN1lHRVNwWXFCK2pNZ1VFMmFjVTBtV1YrNkFLM2dVcjRNR1VDNG5R?=
 =?utf-8?B?aXVBM0xNMjl6U1l1cUxWTUtjQ2JJMm1JMkZMTUZUYUpJSzAyQTVjc1FTSTFq?=
 =?utf-8?B?d2plOE85TUlIQ294SmhmUGoyejVWTm4wbEdxZnFHclZrVTBsYitWQ3lCdUVR?=
 =?utf-8?B?VTN3Z0ZqdWEyc2dWMGZadC9Ud3BUTUJQVG95T3BSK21vNEg3YnZFNXpIU3FN?=
 =?utf-8?B?ckRVOHVTK1IzM2hvSnRGV0tsVkVuMy93WHdRVlpsdWVYb2ViV1lKWHloMDNU?=
 =?utf-8?B?cEdOYitqbGlrZWdmczdXamtGNm9XeGRZcEFMdDVodzVVa0YySlZlTDM2ajJn?=
 =?utf-8?B?VDFaV256TzdMODVmYXNpR1JkRWFxQ0I3OTVrS2kwM3BZbHZMVGxha3V2bWR1?=
 =?utf-8?B?MS9oakFnU0J2THc5RHU4Z1dFaWlNMGlGcU9FR09VM3dVK0xsVUZZRDc3YTRn?=
 =?utf-8?B?eE5IN0dhczZBUitMV1dYZ1lmYVNJNHRWc1g3RWRLcEpZK2tUd3hOdHk0MUo1?=
 =?utf-8?B?bFIvSE9kbHdlY2hZZEJwL29BbG5SRXZXbFl5V1llUG94bFRpWmtOOTlWUkx5?=
 =?utf-8?B?STFaQ25id1hOOUdNSnhnRTB2ZnBPaGlZMUNnT1lVTEdlQWk0a0dYVXBBK2dV?=
 =?utf-8?B?U2VwbUk3UjQzSnk5R0FrcUhXYUpCN2gwQk4zWkpEUEdMYy9JREJZNjZ6VEs0?=
 =?utf-8?B?UEFLOGFZVGljSGlnSS9zMTZrYjNmRGZ3bVYxZEhycWk0Q3c2ck4rNEtSUDZu?=
 =?utf-8?B?Q3BPMEV1c01zb3dUbHdmUkdDVUVxV2dLVlNyc01KSTJBWGVRWmJWNy8vcW5L?=
 =?utf-8?B?VCs4ZE1ZWUZBQmlTVnhJR0MvaWMrbzlxNFR0YThKU0hHNUM4Y2dOR3hmVlJR?=
 =?utf-8?B?VnU4bWR6SlYycUl3QlpFelRqUG0rUHhCOGFURjRCcVQ4RlZJNjE5SDlicTV3?=
 =?utf-8?B?MEFhL0ZxRXhPMXI5eVVjeDNsVENFM2tja00wQndwVXh4c3RhQ2NySXFDYTIy?=
 =?utf-8?B?WlRKTUlWVUdiYVNkVmF0Sk15YXVPMXBLeWtxWHVvOWtUOERuTXRHZTYycEd4?=
 =?utf-8?B?VEhEbkozT3VZSmg2TWtCb2FBVHhRbjlsaVFKRGRYZ254VnNnWXJtN0haK3pN?=
 =?utf-8?Q?9j09BKwhWxY7J8M2OaDoLpA=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6886bfdc-12d5-4747-cd13-08d9e22315d8
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2022 05:57:36.9630
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qjXhotrKpUjPzYkBr1TNJyZyuUu69WtSnCnnCgd3z/qRX5i7Jepl7fLKu0V8+bdblZDpChb0acgOn8woSp9pJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3160
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/27/22 19:26, Peter Xu wrote:
...
> I see that both you and John has a strong preference on at least the
> WARN_ON_ONCE() in the patch.
> 
> Do you think it's okay I repost with only the one-liner fix, which will keep
> the Fixes but drop the WARN_ON_ONCE?  Then we can leave the rest as follow up.
> 

I think that's OK with me, anyway. You'll recall that I initially requested
that you split this into two patches, after all.

Would you like me to post a follow-up that does the refactoring that Jason
and I are requesting? I see that we have some fundamental differences in
opinion about how this should be done, so rather than drive you crazy with
debating, maybe that would be smoother?  :)


thanks,
-- 
John Hubbard
NVIDIA