Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 Jan 2022 22:20:52 -0800
From:   Benson Leung <bleung@google.com>
To:     Prashant Malani <pmalani@chromium.org>
Cc:     linux-kernel@vger.kernel.org,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Benson Leung <bleung@chromium.org>,
        "open list:CHROMEOS EC USB TYPE-C DRIVER" 
        <chrome-platform@lists.linux.dev>,
        Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH] platform/chrome: cros_ec_typec: Make try power role
 optional
Message-ID: <YfOLRBGmwGKwCksR@google.com>
References: <20220127191659.3560810-1-pmalani@chromium.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="DXB3UyVkHi0h/pnn"
Content-Disposition: inline
In-Reply-To: <20220127191659.3560810-1-pmalani@chromium.org>
Precedence: bulk


--DXB3UyVkHi0h/pnn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Prashant,

On Thu, Jan 27, 2022 at 07:16:59PM +0000, Prashant Malani wrote:
> Some boards prefer not to specify a try-power-role. Update the port
> property parsing logic to not error out in case a try-power-role is not
> specified.
>=20
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>

This looks good to me.

Heikki, if this usage of TYPEC_NO_PREFERRED_ROLE looks good to you, I can
merge it.

Benson

> ---
>  drivers/platform/chrome/cros_ec_typec.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
>=20
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/c=
hrome/cros_ec_typec.c
> index 5de0bfb0bc4d..ee12658009e5 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -115,17 +115,18 @@ static int cros_typec_parse_port_props(struct typec=
_capability *cap,
>  		return ret;
>  	cap->data =3D ret;
> =20
> +	/* Try-power-role is optional. */
>  	ret =3D fwnode_property_read_string(fwnode, "try-power-role", &buf);
>  	if (ret) {
> -		dev_err(dev, "try-power-role not found: %d\n", ret);
> -		return ret;
> +		dev_warn(dev, "try-power-role not found: %d\n", ret);
> +		cap->prefer_role =3D TYPEC_NO_PREFERRED_ROLE;
> +	} else {
> +		ret =3D typec_find_power_role(buf);
> +		if (ret < 0)
> +			return ret;
> +		cap->prefer_role =3D ret;
>  	}
> =20
> -	ret =3D typec_find_power_role(buf);
> -	if (ret < 0)
> -		return ret;
> -	cap->prefer_role =3D ret;
> -
>  	cap->fwnode =3D fwnode;
> =20
>  	return 0;
> --=20
> 2.35.0.rc0.227.g00780c9af4-goog
>=20

--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--DXB3UyVkHi0h/pnn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCYfOLRAAKCRBzbaomhzOw
wr3iAQD/4S0peXsqQPgEW97XtZgI0CWsqWPDzkEiLGb1GzRVRAD/beUy77nVEHUn
TvwKDo2LAlHrBFbVWaThHWLRSIFB1gU=
=+z/0
-----END PGP SIGNATURE-----

--DXB3UyVkHi0h/pnn--