Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 28 Jan 2022 10:03:31 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Stefan Wahren <stefan.wahren@i2se.com>
Cc:     cgel.zte@gmail.com, nsaenz@kernel.org, rdunlap@infradead.org,
        unixbhaskar@gmail.com, dave.stevenson@raspberrypi.com,
        bcm-kernel-feedback-list@broadcom.com,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        "Minghao Chi (CGEL ZTE)" <chi.minghao@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] vchiq-mmal: Remove redundant 'flush_workqueue()' calls
Message-ID: <20220128070330.GD1951@kadam>
References: <20220127014432.1185206-1-chi.minghao@zte.com.cn>
 <fdbe3eaf-c737-0714-6b54-8a7cdbe38a0c@i2se.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fdbe3eaf-c737-0714-6b54-8a7cdbe38a0c@i2se.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yEpe57fmyDg4+En46hbZG+nOkayH9hCvwS4vmMiw2yvKtNvap+3UKHBrT9Od?=
 =?us-ascii?Q?zEiF85SWdJ9D0pVr/AUvm35U7dHgT6PoibE2T3ABomaGybRE1JN1WLy3zF5s?=
 =?us-ascii?Q?ZsEFEOC9xJa1wfF4rbkuYyJenZiiW8TX+4TN9Al2/Ctwg3aANqKyGwQxJaEf?=
 =?us-ascii?Q?QWI8f0uR0mPN8ZDOpRGeeRQDoxSsGMWzlsSjI4i0evEo0graNOLVbC7xwPWE?=
 =?us-ascii?Q?3T6AF3BjV15lsJ40DGCVZGJdxPeKEN3jF0Qe+zbIOiB4dyGwq714pUPmwy7K?=
 =?us-ascii?Q?876M18v00QvawoIiOt8odPN837vW0V/cWYeJSUVDXNBtdU87zdXc0A7ApkGD?=
 =?us-ascii?Q?qsbCY11ThbfM7y1V/K2sRk41oVrZVUckV5OL22IE64pA1KEJFuhf9A4NfnbX?=
 =?us-ascii?Q?AgFO5dkFLDpJOfS5Ul0kpqL/gPzeMG2VO73pVfXo8gpY5VX10HJ/c7sgCYWB?=
 =?us-ascii?Q?4pU9IlFIYwtrRkI8z62FeZUKN96e04DxzS2bo30O7Imu/+XmqP+C9Tw71bml?=
 =?us-ascii?Q?4TTHaPumitmL2+OeyYe6XNZd+h9GLXf43qIZ1C4UBJmFGYUydTLDd7pSOhdt?=
 =?us-ascii?Q?koSYUZxGZh/Jezh0sZZgc+OLjnNcOqQTO0Ks1ELbEtwdTHGrSwi0LgsLzHuI?=
 =?us-ascii?Q?O0NvUnSqFgudXEwlCEY7hTzK9s6yDLVyisTGXo50tjwZbQGtT7X+nvP3QjnF?=
 =?us-ascii?Q?NfUaQh6FQ7KYl4FKc7JlTwFf44jpp3ePHjalQOe2yi7yULizgUOypIXUVcCp?=
 =?us-ascii?Q?Ne++TRfZklk30/Gd0wsLvjPRD/KhIk17QIidKxim7Pq49nHiV7UJcia1zNTQ?=
 =?us-ascii?Q?Y71i+XDdGLAVyf4Gl0RcEBGlwu2kC3s0sd0nKJ3JnMoAxBiuF04zILzuy6fi?=
 =?us-ascii?Q?5JWxLJ3Al3zq/t4Xp/vq+MwJkVgx4JkhmeKltCGyfDhtvJfp7VMAtzIq4zMK?=
 =?us-ascii?Q?r6YlYdToTPGo8gYi7/y8Fy2bA7oZ23GZR3PFTimuvdiltJWHxFfl/YJsVNiX?=
 =?us-ascii?Q?rCne6YCjzQeskmZHfe9R6A65kYLQw3+6BitXeOghdQfuwpjuNdvXYCXDxIdw?=
 =?us-ascii?Q?68BF8/e6+jgadzaRT+7Vk03/UHa0u7dbIkz4QTbRNTJeSgC+T2DEWHTb4PvM?=
 =?us-ascii?Q?9lpMYOYAqBYJ1Fp09k+6Fa5bClgZvw6OQPoByvHq6OrAd58yVEcs64lsb83k?=
 =?us-ascii?Q?tha9ojAmmcADiu9jceR3xV9kP9rqa/1hbXUy76g86JOAjmhrcoFTR26C/7a7?=
 =?us-ascii?Q?XzrWGpmTBjn9EH/ogIrtoLyuxgHOxlSaIhGNaCuYfrsA1mPZbwBAExFyFt5c?=
 =?us-ascii?Q?XDJtnl4tiyk78Zc6+QN1Sb86VrCZCrre66rf2WuFWVPLvnH1Y3pT9aYj563h?=
 =?us-ascii?Q?cDx7cex2BD1RdnF8n2irLuZor5XqnMi3eJAVPwbRc4BEPnHZzOZw5OId+4uE?=
 =?us-ascii?Q?go/U0qbF3YkKO9Re1qtdrKAy79MSrdBumAl8YZmISlzhoVTvZ24zQKB3+5lL?=
 =?us-ascii?Q?V/1xSGu7ea3Bmn72/KF/zd1eXseFGk3cmkKb18D+Qul+vIn5+HQEAXBx5TtJ?=
 =?us-ascii?Q?dFbb6QkX0h9eeFA7RmhWOzc73cIx6xG5qLmSpErNXy2XaLL/Ncsf4jaQkVwq?=
 =?us-ascii?Q?L4N/knfwJXj++jLNs7UBh1LovG+r8U3RTISavifkPfIaVSTgHv+GzjmGldvs?=
 =?us-ascii?Q?nXGTtKB2ld3bMZOAijzDunGgaJE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab24f7ce-1401-435a-0248-08d9e22c5973
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1001MB2358.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2022 07:03:56.1002
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3kV2vVET+PsEayTEMF0pjwXg9q9N7rWkxeSS1h5hbW4uF3y2mHmvdyfkZmbj/utn4bH1OShD5GzHRP5/5JX7UgTu3z1P9NNYCfCCOvBSTGc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4955
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10240 signatures=669575
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0
 suspectscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2201280043
X-Proofpoint-GUID: UCkeruIaNKza7dF7FcBuaz67qsf6jsTq
X-Proofpoint-ORIG-GUID: UCkeruIaNKza7dF7FcBuaz67qsf6jsTq
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 27, 2022 at 01:35:09PM +0100, Stefan Wahren wrote:
> Hi,
> 
> Am 27.01.22 um 02:44 schrieb cgel.zte@gmail.com:
> > From: "Minghao Chi (CGEL ZTE)" <chi.minghao@zte.com.cn>
> >
> > 'destroy_workqueue()' already drains the queue before destroying it,
> > so there is no need to flush it explicitly.
> >
> > Remove the redundant 'flush_workqueue()' calls.
> are you sure that drain_workqueue() is the same as flush_workqueue()?

drain_workqueue() calls flush_workqueue() repeatedly.

regards,
dan carpenter