Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 28 Jan 2022 09:21:03 +0100
From:   Henning Schild <henning.schild@siemens.com>
To:     Aaron Ma <aaron.ma@canonical.com>
Cc:     Mario.Limonciello@amd.com, kuba@kernel.org,
        linux-usb@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        davem@davemloft.net, hayeswang@realtek.com, tiwai@suse.de
Subject: Re: [PATCH v3] net: usb: r8152: Add MAC passthrough support for
 RTL8153BL
Message-ID: <20220128092103.1fa2a661@md1za8fc.ad001.siemens.net>
In-Reply-To: <20220128043207.14599-1-aaron.ma@canonical.com>
References: <20220127100109.12979-1-aaron.ma@canonical.com>
        <20220128043207.14599-1-aaron.ma@canonical.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ng/H61NBfilsfl+Rw/TBeh9XG2mnvdTtY5D/yr7WQKeuap2XqkjEuQDDtgeM?=
 =?us-ascii?Q?OcmvOyD+iymRwsv3zE17yrjEmtFAMgE7bdHbf96UX4fnzggoSwiSjvTy3JQN?=
 =?us-ascii?Q?3yQ9UswTNBPmj4eHiBEqx8fTQ3e33WM+SbUp6kPoMEeyVJlvnfMk+Z4c/r7r?=
 =?us-ascii?Q?LGwIG8mTiOCIw1zTxi+RJWmEkWGRXCDKXo6WI0PblCBx/O5fonD3nYnzZc6p?=
 =?us-ascii?Q?/WwSqTzm9bcsG0cr3GbXp7/WXXvHqc6JNLdsPF1XQcKSNhD5pz6Gv/8EIxhr?=
 =?us-ascii?Q?eu9UER1hPMpCUV3ZAU80d42tyg6YiPhs2O8iWi9gIbYt1o6/eCR+pBPuOrTF?=
 =?us-ascii?Q?XTPdLo7RlCJ/VMIzI4kckmfYbTPBB567Yd97MG0L2704DThunCEO35hqxQOh?=
 =?us-ascii?Q?wPnLlXZFZYH5IpfUDF40tgkyQj0qnmAPWndJIpcaZDKmhK8R1nqclZu5p3fy?=
 =?us-ascii?Q?zG4NeshDiNogVwtePglxv7wBTu33c5WFLxEBgHXDq6/5hftXFmb72AouCYYR?=
 =?us-ascii?Q?Ax718iauKGfOzNd7gEqwu5DPfctpi9Y7v4vnIfEBbhkeiieVhYiIGXQ9aIOQ?=
 =?us-ascii?Q?eYRwQcqJ3nfthjzL2CFoUtMTMzIYFRf0K9MfxlzTEAJG/s4tUqf0Q3hmBeXx?=
 =?us-ascii?Q?XrrWhJkSNCf1dChlEp2MFf85hTQUClpSoiZXHqAnwMsezwbpsVFeXUJQl75T?=
 =?us-ascii?Q?WJR3ejMCy6o8DFGLMXXw0W9z2UQWBQK4BXr6PfJcz8JTTk6P8+0qFDC93Tan?=
 =?us-ascii?Q?IE96+ryx8a/lRj/Nq4A2SA2xF7CUALSaE1ROcXKsY81ukcrBmYD/9YD5iIgN?=
 =?us-ascii?Q?RLvMaWLRKvpAOHAsnrJDkfbGQlPMFbwvMHe9efLM6cR0/xWQ8AWGu1a/ncXT?=
 =?us-ascii?Q?+Ebm26+dGu9hVkHvdVK5ejRmR1R19eopgSSaQLUk2M3XwO/5SngV71o3EuFs?=
 =?us-ascii?Q?MNAq9x255vpqLAvk9ZWJdC2ODvX1RCx5D/Iyhf31jhLS5MGvOKwpMRAaVSoR?=
 =?us-ascii?Q?xuGsOhhCYGfhuMvDvrFW3+NB37ypirWGxy6+hXa7f0G4+bvO+9zwfEhGBYtc?=
 =?us-ascii?Q?rlKItKC6CYUqIlzbRn4pnfm5ZCIv7sjyoIFvqI373wOvMHCWeQ0n3w8HJFc4?=
 =?us-ascii?Q?8fVEoBW3EZuwf0j+2LeZBxZfvMYXktBQfaGsoXYHZyyYfNdxXuzVLl3oQPFc?=
 =?us-ascii?Q?2Hw22jSz5g1y1z64oJoA5OQd+uMgZdWYva+EXD2jsoWAbiUPjvWromua2YS2?=
 =?us-ascii?Q?gvERaWKfaZVz4+z3enN6vj705BK1PKlcTwlsEcwy6GQHWYzLfZe4ESGp/gly?=
 =?us-ascii?Q?kQQuJV93HWsV30AT3ehXKvSiOusXHGy4kwgA2jSWzTlaEdF4cz0gL/ZPsoFR?=
 =?us-ascii?Q?5DCu7OQy/OTKHMtrLl/S2Z5XlH+zs2lI+v1BZIu6isBJ+f5Wm7Wl2GRlQQHQ?=
 =?us-ascii?Q?KmWK8WqIJg68aqnOZYFcqiaU8OGKQHS5/M5YeBh2cMyjvUnTlQNNsJHevn39?=
 =?us-ascii?Q?rEKml7iqV1ss71imSEZHbYg3Sd38S/DsuVRvtyDjtUf+53hNDKHjwV+g2Og5?=
 =?us-ascii?Q?nIxGYfVYXMVIoF3nrF/K5luO+Ockyz0Oi0fuN5LpWOVf1Bm2wpIM7N8ORDMF?=
 =?us-ascii?Q?4+fKLDfml2BPRGAP+8DJGj1+5Cb7suoYHYJyiK0iuGIvdileguJChXBeQxiL?=
 =?us-ascii?Q?ev9iA1wnCTs+Eu5BN/3ZWX0lEk2x6IL9zA+sFb7tjXEQKAaIJ1jO7OhZR7Ii?=
 =?us-ascii?Q?855+Vp128Q=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c40d29b5-07e3-482d-445b-08d9e237213b
X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2022 08:21:05.9410
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CPyi86RVTIT5Kk+5D1OodXY0+7iMZVhyipl/dYUEFtlotwjsOSirOJxNLyg0Bsij/eM7F1/equ1kngTuhL9jsbWnmCxlwfDSG1AUa4kWxpQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR1001MB1214
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I am still very much against any patches in that direction. The feature
as the vendors envision it does not seem to be really understood or
even explained.
Just narrowing down the device matching caters for vendor lock-in and
confusion when that pass through is happening and when not. And seems
to lead to unmaintainable spaghetti-code. 
People that use this very dock today will see an unexpected mac-change
once they update to a kernel with this patch applied.

But given that some people seem to want that feature in the kernel, i
will stop here and simply disable the feature in the bios. And i will
make sure _not_ get any lenovo gear for my lenovo laptop, not sure that
matches the vendor-vision.

Henning

Am Fri, 28 Jan 2022 12:32:07 +0800
schrieb Aaron Ma <aaron.ma@canonical.com>:

> RTL8153-BL is used in Lenovo Thunderbolt4 dock.
> Add the support of MAC passthrough.
> This is ported from Realtek Outbox driver r8152.53.56-2.15.0.
> 
> There are 2 kinds of rules for MAC passthrough of Lenovo products,
> 1st USB vendor ID belongs to Lenovo, 2nd the chip of RTL8153-BL
> is dedicated for Lenovo. Check flag and the ocp data first,
> then set ACPI object names.
> 
> Suggested-by: Hayes Wang <hayeswang@realtek.com>
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> ---
> v1 -> v2: fix whitespace in definition.
> v2 -> v3: check flag of vendor/product ID to avoid it return error
>  drivers/net/usb/r8152.c | 45
> +++++++++++++++++++++++------------------ 1 file changed, 25
> insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index ee41088c5251..d8350d229f5c 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -718,6 +718,7 @@ enum spd_duplex {
>  #define AD_MASK			0xfee0
>  #define BND_MASK		0x0004
>  #define BD_MASK			0x0001
> +#define BL_MASK			BIT(3)
>  #define EFUSE			0xcfdb
>  #define PASS_THRU_MASK		0x1
>  
> @@ -1606,31 +1607,35 @@ static int
> vendor_mac_passthru_addr_read(struct r8152 *tp, struct sockaddr *sa)
> acpi_object_type mac_obj_type; int mac_strlen;
>  
> +	/* test for -AD variant of RTL8153 */
> +	ocp_data = ocp_read_word(tp, MCU_TYPE_USB, USB_MISC_0);
> +	if ((ocp_data & AD_MASK) == 0x1000) {
> +		/* test for MAC address pass-through bit */
> +		ocp_data = ocp_read_byte(tp, MCU_TYPE_USB, EFUSE);
> +		if ((ocp_data & PASS_THRU_MASK) != 1) {
> +			netif_dbg(tp, probe, tp->netdev,
> +					"No efuse for RTL8153-AD MAC
> pass through\n");
> +			return -ENODEV;
> +		}
> +	} else {
> +		ocp_data = ocp_read_byte(tp, MCU_TYPE_USB,
> USB_MISC_1);
> +		if (tp->lenovo_macpassthru ||
> +				(tp->version == RTL_VER_09 &&
> (ocp_data & BL_MASK))) {
> +			/* test for Lenovo vender/product ID or
> RTL8153BL */
> +			tp->lenovo_macpassthru = 1;
> +		} else if ((ocp_data & BND_MASK) == 0 && (ocp_data &
> BD_MASK) == 0) {
> +			/* test for RTL8153-BND and RTL8153-BD */
> +			netif_dbg(tp, probe, tp->netdev,
> +					"Invalid variant for MAC
> pass through\n");
> +			return -ENODEV;
> +		}
> +	}
> +
>  	if (tp->lenovo_macpassthru) {
>  		mac_obj_name = "\\MACA";
>  		mac_obj_type = ACPI_TYPE_STRING;
>  		mac_strlen = 0x16;
>  	} else {
> -		/* test for -AD variant of RTL8153 */
> -		ocp_data = ocp_read_word(tp, MCU_TYPE_USB,
> USB_MISC_0);
> -		if ((ocp_data & AD_MASK) == 0x1000) {
> -			/* test for MAC address pass-through bit */
> -			ocp_data = ocp_read_byte(tp, MCU_TYPE_USB,
> EFUSE);
> -			if ((ocp_data & PASS_THRU_MASK) != 1) {
> -				netif_dbg(tp, probe, tp->netdev,
> -						"No efuse for
> RTL8153-AD MAC pass through\n");
> -				return -ENODEV;
> -			}
> -		} else {
> -			/* test for RTL8153-BND and RTL8153-BD */
> -			ocp_data = ocp_read_byte(tp, MCU_TYPE_USB,
> USB_MISC_1);
> -			if ((ocp_data & BND_MASK) == 0 && (ocp_data
> & BD_MASK) == 0) {
> -				netif_dbg(tp, probe, tp->netdev,
> -						"Invalid variant for
> MAC pass through\n");
> -				return -ENODEV;
> -			}
> -		}
> -
>  		mac_obj_name = "\\_SB.AMAC";
>  		mac_obj_type = ACPI_TYPE_BUFFER;
>  		mac_strlen = 0x17;