Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423184AbXBHJRn (ORCPT ); Thu, 8 Feb 2007 04:17:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1423172AbXBHJRn (ORCPT ); Thu, 8 Feb 2007 04:17:43 -0500 Received: from wx-out-0506.google.com ([66.249.82.225]:63217 "EHLO wx-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423184AbXBHJRl (ORCPT ); Thu, 8 Feb 2007 04:17:41 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=nJaYh4X1onEc9E0JqEVkFcMPrzZUQ/11sjKCkYrVhDUSwLow7tRgNB1+ce8pjvI8OdrIsycsyGjuqjxhigGAdQbg6+3TM48JZSzbzyD9ziG1wiRtq/V763XfNyWN/kY1YckxLPYYI8tuQshtJdXVhR47gGaF8mk8j0robB9KIkY= Message-ID: <3877989d0702080117j6ee666aahbb89ca0098ca38a5@mail.gmail.com> Date: Thu, 8 Feb 2007 17:17:40 +0800 From: "Luming Yu" To: "Zhang, Yanmin" Subject: Re: [PATCH] ATA convert GSI to irq on ia64 Cc: LKML , linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, "Jeff Garzik" In-Reply-To: <3877989d0702080115o15feb447h73e3fa310bc09fb4@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1170920422.15989.354.camel@ymzhang> <3877989d0702080115o15feb447h73e3fa310bc09fb4@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2004 Lines: 55 sorry, it should be #define ATA_PRIMARY_IRQ(dev) ide_default_irq(0x1F0) On 2/8/07, Luming Yu wrote: > if use ide_default_irq , then I guess the #if defined can be removed. > #define ATA_PRIMARY_IRQ(dev) isa_irq_to_vector(0x1F0) > > > On 2/8/07, Zhang, Yanmin wrote: > > If an ATA drive uses legacy mode, ata driver will choose 14 and 15 as the > > fixed irq number. On ia64 platform, such numbers are GSI and should be converted > > to irq vector. > > > > Below patch against kernel 2.6.20 fixes it. > > > > Signed-off-by: Zhang Yanmin > > > > --- > > > > diff -Nraup linux-2.6.20/include/asm-generic/libata-portmap.h linux-2.6.20_fix/include/asm-generic/libata-portmap.h > > --- linux-2.6.20/include/asm-generic/libata-portmap.h 2007-02-08 15:13:44.000000000 +0800 > > +++ linux-2.6.20_fix/include/asm-generic/libata-portmap.h 2007-02-08 15:20:13.000000000 +0800 > > @@ -3,10 +3,20 @@ > > > > #define ATA_PRIMARY_CMD 0x1F0 > > #define ATA_PRIMARY_CTL 0x3F6 > > +#if defined(__ia64__) > > +#define ATA_PRIMARY_IRQ(dev) isa_irq_to_vector(14) > > +#else > > #define ATA_PRIMARY_IRQ(dev) 14 > > +#endif > > + > > > > #define ATA_SECONDARY_CMD 0x170 > > #define ATA_SECONDARY_CTL 0x376 > > +#if defined(__ia64__) > > +#define ATA_SECONDARY_IRQ(dev) isa_irq_to_vector(15) > > +#else > > #define ATA_SECONDARY_IRQ(dev) 15 > > +#endif > > + > > > > #endif > > - > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/