Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp2356425pxb; Sun, 30 Jan 2022 13:26:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJzcd0vUzS3jfnLP1KqR1fmgMdLviw+CxR95gDWMBfuVeNJ4qP9egWrMduCRqfL8j+4Z3CPU X-Received: by 2002:a05:6a00:15d6:: with SMTP id o22mr18001599pfu.35.1643577970523; Sun, 30 Jan 2022 13:26:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643577970; cv=none; d=google.com; s=arc-20160816; b=GXndPLmN8pJk7eTctPiEqdHjHZd9n0LM31zcBL/YwIPqfevvAENvLf/klQpzDUVWLV LtbdVo7hYB0hdg4aC0R3WWu0xMXnqywMOrU8CH7hH26EHQHp9SvZGQKJ+/WxOLFWpGck NPxZ/4tvVA7MrcoZYWuG8xtVFSc3jA8XthZuaSoxsd34P3gepK3vbZVNnvxx03FSm7bC uwJs55ujY7HyZIdvOalc6buvNcEVnlDn0yAJjR0UqTifAxXIR2L/X+03AiEN5vqAWlJW UmEK7I2o0soP6naKcU20liariUzQuSaF4n2+xQ0p0Q8ndJjS1+09EdkBliYqQsKIOR6r H7ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=wNPUfF1dwsGSwixCd2rgdU0h/HhD4TFDiOUvTQkWOEw=; b=Bil6XVo142i3Ni7kSTPSkHNNRaeoZVPp7graviTKveqT5pQ37m3EwG+1ZZISWEZnmM wfmv/4mDimtXiYa7vwlLyuxsMnAnWPJHMZNQ+0lTPbQzpdFfVaKLq/X4IGqEf4t5QO1p I1JgHpFCqWiNb0d92yY9sTgSx7yABMugRor8hcx6TMQW+be3kM/AvKRp/2/076ZQvnRk 6L/zxTNgvflF4BkSP4KhHSqjidioyzbQ3K8P2V9XFTWCFD8gvP4FK1Sftqq7tf7EfGyT MTKDwrdFg9GrBndg/OCi/GKeODo0niJDYTuzenvkD2K6082l7LjriAV7ZIdHyDZ21vLb rIbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=M7eajZzE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e188si11406402pgc.209.2022.01.30.13.25.59; Sun, 30 Jan 2022 13:26:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=M7eajZzE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243932AbiA1KML (ORCPT + 99 others); Fri, 28 Jan 2022 05:12:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243644AbiA1KMJ (ORCPT ); Fri, 28 Jan 2022 05:12:09 -0500 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8401CC061714 for ; Fri, 28 Jan 2022 02:12:09 -0800 (PST) Received: by mail-io1-xd36.google.com with SMTP id q204so7081355iod.8 for ; Fri, 28 Jan 2022 02:12:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wNPUfF1dwsGSwixCd2rgdU0h/HhD4TFDiOUvTQkWOEw=; b=M7eajZzEWKAncpyXdu/HipsM/BbPDnRWxumzOXgLR3bNg3puk4HY8RWpErAOAyvZRJ dLuxXEMFGu0r76nmAuFHh+cILobCzGgMKju5UFC+pQwBi0BdyNpldCDaDxu+H/aEyT2+ VrbLU9n4jkA5Fg45qihW1O4j0sGAVjEQ8z/sv+5jRl18OPR9yIxQWrEoOBp4y7DVK9Bm ipmTMEOSgZgqJra4/6TZczJGTqa/NEfaQTIkBqBaDYWSbalOaqIaBbwV7vADAvD6+wEw iSbxk6KLEW3Si+dazP8BDLOZAIgOGJiNTfTpQLxSjvsy1eIs64w9hm2UCFDlacn8hUgy B3Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wNPUfF1dwsGSwixCd2rgdU0h/HhD4TFDiOUvTQkWOEw=; b=NlnIAH9rDLpYMUhWFIeN/+n/ih2B9AKtBdeU1w9sytLHXFD3Ddb25E+Dck/uP3+iAm bGQJtSEeAhsvO81BYIntojGB7R356SLw/aByb4UbJJL6kGeLx0nNJnG3wo9+TvC3QxXl 704OHiPp+k1gbrbldecK8IORQIrOsF+IXsZjOKZAKNHTtzw6ll0P4+PczLwPktFoUdmn Ck/BlfNJi6T6E2x5DEFIS1hMuLTDD6KYzgkZGWTAj/ezecymOf59E4ROMbh2WnHofe82 9iIrjuBytg1j3OvvI4IviV1XzowNP3OoAlHESRXHxBOLs6XtPFGJEGb3LdLhIa+HPZjw vPnw== X-Gm-Message-State: AOAM532vZvyuFPl9vvkLi0NuXzT0WBwoll+RlW+MOd72XDjNelx3r2o8 1WPJFr8D5I0TFKczySKr7fVfyQVSWjZLtTaqMds= X-Received: by 2002:a5e:9249:: with SMTP id z9mr4758438iop.188.1643364728844; Fri, 28 Jan 2022 02:12:08 -0800 (PST) MIME-Version: 1.0 References: <20220111161937.56272-1-pankaj.gupta.linux@gmail.com> In-Reply-To: <20220111161937.56272-1-pankaj.gupta.linux@gmail.com> From: Pankaj Gupta Date: Fri, 28 Jan 2022 11:11:57 +0100 Message-ID: Subject: Re: [RFC v3 0/2] virtio-pmem: Asynchronous flush To: Linux NVDIMM , virtualization@lists.linux-foundation.org, LKML Cc: Dan Williams , jmoyer , Stefan Hajnoczi , David Hildenbrand , "Michael S . Tsirkin" , Cornelia Huck , Vishal Verma , Dave Jiang , Ira Weiny , Pankaj Gupta Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping > Jeff reported preflush order issue with the existing implementation > of virtio pmem preflush. Dan suggested[1] to implement asynchronous flush > for virtio pmem using work queue as done in md/RAID. This patch series > intends to solve the preflush ordering issue and makes the flush asynchronous > for the submitting thread. Also, adds the flush coalscing logic. > > Submitting this RFC v3 series for review. Thank You! > > RFC v2 -> RFC v3 > - Improve commit log message - patch1. > - Improve return error handling for Async flush. > - declare'INIT_WORK' only once. > - More testing and bug fix. > > [1] https://marc.info/?l=linux-kernel&m=157446316409937&w=2 > > Pankaj Gupta (2): > virtio-pmem: Async virtio-pmem flush > pmem: enable pmem_submit_bio for asynchronous flush > > drivers/nvdimm/nd_virtio.c | 74 +++++++++++++++++++++++++++--------- > drivers/nvdimm/pmem.c | 15 ++++++-- > drivers/nvdimm/region_devs.c | 4 +- > drivers/nvdimm/virtio_pmem.c | 10 +++++ > drivers/nvdimm/virtio_pmem.h | 16 ++++++++ > 5 files changed, 98 insertions(+), 21 deletions(-) > > -- > 2.25.1 >