Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp2411982pxb; Sun, 30 Jan 2022 15:41:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJxVCU95iJgNSj3ZDJgUGpztfPbKTXn7PbWHX50bmI4uyX3iQ/ys/qYFFYaYjWnLumKFIznA X-Received: by 2002:a17:906:5352:: with SMTP id j18mr15414342ejo.191.1643585997964; Sun, 30 Jan 2022 15:39:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643585997; cv=none; d=google.com; s=arc-20160816; b=N3B4rb3UDc0HyahfgfRXKCef/+X9k4ag3qYOvQr046hgoQo527AEWUeqqV4A0S4YK1 jPJ3t8bnvu65xKNqWpV1bJMFS4TvXLYAp2yAmM1gPd1A5sC5DwnGQEVK3T0fYDPamX8E CMVL85BBr2cHYCbhaECh+cqgX+7O9Vlm44jqXva/8pnprlnx9U9C/nZbk+HYxWK6VOqq VtepYehvFAXVFwXeaWOxh2EZI/awVCodd0bdoSu/+aEY+6qj7i5rMaZssMuAFLcXyFs5 3csHI4KlKmDJZZsC8CZEvYSe24v52/jrU/mXBBU/DmmUO5gv2Nu34C0NjPLSYE4Ct+8L O3yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=64ePvJZYZ4cwxg5EnUXMzmRNBcCOSpJpUMTnUtbyk/Y=; b=AqlfpOiejc6nOi1B0r99sxJtALF3fMR/Q36J5MlXtLWyDCaXgZYzjWspn1qmIj9hWB sHMZXK2ncVWMTBNYkZw0YfJZem7PfQ3CQynB5kXc1upaTAxrit+Ks7F4aYHuZh6YRFmN I8RtD9kphyzU5FGPCvbe8soeYzmJrtp5k5P+lHn+BzqSIyiP02FNy1fuGHDGZb0NSJPu BxkTt4STj1uzyi2FjM2+MA1Lve9M18WX4t+8UEQFiedM8glsHF8SzMOjCJLKlVP6VEcC LzzWQ7b8NwmwhqwRNXAyQNk/kpv1xrDEM5R9Kv/bwHgfGpkHCSWn4ChNqsEO7T0TFz0z OM0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=W6JtESqa; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=4Sz4stsp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f15si6339697ejl.448.2022.01.30.15.39.23; Sun, 30 Jan 2022 15:39:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=W6JtESqa; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=4Sz4stsp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347768AbiA1Kbk (ORCPT + 99 others); Fri, 28 Jan 2022 05:31:40 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:50174 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233599AbiA1Kbi (ORCPT ); Fri, 28 Jan 2022 05:31:38 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9705E210FF; Fri, 28 Jan 2022 10:31:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1643365897; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=64ePvJZYZ4cwxg5EnUXMzmRNBcCOSpJpUMTnUtbyk/Y=; b=W6JtESqawXB3XcyfJe4qKyopRtdCMXvrCA/zD/5QWjmNmZ/qXIhUXbisdg3JZmtFFvGZ3K spfIHHV2xbOVrcJzknGqa/qJ6o1rCS62EyrDepDzvBOLJ40w6xnaIB/npn54yUYAdUaa9r oIVE7uTuQAnvuLNTC+XFegMcABR+5zQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1643365897; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=64ePvJZYZ4cwxg5EnUXMzmRNBcCOSpJpUMTnUtbyk/Y=; b=4Sz4stspe4sZFG3qXzdQboeK2jshKdjenoMnqVQ8oynaFHKe3Tj1/KdhUHwkmdzqHSq/jV dHYoBg/zNCxJ55Bw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 88A9E13D17; Fri, 28 Jan 2022 10:31:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OuYsIQnG82HpHAAAMHmgww (envelope-from ); Fri, 28 Jan 2022 10:31:37 +0000 Date: Fri, 28 Jan 2022 11:31:37 +0100 From: Daniel Wagner To: Keith Busch Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC] nvme: Do not reject dynamic controller cntlid Message-ID: <20220128103137.zugnrh2bbhkqpaoz@carbon.lan> References: <20220127133648.8201-1-dwagner@suse.de> <20220127171758.GB2266713@dhcp-10-100-145-180.wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220127171758.GB2266713@dhcp-10-100-145-180.wdc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 27, 2022 at 09:17:58AM -0800, Keith Busch wrote: > > +static inline bool nvme_ctrl_dynamic(struct nvme_ctrl *ctrl) > > +{ > > + return ctrl->cntlid == 0xffff; > > +} > > It's probably safe to assume 0xffff is dynamic, but spec suggests we > check ID_CTRL.FCATT bit 0. Okay, but this one is only defined for fabrics. I haven't found anything so far which is equivalent to FCATT bit 0 for memory based transport.