Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] kselftest: Fix vdso_test_abi return status
To:     Shuah Khan <skhan@linuxfoundation.org>,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Shuah Khan <shuah@kernel.org>, Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Cristian Marussi <cristian.marussi@arm.com>
References: <20220126102723.23300-3-cristian.marussi@arm.com>
 <20220126122608.54061-1-vincenzo.frascino@arm.com>
 <5ea69341-73af-e741-7b5d-c161845583c9@linuxfoundation.org>
From:   Vincenzo Frascino <vincenzo.frascino@arm.com>
Message-ID: <3f0ed265-1eec-b12a-2fc2-6a558eb835c4@arm.com>
Date:   Fri, 28 Jan 2022 11:09:27 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <5ea69341-73af-e741-7b5d-c161845583c9@linuxfoundation.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Shuah,

On 1/27/22 11:18 PM, Shuah Khan wrote:
> 
> You can use the ksft_* counts interfaces for this instead of adding
> counts here. ksft_test_result_*() can be used to increment the right
> result counters and then print counts at the end.
> 
> Either if there is a failure in any of the tests it will be fail with
> clear indication on which tests failed. vdso_test_clock() test for
> example is reporting false positives by overriding the Skip return
> with a pass.
> 

Good point. I missed one condition in updating the test. I will post v2 that
will be compliant with the interface you mentioned.

Thanks.

> thanks,
> -- Shuah

-- 
Regards,
Vincenzo