Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: mlt+ZnP8ckhIWOaeLrGFW/Odsd3tOaWKHNdVIvg8nkhxCRuulw3czHgHcoSH3nT0v6LaB1WFTV
 kF+7BDp14pA1eklTkhN55iUe2Xz4yGS7Q6XW/uhoE6LCuqGZ6H60mGJeEt6RxQH8hwHQ2NaXEL
 YF1uFPmD4FhuGhDw+Qx4n3tpK4x4uo89Fh1pjsERDQedbtujKEWk8TcTqMHcSThjnIwh3xjNH4
 eKsg1auwlKNnC51Q38TZWFdTmgaEEE99dMn2WP5/HSmwgiZQBRzAimfXv2pQ1oS3/Nyv1W5Rq+
 fQRcQmbNYLD7HfGSWwjbUddc
IronPort-SDR: /vMZg9+8eKzCezEkATdrJ2gbGWjYhW/TUYhpSyDoBknyeLilsap32EM7NRUouSvzEz8QNBTPAu
 qkWJUX2hYPKVCsTgRGd+QrPhtIhLDMAvE1y9+peCceNIi3nQ4PDiPtjCer/CHqb3l6l8VYkKPf
 fZiPxAKNoCM2Su9ru9yHBR7zqHBfhFTTcpfnQ6qKz2hBz2q7heLVMtJoRMnf8UVC3HScsfc4G4
 fyu7odppTJbQf8Vs4Xb3RySIdN0SvC8mDatImVGIeMmJcc1YSw4ogpiiKP9MDYVuUAvBsVShBU
 K5U=
WDCIronportException: Internal
Message-ID: <3621c7db-0b73-d7eb-f987-45ec59a6c738@opensource.wdc.com>
Date:   Fri, 28 Jan 2022 20:50:04 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] ata: pata_platform: Fix a NULL pointer dereference in
 __pata_platform_probe()
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>,
        Zhou Qingyang <zhou1615@umn.edu>
Cc:     kjlu@umn.edu, Alexander Shiyan <shc_work@mail.ru>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Jens Axboe <axboe@kernel.dk>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220124164525.53068-1-zhou1615@umn.edu>
 <YfPBb4gHDkr76xPT@kroah.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <YfPBb4gHDkr76xPT@kroah.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/28/22 19:11, Greg KH wrote:
> On Tue, Jan 25, 2022 at 12:45:25AM +0800, Zhou Qingyang wrote:
>> In __pata_platform_probe(), devm_kzalloc() is assigned to ap->ops and
>> there is a dereference of it right after that, which could introduce a
>> NULL pointer dereference bug.
>>
>> Fix this by adding a NULL check of ap->ops.
>>
>> This bug was found by a static analyzer.
>>
>> Builds with 'make allyesconfig' show no new warnings,
>> and our static analyzer no longer warns about this code.
>>
>> Fixes: f3d5e4f18dba ("ata: pata_of_platform: Allow to use 16-bit wide data transfer")
>> Signed-off-by: Zhou Qingyang <zhou1615@umn.edu>
>> ---
> 
> As stated in the past, please do not make contributions to the Linux
> kernel until umn.edu has properly resolved its development issues.

Aouch. My apologies. I forgot about this. Thank you for the reminder.

> 
>> The analysis employs differential checking to identify inconsistent 
>> security operations (e.g., checks or kfrees) between two code paths 
>> and confirms that the inconsistent operations are not recovered in the
>> current function or the callers, so they constitute bugs. 
>>
>> Note that, as a bug found by static analysis, it can be a false
>> positive or hard to trigger. Multiple researchers have cross-reviewed
>> the bug.
>>
>>  drivers/ata/pata_platform.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/ata/pata_platform.c b/drivers/ata/pata_platform.c
>> index 028329428b75..021ef9cbcbc1 100644
>> --- a/drivers/ata/pata_platform.c
>> +++ b/drivers/ata/pata_platform.c
>> @@ -128,6 +128,8 @@ int __pata_platform_probe(struct device *dev, struct resource *io_res,
>>  	ap = host->ports[0];
>>  
>>  	ap->ops = devm_kzalloc(dev, sizeof(*ap->ops), GFP_KERNEL);
>> +	if (ap->ops)
>> +		return -ENOMEM;
> 
> This change seems to leak memory.  Damien, please revert it.

I fixed the patch when applying, so there is no leak. This is a genuine
(potential) bug fix. Must I revert ? Is the "no contribution from
umn.edu" an unbreakable rule ?

> 
> thanks,
> 
> greg k-h


-- 
Damien Le Moal
Western Digital Research