Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp2728434pxb; Mon, 31 Jan 2022 03:03:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJzANYG4mI9BQPNu1+X+LhwohivV5YZiWr1+BCCjJZ2QvgNS8wkatPhy9f0r1GHk0D30Ud/T X-Received: by 2002:a50:ef0c:: with SMTP id m12mr19447808eds.193.1643627037780; Mon, 31 Jan 2022 03:03:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643627037; cv=none; d=google.com; s=arc-20160816; b=m0T1ownSqvwXzQCLhsGbiSrjYjy+devGkGEz4DhL3uOCbXC0UhsVGGPv6tDmwDdACg mSeiFeI3qSfd0ZX+AbB4rt8MB00psMmi7W0wcDYNOQONi7WZvYgaV8lq72bUMf+Doomz neJKI2VBwoM3EN/WdwDwvjP7hmmNhBi4YaMT0trBQFdve118/Dk0KZN5SshFCZOMy4h0 g1pwm0PK9i+l7bqrDuELtfnB37CY4hcBp9bN/N/dPf2eGGyI2eL1gXWLR5hrPmFyJkR5 oo7i7nQ+f11saU5wqzy2GlZDhD0clHPS46vb1wfidU4Ev0rZ5Hl9E+juLKCMusNUXNsJ h/jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=5wmaElfHVmbB+yKUMSkxa4Ss33N1caR+PX/X3lWvEv0=; b=eRZRaXwsTdRjzjqbPAgRqjlyC8l4sfq5vyWRRRu/nb1Js73tgUVa7Jdg9x8RLgpFph q0+I2TxVCPV97xqmDofgwFnUVb0RHjyzg+8RMNaWOhU0ZIheWx/0tGzLO0v6+woFLINF IAqwXnxYdoyEPx931DAA3ZLsqeDkExqKjRudCL9AVw8whRxQ5nvlPZuhHa8SXy4ELBFO As2lgqsKR4PxxcbOT/7EpozGeT8q6F8MZCGLMMXYgjUlWkBOm2vPsnQnO9DSz0Vn0wzJ O+Y1sWs0hu8DhEb2IfDsOCHl/N2lPoNcGFucgEAPRubujx1wiBSOpAijfT5UZI5zueNY gniA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="VI/MwdwK"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ej8si8074259edb.125.2022.01.31.03.03.32; Mon, 31 Jan 2022 03:03:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="VI/MwdwK"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237168AbiA1NY3 (ORCPT + 99 others); Fri, 28 Jan 2022 08:24:29 -0500 Received: from mga06.intel.com ([134.134.136.31]:58913 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229625AbiA1NY2 (ORCPT ); Fri, 28 Jan 2022 08:24:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643376268; x=1674912268; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=dee8gZqixv/3uVG/nwblVNmvk6RueJi96F9bnNNOp0I=; b=VI/MwdwKH4Xx6gwiyWzuqhWj7xgTI4ZZ6PfVqzHOhM4bR1Lx6XO2F5Tv vBxcL24JExEZvfBI2OsbwrYdhGineD+nLVAFrcCLdeR64QWIx1Bf8usWm 1UpLpMg+TMDmAnhOzclVUWKv3/kEEKQL3bIu7oU3ylYqv7+vYr2ZrkBTW 58+tfNJ0MFRObEAH0vtVewBeSvd/AVrO4VdqavcCsH9WJhfUPLsTgzU5E 1tiePjxZoKpqzjtJ4fq/WoVWh0sS4bU38HsWpj+3opUkCWqfb/jnVXHbA lI3aIL/XisikDS6hgGmJGAbSz3LIpkg1ldMfZGWE9uxQcmmS5thPsPfzD w==; X-IronPort-AV: E=McAfee;i="6200,9189,10240"; a="307833878" X-IronPort-AV: E=Sophos;i="5.88,324,1635231600"; d="scan'208";a="307833878" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2022 05:24:28 -0800 X-IronPort-AV: E=Sophos;i="5.88,324,1635231600"; d="scan'208";a="625632618" Received: from smile.fi.intel.com ([10.237.72.61]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2022 05:24:24 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nDRDj-00FQOE-Os; Fri, 28 Jan 2022 15:23:19 +0200 Date: Fri, 28 Jan 2022 15:23:19 +0200 From: Andy Shevchenko To: Mattijs Korpershoek Cc: Dmitry Torokhov , Marco Felsch , Rob Herring , Matthias Brugger , Fengping Yu , Yingjoe Chen , Fabien Parent , Kevin Hilman , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v20 2/3] Input: mt6779-keypad - Add MediaTek keypad driver Message-ID: References: <20220127111526.3716689-1-mkorpershoek@baylibre.com> <20220127111526.3716689-3-mkorpershoek@baylibre.com> <87v8y4p483.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87v8y4p483.fsf@baylibre.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 28, 2022 at 11:03:08AM +0100, Mattijs Korpershoek wrote: > On Thu, Jan 27, 2022 at 17:20, Andy Shevchenko wrote: > > On Thu, Jan 27, 2022 at 12:15:25PM +0100, Mattijs Korpershoek wrote: ... > > Up to you. > Thank you for your review and your suggestions. Yes, as I said it you need a new version and consider them good. Thanks! -- With Best Regards, Andy Shevchenko