Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH v2 1/5] perf stat: Implement --topdown with metrics
To:     Andrew Kilroy <andrew.kilroy@arm.com>,
        <linux-kernel@vger.kernel.org>, <linux-perf-users@vger.kernel.org>,
        <acme@kernel.org>, <irogers@google.com>, <ak@linux.intel.com>
CC:     Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        "Namhyung Kim" <namhyung@kernel.org>
References: <4fefb1bc-49b2-bc5b-23cd-cd8fabe8c588@huawei.com>
 <20220111150749.13365-1-andrew.kilroy@arm.com>
 <20220111150749.13365-2-andrew.kilroy@arm.com>
From:   John Garry <john.garry@huawei.com>
Message-ID: <70433fdc-831e-8afa-68c3-6d75a4f8c75a@huawei.com>
Date:   Fri, 28 Jan 2022 13:44:08 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <20220111150749.13365-2-andrew.kilroy@arm.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/01/2022 15:07, Andrew Kilroy wrote:
>   }
> +
> +bool topdown_can_use_json_metrics(void)

nit: maybe topdown_can_use_metricgroups() could be better

> +{
> +#if defined(__aarch64__)
> +	return true;
> +#else
> +	return false;
> +#endif

it might be worth just having !x86, just that is prob too much forward 
looking

> +}
> +