Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 28 Jan 2022 17:09:22 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
        Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc:     ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org,
        linux-block@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] fs/ntfs3: remove unnecessary NULL check
Message-ID: <20220128140922.GA29766@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pc1++0H6fL6qQCwZL6hgrY8njhgS+D3vJwmdGjnGN56uXaFfAmJ5vnqj87iU?=
 =?us-ascii?Q?0tSoUAJz+G+M6BJWK641TGsJ+njF48Ib39FTBs6atjDalhHW8+hX48Cipm7W?=
 =?us-ascii?Q?V/sVGbpNQNE0xJuKiabSZfPbWP51VM6W+XLzZ3Bb8pJ+KYGfyKa6wTe7spaA?=
 =?us-ascii?Q?jGmzEHjL31eoMJCmKSoGyIyP7fD/gcOJlqS+lW052SG0TEo8Aovy6YS8Vh3w?=
 =?us-ascii?Q?CCub9OOqf1S+IMg/G3zhaVDWyenVxnyAXVdIe6dkEIe/+HH9RlnPIxjdZbSV?=
 =?us-ascii?Q?bEO8fmxRtca5Nnviq+2O+udimaB8BX5ZWytuVrtYeJoQNyy/ElCPumKd9U1U?=
 =?us-ascii?Q?mnQdrkHKnABxgA+zjClOdf6DglGc+w1C8D0GiQxdCWLr+O80RhIpG7JkkURE?=
 =?us-ascii?Q?kftmzWRMdMYqDGVkFr/lXn0+ofNj2Pp5bpDLq6diNWl7j+vrW/skxDOaMZiH?=
 =?us-ascii?Q?s8NiJwsN4f+eXmXLjf2yuUDM9VFotuROAZPzd7cqrHDwtwwfstgP+TxQMWU5?=
 =?us-ascii?Q?ssx1SIaeDLZKklTLX5K8Xcz065hmdw6kFltqB6EcDDiqshDatcr2YktSVsOM?=
 =?us-ascii?Q?KMaBc5NrbFmnXXJ576xfOiqI8Q3k2gom4eGyYKruAZ0csBgDRslQnw5jb7nQ?=
 =?us-ascii?Q?xqlhF2H5IkbUInbsCM1tAOvUsh+s9BXk4Sy4oWxcRhN/Pjc7OeY2ApNemgfF?=
 =?us-ascii?Q?VZnFsfdLoPpbgWVAZtHy6cZvKR1a39VFiqWjJa9wDfxFlq40GrA7anof6l8b?=
 =?us-ascii?Q?NzQeTbSYQUOdvOOdfFuWQtvjA63c3fuspYgeYZmnbZUUM/WjfggXWGZXI/NU?=
 =?us-ascii?Q?J4JpQm6t6gtVBI6PfsE1XKqPnkYx7aEu3sbebhp7nLiuLXTS5YhAOsSRRoVK?=
 =?us-ascii?Q?gqnK96RhiScfdgONhj1B/6A5B/QHnmzpNWtcnPVdeUZirEDd4O3jkb+tVNev?=
 =?us-ascii?Q?kAIzQ86a27OUbhIauXwsEVqi9ezBReirGDA6gU6D385K5vpzyrmJqloSEUAZ?=
 =?us-ascii?Q?R1pqGSxsUgR/KukWjFgIERt7qDK8wGksHt9TCXVoFLNtq7zJZ6vQt99+LtuU?=
 =?us-ascii?Q?FgfvigerDppZ95H7YlEbk4UeK3gIUZFyxXiOcj7QWUdijT+/cQSbr5BCv+G5?=
 =?us-ascii?Q?ojJ09/Xzfv5LRlvvTAmsDweOf8BBXh8tJH/ME4sJzpPE7XtKBdcVLSnz4bLF?=
 =?us-ascii?Q?6IrFa+X1KgcUtIiimJNSfB5B+tqqpss6E4Gq3pwP1JYanfAMMRRWUURoBI3a?=
 =?us-ascii?Q?xbKhpQcZiOxTh/XP9pIKPeEKdJNU8IfEdqrqC/lSWwbKiZJk1+/6SPUrHQAC?=
 =?us-ascii?Q?dcFZjPzDNMD5i7lC15kmvhhj8fLq8x3nnXcRv/QjE9x9UTLoQMIFIRSUfWHJ?=
 =?us-ascii?Q?OBFJ0AgxDbnu17YAGkDYqHQSQDKDxWFyU/y63Q0za5gVdqwHPSKpOWybeDB7?=
 =?us-ascii?Q?hM1tMC1pXdLyb0r/Nc2R2Q+LeT+1xd8AvsZkwL2Z5nTOCCHmgj9xHJXJsWCM?=
 =?us-ascii?Q?x69scZrsAIGnL5hBr7+tNZ4kYweWsTwId2xevGlnulYGdCKqxvk9fLcpmDts?=
 =?us-ascii?Q?oOVf5GerndNhC8r0r+jBlPfvSExw3y+WX9emwVZQnds5zpsPVTJi8tQpRKy8?=
 =?us-ascii?Q?/e33RDN3M7hCQ9xE+c5UhJD9tpa6naOwfy3togJK18BE32HVTM3/a6LfLZNl?=
 =?us-ascii?Q?PX8Bp2FzZ3H0oY4gJuIrot99MTA=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5229d1b7-ec50-48e7-6cd2-08d9e267d028
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2022 14:09:35.4423
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RIr0ts4FqZ55l9nOwdIqVUC+IcuR4QqzndvIqupEYBAHiOTbJ1R+o1FTWw+kQFA/bsYz9AlayzHadEREsTitkRAJ2CY2ugk0YJ9xWohHL/0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4939
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10240 signatures=669575
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 adultscore=0 spamscore=0 bulkscore=0 mlxscore=0 phishscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2201280090
X-Proofpoint-GUID: qEIZNgYB0XBy-yOdROpkqaCZRe0ZXI-o
X-Proofpoint-ORIG-GUID: qEIZNgYB0XBy-yOdROpkqaCZRe0ZXI-o
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This code triggers a Smatch warning:

    fs/ntfs3/fsntfs.c:1606 ntfs_bio_fill_1()
    warn: variable dereferenced before check 'bio' (see line 1591)

The "bio" pointer cannot be NULL so there is no need to check.
Originally there was more extensive NULL checking but it was removed
because bio_alloc() will never fail if it is allowed to sleep.

Remove this check as well.

Fixes: 087b2fb84908 ("ntfs3: remove ntfs_alloc_bio")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This patch applies on top of Christoph's bio allocation series and needs
through the block tree, I think.  I included a Fixes tag even though
it's not really a bugfix...

 fs/ntfs3/fsntfs.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/fs/ntfs3/fsntfs.c b/fs/ntfs3/fsntfs.c
index 0660a07c5a96..3de5700a9b83 100644
--- a/fs/ntfs3/fsntfs.c
+++ b/fs/ntfs3/fsntfs.c
@@ -1603,11 +1603,10 @@ int ntfs_bio_fill_1(struct ntfs_sb_info *sbi, const struct runs_tree *run)
 		}
 	} while (run_get_entry(run, ++run_idx, NULL, &lcn, &clen));
 
-	if (bio) {
-		if (!err)
-			err = submit_bio_wait(bio);
-		bio_put(bio);
-	}
+	if (!err)
+		err = submit_bio_wait(bio);
+	bio_put(bio);
+
 	blk_finish_plug(&plug);
 out:
 	unlock_page(fill);
-- 
2.20.1