Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 28 Jan 2022 16:45:14 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Gerhard Engleder <gerhard@engleder-embedded.com>
Cc:     linus.walleij@linaro.org, michal.simek@xilinx.com,
        linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "pinctrl: zynqmp: Unify pin naming"
Message-ID: <YfQBemA3bCz0FdYS@smile.fi.intel.com>
References: <20220127194602.21987-1-gerhard@engleder-embedded.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220127194602.21987-1-gerhard@engleder-embedded.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Jan 27, 2022 at 08:46:02PM +0100, Gerhard Engleder wrote:
> From: Gerhard Engleder <gerhard@engleder-embedded.com>

Thanks for your report, my comments below.

> This reverts commit 54784ff24971ed5bd3f1056edce998148709d0a7.
> 
> This patch changes the pin names from "MIO%d" to "MIO-%d", but all dts
> in arch/arm64/boot/dts/xilinx still use the old name. As a result my
> ZCU104 has no output on serial terminal and is not reachable over
> network.

And question here again, is the pin names ABI or not?
If it's an ABI, then it should be clarified in the documentation.
Otherwise, I'm wondering how this even may break anything.

-- 
With Best Regards,
Andy Shevchenko