Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CAHmME9pb9A4SN6TTjNvvxKqw1L3gXVOX7KKihfEH4AgKGNGZ2A@mail.gmail.com>
 <20220128153344.34211-1-Jason@zx2c4.com> <YfQPVp8TULSq3V+l@linutronix.de>
In-Reply-To: <YfQPVp8TULSq3V+l@linutronix.de>
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
Date:   Fri, 28 Jan 2022 16:54:06 +0100
Message-ID: <CAHmME9pmdeLBKJbTaVQv-z9J81qKA=R4uoZ1DeXABy6Lt3bXuA@mail.gmail.com>
Subject: Re: [PATCH] random: remove batched entropy locking
To:     Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc:     Andy Lutomirski <luto@amacapital.net>,
        =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        "Theodore Ts'o" <tytso@mit.edu>,
        LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
        Waiman Long <longman@redhat.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        Andy Lutomirski <luto@kernel.org>,
        stable <stable@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Sebastian,

On Fri, Jan 28, 2022 at 4:44 PM Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
> NO. Could we please look at my RANDOM patches first?
> I can repost my rebased patched if there no objection.

I did, and my reply is here:
https://lore.kernel.org/lkml/CAHmME9pzdXyD0oRYyCoVUSqqsA9h03-oR7kcNhJuPEcEMTJYgw@mail.gmail.com/

I was hoping for a series that addresses these issues. As I mentioned
before, I'm not super keen on deferring that processing in a
conditional case and having multiple entry ways into that same
functionality. I don't think that's worth it, especially if your
actual concern is just userspace calling RNDADDTOENTCNT too often
(which can be safely ratelimited). I don't think that thread needs to
spill over here, though, so feel free to follow up with a v+1 on that
series and I'll happily take a look. Alternatively, if you'd like to
approach this by providing a patch for Jonathan's issue, that makes
sense too. So far, the things in front of me are: 1) your patchset
from last month that has unresolved issues, and 2) Andy's thing, which
maybe will solve the problem (or it won't?). A third alternative from
you would be most welcome too.

Jason