Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <a72131dea70845bd7741d7e9f4d49671d538aa79.camel@linux.ibm.com>
Subject: Re: [PATCH v9 09/23] ima: Move some IMA policy and filesystem
 related variables into ima_namespace
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Stefan Berger <stefanb@linux.ibm.com>,
        Stefan Berger <stefanb@linux.vnet.ibm.com>,
        linux-integrity@vger.kernel.org
Cc:     serge@hallyn.com, christian.brauner@ubuntu.com,
        containers@lists.linux.dev, dmitry.kasatkin@gmail.com,
        ebiederm@xmission.com, krzysztof.struczynski@huawei.com,
        roberto.sassu@huawei.com, mpeters@redhat.com, lhinds@redhat.com,
        lsturman@redhat.com, puiterwi@redhat.com, jejb@linux.ibm.com,
        jamjoom@us.ibm.com, linux-kernel@vger.kernel.org,
        paul@paul-moore.com, rgb@redhat.com,
        linux-security-module@vger.kernel.org, jmorris@namei.org
Date:   Fri, 28 Jan 2022 11:03:38 -0500
In-Reply-To: <be31137d-57d9-24f7-01f6-f33080dd4bba@linux.ibm.com>
References: <20220125224645.79319-1-stefanb@linux.vnet.ibm.com>
         <20220125224645.79319-10-stefanb@linux.vnet.ibm.com>
         <1af8f2155730c38dcd510016fe82bc90e4acee39.camel@linux.ibm.com>
         <be31137d-57d9-24f7-01f6-f33080dd4bba@linux.ibm.com>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2022-01-28 at 10:44 -0500, Stefan Berger wrote:
> On 1/27/22 17:30, Mimi Zohar wrote:
> > On Tue, 2022-01-25 at 17:46 -0500, Stefan Berger wrote:
> >> From: Stefan Berger <stefanb@linux.ibm.com>
> >>
> >> Move the ima_write_mutex, ima_fs_flag, and valid_policy variables into
> >> ima_namespace. This way each IMA namespace can set those variables
> >> independently.
> > This patch description needs to be expanded a bit, indicating why
> > they're being moved together.  These flags are needed when loading a
> > policy. Please also update the "struct ima_namespace" comment.
> 
> I'll extend the above sentence like this:
> 
> ... those variables independently in its instance of securityfs.

That doesn't explain anything as to what these flags are or how they're
used.  Perhaps something like,  "Move the variables - ima_write_mutex,
ima_fs_flag, and valid_policy - related to updating the IMA policy into
the ima_namespace.  This way each IMA namespace can set these variables
independently."

Did you notice my comment inline below?

thanks,

Mimi