Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [tools headers UAPI] e2bcbd7769: kernel-selftests.ir.make_fail
To:     Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Sean Young <sean@mess.org>
Cc:     kernel test robot <oliver.sang@intel.com>,
        Alexei Starovoitov <ast@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        lkp@lists.01.org, kbuild test robot <lkp@intel.com>,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20220128075346.GG8421@xsang-OptiPlex-9020>
 <YfO39Q3mNHMQOkd4@gofer.mess.org>
 <CAADnVQJ3RCPUQ0k9nu2urrRK=U7SUetuPmY0_b17M_PD=j4fkw@mail.gmail.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <e5b72f09-a208-a579-3e51-10935ccee1ff@linuxfoundation.org>
Date:   Fri, 28 Jan 2022 10:27:52 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <CAADnVQJ3RCPUQ0k9nu2urrRK=U7SUetuPmY0_b17M_PD=j4fkw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 1/28/22 9:49 AM, Alexei Starovoitov wrote:
> On Fri, Jan 28, 2022 at 1:32 AM Sean Young <sean@mess.org> wrote:
>>

>>> ir_loopback.c: In function ‘main’:
>>> ir_loopback.c:147:20: error: ‘RC_PROTO_RCMM32’ undeclared (first use in this function); did you mean ‘RC_PROTO_RC6_MCE’?
>>>      if (rc_proto == RC_PROTO_RCMM32 &&
>>>                      ^~~~~~~~~~~~~~~
>>>                      RC_PROTO_RC6_MCE
>>
>> So this commit removes the copy of lirc.h from tools/include/uapi/linux/lirc.h,
>> so now the test uses /usr/include/linux/lirc.h. It appears that this file
>> does not have RC_PROTO_RCMM32 defined on this system, which means it is a
>> kernel header from v5.1 or earlier (this was added in commit
>> 721074b03411327e7bf41555d4cc7c18f49313f7).
>>
>> It looks like this machine is redhat 8.3, which ships with kernel 4.18.
>>
>> I guess my change was far too optimistic; I had no ideal enterprise kernels
>> were so ancient.
>>
>> We should probably drop e2bcbd7769ee8f05e1b3d10848aace98973844e4. Sorry about
>> the turbulence.
> 
> I'd rather avoid reverting.
> Just add ifdef or something to shut up the error on old distros.
> 

Sean,

Let's not add release checks.

Since RC_PROTO_RCMM32 is the only one missing, perhaps you could define
just that one in ir_loopback.c with a comment that it can be removed.

ifndef RC_PROTO_RCMM32 ---

thanks,
-- Shuah