Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 28 Jan 2022 22:00:59 +0100
From:   Mauro Carvalho Chehab <mchehab@kernel.org>
To:     Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= <j.neuschaefer@gmx.net>
Cc:     linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH] scripts/get_abi.pl: Ignore hidden files
Message-ID: <20220128220007.085021a8@coco.lan>
In-Reply-To: <YfRWAP2OoW4t8juH@latitude>
References: <20220128201354.1928412-1-j.neuschaefer@gmx.net>
        <YfRWAP2OoW4t8juH@latitude>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Em Fri, 28 Jan 2022 21:45:52 +0100
Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net> escreveu:

> On Fri, Jan 28, 2022 at 09:13:53PM +0100, Jonathan Neusch=C3=A4fer wrote:
> > get_abi.pl currently collects every file in Documentation/ABI. This
> > causes a UnicodeDecodeError in Documentation/sphinx/kernel_api.py, =20
>=20
> Ooops, this should be kernel_abi.py.
>=20

After addressing your comment about the kernel_abi.py file, feel free
to add:

Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>

>=20
> > when it finds my Vim swap files (.foo.swp) in the directory.
> >=20
> > To avoid such issues, ignore hidden files in get_api.pl. =20
>=20
> ... and get_abi.pl.
>=20
>=20
> >=20
> > Signed-off-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>
> > ---
> >  scripts/get_abi.pl | 1 +
> >  1 file changed, 1 insertion(+)
> >=20
> > diff --git a/scripts/get_abi.pl b/scripts/get_abi.pl
> > index 6212f58b69c61..47b7eca5b0b71 100755
> > --- a/scripts/get_abi.pl
> > +++ b/scripts/get_abi.pl
> > @@ -92,6 +92,7 @@ sub parse_abi {
> >  	my $mode =3D (stat($file))[2];
> >  	return if ($mode & S_IFDIR);
> >  	return if ($file =3D~ m,/README,);
> > +	return if ($file =3D~ m,/\.,);
> >=20
> >  	my $name =3D $file;
> >  	$name =3D~ s,.*/,,;
> > --
> > 2.34.1

Thanks,
Mauro