Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 28 Jan 2022 13:32:34 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Horatiu Vultur <horatiu.vultur@microchip.com>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen.Hegelund@microchip.com,
        Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] pinctrl: microchip-sgpio: Fix support for regmap
Message-ID: <20220128213234.GA1638668@euler>
References: <20220125161245.418882-1-horatiu.vultur@microchip.com>
 <20220125164659.GA31440@COLIN-DESKTOP1.localdomain>
 <CAHp75Vc71mnKST5aFGEivoU8ZhmmRf-ArNYVMb5Cf52jE8jetQ@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75Vc71mnKST5aFGEivoU8ZhmmRf-ArNYVMb5Cf52jE8jetQ@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PDpVP3sirj5JvKlbAbfvoA0xxdg4oTJyMbpx3jvwVlDAfyTUAkaCFwhThMCi?=
 =?us-ascii?Q?ep9ubSEq5KtUzdDRZa/0E8rws7r2vcdJ7APUcccUQIDoPrZeTu9AY/19zg3B?=
 =?us-ascii?Q?VDoVtcQVNX2t1IQj+qKjKapgcZSiqmTrI7z28ZZQaeU4q3yOHKhwOc/C2xGZ?=
 =?us-ascii?Q?nfXELR3RRt4cZ4q8TAQAtsYQVzMsj37cbyecvKdZsKNU3zjTT6hxmfc8bZ2F?=
 =?us-ascii?Q?2Ar2JhsRpbqfunfU22f9v4EeEPRajEB5AvFS4t/USRWJiu6xj9oQyQpyO3wF?=
 =?us-ascii?Q?7hFaSk2+oSqHTwSReeOtDnTJAp5Kk1ckvECciScsg7Rr3EjjEtgDa5YaP7Oi?=
 =?us-ascii?Q?btKIGv33qeQKNaRGxIrhRbsmAG2R/RSnymFr/4Z6Ci48TSdyQ4KT4wprQRbO?=
 =?us-ascii?Q?uIgELjNDEKTUuefQJ28HaUEr56Sl51HgMfGQTiAMBrczA3xSxpTLGQRxYj8V?=
 =?us-ascii?Q?LZYF1aeTSccCmQeGH9QtgARLzKaW5g4j5zqTZEJWOJpNWPqMNVKOmf35QJFI?=
 =?us-ascii?Q?CGZvpXgPKtAP5esdWSoPfgTxuB+UOpuFl96dNrnOOjCUkKAuZEg5ugkVV+Tx?=
 =?us-ascii?Q?RByEskNSLx9bqbQID24XECJwIAFKHJcrZpyWWUSU+9xZkN3GpEC5+ONCWVch?=
 =?us-ascii?Q?NLzhZNvXJ5T4FHV6JC1r/Ah5MQl1fUQiosBr/xYfpFXh8aVw0VZFyDeZipfM?=
 =?us-ascii?Q?kcUYkUAtOnzrozkdPZokn+EZrr3NHiyTDmucqxhb7vhSD87E4/Ug26neAFSR?=
 =?us-ascii?Q?5sfU6B1hBynEfjvZWamPlimm1skuyYfKhhR+i+VjP3O1z4yokqEGIHtg6ZNV?=
 =?us-ascii?Q?8QvAy58JFc5BdSOMpbRjI777DEx4b4/Wq+m4tn1tDM9yrbeK5yQnSg79snk8?=
 =?us-ascii?Q?iE26D/kwtJzPrUB5vMtC7vmR+vk9nEYP7vKO9dAXxBK7EkoOcEHpcJvJyFe1?=
 =?us-ascii?Q?Jhq+pfNsfErUfwo46u2g6jyHt+fKKErdnLm3oD2OnnboPjNH8bnvK7TuPlOx?=
 =?us-ascii?Q?9hv889sB/BRmbEG+EwBC43mTPA0WmEewbdw2UxpZAxFa1sKQ/sDJiNXpA+vw?=
 =?us-ascii?Q?fMFVYmfQ9FrH4rOQt1/BM95FssxEnIPpfRogF2aH4655QRnxTsppIGK7LmyF?=
 =?us-ascii?Q?1CbuKNXM80p7qSMOLEWulk9Dv9Yrkeq0uTxpjIMSsbW9LjGl6TTjASQoerPz?=
 =?us-ascii?Q?/bDH+lbe5SK53wL4MckC6/FDVgyRUo10ue7S3C6eOIHULcdP0U6l/rzVetBM?=
 =?us-ascii?Q?mq956vqClMa8yQOwy24y/lvpW+LnCOycmKAJ9kSYjxPSbcQu9+5FOdTUatFH?=
 =?us-ascii?Q?/S01p38yNLHZXOylYfYs6U+GP78ZCS9fZ7nOMzAUX3xokOT1uwCuUXH2NmN1?=
 =?us-ascii?Q?+Lnyepl2AKnWl/oo9USfsa0XYj/84YB3jWE6H+T1nQYtUBG9IeHNcYXN+mtw?=
 =?us-ascii?Q?JNuTWDf44SDK3MdqmgrFhRkrI4dPZrO8YNisPmQUpOxlDfzCXhBGPGX9V+wc?=
 =?us-ascii?Q?07s1vbF9svVK1Gyue2YyDG7hMIuwZj68FVuA1eFsUh/oe1IYqxlx/tEpmXYw?=
 =?us-ascii?Q?NPEyZ4aA7irW8oy0rv34UOO6FFWsnOOvzr56w9u0Gk+hmOqze7VzmtCAr+JF?=
 =?us-ascii?Q?POnToXc/Zg/fbeBXa5OiJz36kBpuddppmpHQesIEhjgzRJG5UkcUeajR32Hj?=
 =?us-ascii?Q?aueWYQ=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ff0cb88-1ef0-4db8-2e90-08d9e2a5b616
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2022 21:32:40.5461
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q7IL3mXVmZh4HG14avh+9kYvNPvoP/t7NN5e7aZ56YPkePW5Gy+ky4NrPDh0yQEeA7p0x+gWN9UYckkiYKOWMr0QOwktWNhxGtfsDqW3Q+0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1001MB2204
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 28, 2022 at 04:19:12PM +0200, Andy Shevchenko wrote:
> On Wed, Jan 26, 2022 at 3:19 AM Colin Foster
> <colin.foster@in-advantage.com> wrote:
> > On Tue, Jan 25, 2022 at 05:12:45PM +0100, Horatiu Vultur wrote:
> 
> > The only difference is I
> > had copied reg_stride into sgpio_priv instead of making regmap_config
> > file-scope.
> 
> I'm wondering if we may access config via a pointer to regmap.

Ooh... regmap_get_reg_stride() exists. I didn't see that before. That
seems like it is the answer.

I don't know the etiquette here. Ask Horatiu to re-submit, or me send
along a v2, or something else.

> 
> -- 
> With Best Regards,
> Andy Shevchenko