Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <52c7f9e7effb6bd09d35b95bdca056a3e0907667.camel@kernel.org>
Subject: Re: [PATCH v2 0/2] tracing: Misc bugfixes
From:   Tom Zanussi <zanussi@kernel.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     mhiramat@kernel.org, linux-kernel@vger.kernel.org
Date:   Fri, 28 Jan 2022 15:50:45 -0600
In-Reply-To: <20220128164219.1a5189cd@gandalf.local.home>
References: <cover.1643399022.git.zanussi@kernel.org>
         <20220128164219.1a5189cd@gandalf.local.home>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2022-01-28 at 16:42 -0500, Steven Rostedt wrote:
> On Fri, 28 Jan 2022 14:08:25 -0600
> Tom Zanussi <zanussi@kernel.org> wrote:
> 
> > There were 2 patches in v1 that were flagged by the 0day robot for
> > strncpy off-by-1 warnings:
> > 
> >   tracing: Remove size restriction on hist trigger cmd error
> > logging
> >   tracing: Remove size restriction on synthetic event cmd error
> > logging
> > 
> >   warning: 'strncpy' output truncated before terminating nul
> > copying
> >   as many bytes from a string as its length [-Wstringop-truncation]
> > 
> > This v2 patchset consists of just those two patches with the fix
> > for
> > those warnings.
> 
> 
> So this just replaces the last two patches you sent previously?
> 

Yes.

> Probably would have been better to send all three (since the other 4
> already made it into mainline).
> 

OK, yeah, thought about doing that but guessed wrong, as usual ;-)

> But if "tracing: Remove size restriction on tracing_log_err cmd
> strings" is
> OK:
> 
>    

Yeah, that one is ok as-is without changes.

Tom

> 
https://lkml.kernel.org/r/ca965f23256b350ebd94b3dc1a319f28e8267f5f.1643319703.git.zanussi@kernel.org
> 
> then I'll just replace the other two.
> 
> -- Steve