Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RESEND PATCH net-next 2/2] net: hns3: add ethtool priv-flag for
 TX push
To:     Jakub Kicinski <kuba@kernel.org>
CC:     <davem@davemloft.net>, <wangjie125@huawei.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <lipeng321@huawei.com>, <chenhao288@hisilicon.com>
References: <20220125072149.56604-1-huangguangbin2@huawei.com>
 <20220125072149.56604-3-huangguangbin2@huawei.com>
 <20220125195508.585b0c40@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
From:   "huangguangbin (A)" <huangguangbin2@huawei.com>
Message-ID: <2b7029d4-c1a7-93af-1846-7b91703f9edf@huawei.com>
Date:   Sat, 29 Jan 2022 09:14:15 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20220125195508.585b0c40@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022/1/26 11:55, Jakub Kicinski wrote:
> On Tue, 25 Jan 2022 15:21:49 +0800 Guangbin Huang wrote:
>> From: Yufeng Mo <moyufeng@huawei.com>
>>
>> Add a control private flag in ethtool for enable/disable
>> TX push feature.
> 
> I think it's a pretty standard feature for NICs which also support RDMA.
> Mellanox/nVidia has it (or at least it the previous gen HW did),
> Broadcom's bnxt driver does it as well.
> 
> Can we make this a standard knob via ethtool? Not entirely sure under
> which switch, maybe it's okay to add it under -g? Perhaps we need a new
> command similar to -k but for features contained entirely to the driver?
> .
> 
Hi Jakub,
We consider adding a new command for this feature. We will send RFC after we finish it.