Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220127221710.165733-1-dlatypov@google.com>
In-Reply-To: <20220127221710.165733-1-dlatypov@google.com>
From:   David Gow <davidgow@google.com>
Date:   Sat, 29 Jan 2022 12:15:01 +0800
Message-ID: <CABVgOSncO56y02RkUMeBU2rpqxXgDudL24gG0UUqzhX58JqjJg@mail.gmail.com>
Subject: Re: [PATCH] kunit: fix missing f in f-string in run_checks.py
To:     Daniel Latypov <dlatypov@google.com>
Cc:     brendanhiggins@google.com, linux-kernel@vger.kernel.org,
        kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
        skhan@linuxfoundation.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jan 28, 2022 at 6:17 AM Daniel Latypov <dlatypov@google.com> wrote:
>
> We're missing the `f` prefix to have python do string interpolation, so
> we'd never end up printing what the actual "unexpected" error is.
>
> Fixes: ee92ed38364e ("kunit: add run_checks.py script to validate kunit changes")
> Signed-off-by: Daniel Latypov <dlatypov@google.com>
> ---

Looks good!

Reviewed-by: David Gow <davidgow@google.com>

Cheers,
-- David

>  tools/testing/kunit/run_checks.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/kunit/run_checks.py b/tools/testing/kunit/run_checks.py
> index 4f32133ed77c..13d854afca9d 100755
> --- a/tools/testing/kunit/run_checks.py
> +++ b/tools/testing/kunit/run_checks.py
> @@ -61,7 +61,7 @@ def main(argv: Sequence[str]) -> None:
>                 elif isinstance(ex, subprocess.CalledProcessError):
>                         print(f'{name}: FAILED')
>                 else:
> -                       print('{name}: unexpected exception: {ex}')
> +                       print(f'{name}: unexpected exception: {ex}')
>                         continue
>
>                 output = ex.output
>
> base-commit: 6125a5c70acddd9fc1fb7329047a254c74d0173c
> --
> 2.35.0.rc2.247.g8bbb082509-goog
>