Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Bhandare, KiranX" <kiranx.bhandare@intel.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
CC:     Song Liu <songliubraving@fb.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Yonghong Song <yhs@fb.com>, Martin KaFai Lau <kafai@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        "Andrii Nakryiko" <andrii@kernel.org>,
        =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "Jakub Kicinski" <kuba@kernel.org>, KP Singh <kpsingh@kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH v4 net-next 1/9] i40e: don't reserve
 excessive XDP_PACKET_HEADROOM on XSK Rx to skb
Thread-Topic: [Intel-wired-lan] [PATCH v4 net-next 1/9] i40e: don't reserve
 excessive XDP_PACKET_HEADROOM on XSK Rx to skb
Thread-Index: AQHX7D0G03SWSKhTQE2oI21ri4lIHqx6AwZw
Date:   Sat, 29 Jan 2022 08:55:15 +0000
Message-ID: <DM6PR11MB329239287A3AC0FFC21A3DEEF1239@DM6PR11MB3292.namprd11.prod.outlook.com>
References: <20211208140702.642741-1-alexandr.lobakin@intel.com>
 <20211208140702.642741-2-alexandr.lobakin@intel.com>
In-Reply-To: <20211208140702.642741-2-alexandr.lobakin@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?uoOXnXA+DoohKdisGUuenUHDfEf/s4zcYoOaw8OWztxr8/ZPjk35BAVT4G?=
 =?iso-8859-1?Q?EjaOrb6uAegoYxkE57BE51hTkZLoUDIhbuwqP5uo71kuvGFLRbiw+2c6Tt?=
 =?iso-8859-1?Q?ptPbwMW7c2oCLUFaFk/6quAE2rYXlEH/pcsiBehfAaSM9Ic6V9vHZScG2V?=
 =?iso-8859-1?Q?sHoJCOSnVkVfHilnnSChWxAeXbzcDqqla42bFu9Se+TbIDbaMlYhResc8C?=
 =?iso-8859-1?Q?eeXyCGjwx1ORQUHjj4lP7jBc38PX9IoQBQ+Wpy08qYSoY1nNl3ep+lHvUy?=
 =?iso-8859-1?Q?HaPLqKRwTiYAsqxOu+W8ZluaM6J2hxxDXP6kXY7KRUOTzTxGhnxMmpyWE7?=
 =?iso-8859-1?Q?14Hlen+tGU3KgFQH380vyj0qnYJ+8DQMYga92zv17cQBLbcEh5lCCsxvIQ?=
 =?iso-8859-1?Q?Y6IlPkiZwaBq17H/YGEUztbJQLAyh3zzF/1iiIt4JHbLON84N42Ufk5cju?=
 =?iso-8859-1?Q?ThVJ+Q2pGti1E/RTtaMMya97MhzDIosJ785iid8yzhSx3s5nPUrmj5ukRB?=
 =?iso-8859-1?Q?u/PU2pY+/wKhZgXR2RC2GpUEOQzojMISjrFtmCSOBsNFh63IGtBsfadNn6?=
 =?iso-8859-1?Q?arZTidZ02J6JA4oos1eWBCBNNwA8oNdGIFjCJGEtC9ywcntpznZHjEmPmJ?=
 =?iso-8859-1?Q?2sENhIKo8yyMKn/knBT+l9Re3x2BkBaX5ayprQ6WD/4GoLKuyMY057Kq1m?=
 =?iso-8859-1?Q?81eCL5h80qwvpjfnWiBIeAzuKHBExwVf9FWqY0XHrStRApPsdJywVbbABg?=
 =?iso-8859-1?Q?AWDNdWBX2Wf7EqUmxjGWFEKxXNr/XubEBdAzhKg3WnF1Suf9GW4LLD3abT?=
 =?iso-8859-1?Q?kwwwirWrY8xil80KlwuXWhqlaKrDGe96+G1TcEOyLzlBQw8nzUriqk0nQW?=
 =?iso-8859-1?Q?Pw0GE9rux1AGZ8nWdp+Lnwjcs3u1sLf8U1dNLvHIQnUBZ9mjwvMf+XkM1w?=
 =?iso-8859-1?Q?d0d9VKt4qqMEMiflpGpHKAnCfObGjtUD33ANajpF1qh2U5HVa5OFsE2G/N?=
 =?iso-8859-1?Q?1IhVXBdTxr8e71jzHOxR6SlXhiXoG120/aR4E4I7744FCc/zg1Hd3RRmbg?=
 =?iso-8859-1?Q?X5SLKsJ4fdquN9zaxcBRGjvWP6uKkqXM+fqM1Z5E2KPy3gD15PAxxhFdxV?=
 =?iso-8859-1?Q?+TmgVbHW//wdB/NinYZ8Cb+djJgBcz6ACkJw3j3jgxW6BpZ6l3sFtxERgf?=
 =?iso-8859-1?Q?Mb7Oyrs7OTAjzJeuc+g/+0IRLd0HAYdSLE/UiMw9KwSXYA8KSp90treq+Z?=
 =?iso-8859-1?Q?K15qpI7lv6EkCe+gNGyzg4viOQgTmuw6ZldylE1hlXhe37IORIBymJj6+a?=
 =?iso-8859-1?Q?7ZRZbZRLcjIbax12k2ukAl27a5egoP+UQHPgbot3bUn+GSr4UBf0I05PZh?=
 =?iso-8859-1?Q?8L6WL8QGXGCSJApvxCYSZ1jmZeXWmp4YXxbHUVfOB25hRUI/x0ePz85Yg8?=
 =?iso-8859-1?Q?TW+dn6VoWFxMB/cu6JFM22kZO11sogSxBR/UnMPToJX9J2zjhuGiKG+qKr?=
 =?iso-8859-1?Q?FE4m0A6Gu+Iy8LDrqFlgX7vzmq2zaJYwHzMjGK+ndrDtRFqBWDJ1HskjSM?=
 =?iso-8859-1?Q?gutNym414LSDqbMazV45/8AoHNYRJ927/nBQWfsf3Fq4Di8FWMbN9VZoT4?=
 =?iso-8859-1?Q?Ew8I9i4Mmbk87NHi/hELwB8nz8LBfTDh6gejHm5dQDS5zy2CnN1MFmcKci?=
 =?iso-8859-1?Q?ZwOrw8ZzBNJk1F730X41fbK5f02F4TzgyqydJ9KFJJwvcrnGKF6gAiBy1k?=
 =?iso-8859-1?Q?0wzg=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3292.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb930a7f-efa4-4960-1e4c-08d9e305111b
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2022 08:55:15.0498
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cwuD3R1jXnArK1T4l3EVoJmR0mEp91Ai1SWU6a8MDXsAIiXCsEoUXEHswjVmxFjIj4Cyz+VTb9Qvw7mWQarvq+kw4JC9zCEaF6Jj9r6qcJo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1868
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Alexander Lobakin
> Sent: Wednesday, December 8, 2021 7:37 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Song Liu <songliubraving@fb.com>; Jesper Dangaard Brouer
> <hawk@kernel.org>; Daniel Borkmann <daniel@iogearbox.net>; Yonghong
> Song <yhs@fb.com>; Martin KaFai Lau <kafai@fb.com>; John Fastabend
> <john.fastabend@gmail.com>; Alexei Starovoitov <ast@kernel.org>; Andrii
> Nakryiko <andrii@kernel.org>; Bj=F6rn T=F6pel <bjorn@kernel.org>;
> netdev@vger.kernel.org; Jakub Kicinski <kuba@kernel.org>; KP Singh
> <kpsingh@kernel.org>; bpf@vger.kernel.org; David S. Miller
> <davem@davemloft.net>; linux-kernel@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH v4 net-next 1/9] i40e: don't reserve
> excessive XDP_PACKET_HEADROOM on XSK Rx to skb
>=20
> {__,}napi_alloc_skb() allocates and reserves additional NET_SKB_PAD
> + NET_IP_ALIGN for any skb.
> OTOH, i40e_construct_skb_zc() currently allocates and reserves additional
> `xdp->data - xdp->data_hard_start`, which is XDP_PACKET_HEADROOM for
> XSK frames.
> There's no need for that at all as the frame is post-XDP and will go only=
 to the
> networking stack core.
> Pass the size of the actual data only to __napi_alloc_skb() and don't res=
erve
> anything. This will give enough headroom for stack processing.
>=20
> Fixes: 0a714186d3c0 ("i40e: add AF_XDP zero-copy Rx support")
> Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20

Tested-by: Kiran Bhandare <kiranx.bhandare@intel.com>  A Contingent Worker =
at Intel