Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 29 Jan 2022 08:55:22 +0000
From:   Hyeonggon Yoo <42.hyeyoo@gmail.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     jwiedmann.dev@gmail.com, Shay Agroskin <shayagr@amazon.com>,
        Arthur Kiyanovski <akiyano@amazon.com>,
        David Arinzon <darinzon@amazon.com>,
        Noam Dagan <ndagan@amazon.com>,
        Saeed Bishara <saeedb@amazon.com>,
        "David S . Miller" <davem@davemloft.net>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Sameeh Jubran <sameehj@amazon.com>,
        Wei Yongjun <weiyongjun1@huawei.com>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: ena: Do not waste napi skb cache
Message-ID: <YfUA+vdxF/S+0/SB@ip-172-31-19-208.ap-northeast-1.compute.internal>
References: <20220123115623.94843-1-42.hyeyoo@gmail.com>
 <YfFJuQQBLJRxIJR+@ip-172-31-19-208.ap-northeast-1.compute.internal>
 <20220126075220.3d60981f@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220126075220.3d60981f@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Precedence: bulk

On Wed, Jan 26, 2022 at 07:52:20AM -0800, Jakub Kicinski wrote:
> On Wed, 26 Jan 2022 13:16:41 +0000 Hyeonggon Yoo wrote:
> > By profiling, discovered that ena device driver allocates skb by
> > build_skb() and frees by napi_skb_cache_put(). Because the driver
> > does not use napi skb cache in allocation path, napi skb cache is
> > periodically filled and flushed. This is waste of napi skb cache.
> > 
> > As ena_alloc_skb() is called only in napi, Use napi_build_skb()
> > and napi_alloc_skb() when allocating skb.
> > 
> > This patch was tested on aws a1.metal instance.
> > 
> > [ jwiedmann.dev@gmail.com: Use napi_alloc_skb() instead of
> >   netdev_alloc_skb_ip_align() to keep things consistent. ]
> > 
> > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
> 
> It seems you missed CCing netdev@, you'll need to repost.
> You can keep the ack from Shay.

Oh my mistake. I did it. Thanks!

Hyeonggon