Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 29 Jan 2022 08:56:27 +0000
From:   Hyeonggon Yoo <42.hyeyoo@gmail.com>
To:     Julian Wiedmann <jwiedmann.dev@gmail.com>
Cc:     Shay Agroskin <shayagr@amazon.com>, netdev@vger.kernel.org,
        Arthur Kiyanovski <akiyano@amazon.com>,
        David Arinzon <darinzon@amazon.com>,
        Noam Dagan <ndagan@amazon.com>,
        Saeed Bishara <saeedb@amazon.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Wei Yongjun <weiyongjun1@huawei.com>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ena: Do not waste napi skb cache
Message-ID: <YfUBO2pTUVoHSTim@ip-172-31-19-208.ap-northeast-1.compute.internal>
References: <20220123115623.94843-1-42.hyeyoo@gmail.com>
 <f835cbb3-a028-1daf-c038-516dd47ce47c@gmail.com>
 <5cca8bdd-bed0-f26a-6c96-d18947d3a50b@gmail.com>
 <pj41zlmtjk7t9a.fsf@u570694869fb251.ant.amazon.com>
 <Ye/EQgqCBogZR87T@ip-172-31-19-208.ap-northeast-1.compute.internal>
 <bad34ba9-eacf-f325-7ebc-6fdd43414945@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bad34ba9-eacf-f325-7ebc-6fdd43414945@gmail.com>
Precedence: bulk

On Tue, Jan 25, 2022 at 03:50:30PM +0200, Julian Wiedmann wrote:
> On 25.01.22 11:34, Hyeonggon Yoo wrote:
> > On Mon, Jan 24, 2022 at 10:50:05PM +0200, Shay Agroskin wrote:
> >>
> 
> [...]
> 
> >>
> >> I agree that the netdev_alloc_skb_ip_align() can become napi_alloc_skb().
> >> Hyeonggon Yoo, can you please apply this change as well to this patch?
> >>
> > 
> > Okay. I'll update and test it again.
> > 
> > BTW, It seems netdev_alloc_skb_ip_align() is used to make some fields
> > be aligned. It's okay to just ignore this?
> > 
> 
> napi_alloc_skb() adds NET_IP_ALIGN internally, so you end up with the same alignment as before.
> 

Oh I was missing that. I updated the patch and tested again.
Thank you!

> 
> > Thanks,
> > Hyeonggon.
> > 
> >> Thanks,
> >> Shay
> >>
> >>
> >>>>>  	else
> >>>>> -		skb = build_skb(first_frag, ENA_PAGE_SIZE);
> >>>>> +		skb = napi_build_skb(first_frag, ENA_PAGE_SIZE);
> >>>>>  	if (unlikely(!skb)) {
> >>>>>  		ena_increase_stat(&rx_ring->rx_stats.skb_alloc_fail,  1,
> >>>>
>