Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp141468pxb; Mon, 31 Jan 2022 17:37:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJwyWCuOKzl14d3ao4cmOXCSN7CmbeNigQdEQ5RF5R2o91+gunRNS932IaKlnMjl9/6q+JhD X-Received: by 2002:a17:903:2291:: with SMTP id b17mr23024107plh.83.1643679453814; Mon, 31 Jan 2022 17:37:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643679453; cv=none; d=google.com; s=arc-20160816; b=AVZO8VzAu6Zt/7O6NieR1K/IZwSNO0SX2X+Cr6AL0Ttc92f0yuhOK3BONAfi+ua9Ts 7P8qYW6Sum/HcU7EMQZk0FUspPcd8hhNjQsKA26jRdXAsdqY19/vRzhaqZuGJvSJDDdf O0MQSTfMXpzZ2Em5XF9qE2BKFiSp/eYMytm8cTqWtvdFIC3NDNCLZo4sF42OsUtcyUnm tY8iRZYJmViPZy/dmg/vnxPyB4TNjQRU7JFcNM74AzkW/JiB5eyytSJkShf3peP46ak8 fcH/p8PIQbQl9dJ3fbIxR9dtCCF7BcIkiqChCCwEWO1l8uLLfUH/OBFUPk4mkgwO9Xuy vS3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=eNsBUeSPBs0Qx4jcu0B26Fmmisvc82tqbPd5SR7juWw=; b=Czhy2jQnBICbJ4VEnl3SVsBrvRsaTZrHXesmsdMudMlnNTnEa/CtrTqizRMXOPn9zF h9FwD1FulbwbfiQeowq4wyCspdjMU9bel16wb7LSYP8oG7V3G7y5O3Bic4LYIEZAOLOu UYjKbMD+lTSK7I4XOG6ySu8x8joeglLHpRiGjHUqg+heMWD152CLU2wgnIEJHs6VN70l vpK1EjwLuOv3uuik+zJD6FikVaoJlKbfeHZpaSuZrYC5svxSTkqFOdkzVsfoPyJQNiED U65h45wsMhkP+A7ziu9SgmpFMeVWaLLPxmJgGLAo/vovGSwEqdmbrbI3Y/Te9zh6li3E P63g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=PO6ZuNzq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i190si14061577pfc.293.2022.01.31.17.37.22; Mon, 31 Jan 2022 17:37:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=PO6ZuNzq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233576AbiA2KUN (ORCPT + 99 others); Sat, 29 Jan 2022 05:20:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229987AbiA2KUM (ORCPT ); Sat, 29 Jan 2022 05:20:12 -0500 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56BF4C061714 for ; Sat, 29 Jan 2022 02:20:12 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id o64so8910785pjo.2 for ; Sat, 29 Jan 2022 02:20:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eNsBUeSPBs0Qx4jcu0B26Fmmisvc82tqbPd5SR7juWw=; b=PO6ZuNzqPth2Ll5QiIIVzIuXypGKRintUdfijuI4Q3ax8D0X9bnCQa+lRPa8PJJVzz Nrnot9GwYozCGu+i+AakNEHNI0U6nYXjdc1lmKDVfiH2KaDhIm0fRrXVhP3VjBJ0fLh2 qScsbySfuLmCg4Htow+98kU4NCNM7qtbU2LkjhJbhtEM5xBt4g9tYGnIsZB/cl1Yhy2h 0YKyoeKHxb9iWDPdoCjCWO/SWAu9IlZAzu1s/IRM0WmKe2Tn9wTkLGmwBkUfgVKXnmKb 8kv2GJVroz/TZYyNVRoUmFh2VFe4jH/GpPr09gdelU29raOHfmBQlq5s1vF6tF8sv1tq JTJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eNsBUeSPBs0Qx4jcu0B26Fmmisvc82tqbPd5SR7juWw=; b=ArPGlM8MMlTmjGhq080ciBA8VfnFPcMPDjgQvKIpWrX0i1BVuEw4yUL4ZbE6Oph3mM jSaJ8YvAJtGHE/GNkauzaLnwk6ScH7ztzK9s3pTnd0uhHMQDWwtFP0yCqvyoJOnhg77C LHWgPGgVignYTpDKqA9VGcK1hmzaf5wOUs6lHj+yzm/WRkUxsoliW00ZfbH159/too/Z tbXq/adGTK6TQn3+sVJWr4ncASEC/Bd/B2kAe6jXFzEObEWnKPdAmw8IjK+3JTi0i7pF 8/ab+4jS2bq9eV6NiyGW5DDPvQYogMXrnArOXyD7uWRcawPktYGIvYG/XZbeNX4iRHIN zxnA== X-Gm-Message-State: AOAM533LbrO2Lav4BJIH/zqtnvj0iYpkHbTeUWBSZG/VddgjHbRKXnjs MZ2pCZCRYuKtR1CrVKnmIhI= X-Received: by 2002:a17:902:bd0a:: with SMTP id p10mr12779367pls.159.1643451611733; Sat, 29 Jan 2022 02:20:11 -0800 (PST) Received: from nlap2 ([171.78.146.184]) by smtp.gmail.com with ESMTPSA id h6sm12312606pfc.96.2022.01.29.02.20.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 02:20:10 -0800 (PST) Date: Sat, 29 Jan 2022 15:50:04 +0530 From: Abdun Nihaal To: Greg KH Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] staging: r8188eu: remove unneeded ret variables Message-ID: <20220129102004.im7dcq5gbuyqlw4o@nlap2> References: <20220127152543.ttvp7gj5bzpuvr3p@nlap2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 27, 2022 at 04:51:04PM +0100, Greg KH wrote: > A single patch per function you are changing is a good idea. Do not mix > them all together, would you want to review something like that? > > Always remember that you want to make changes obvious and simple to > review. Got it. I'll split the changes, as single patch per function. Thanks, Abdun Nihaal