Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 29 Jan 2022 11:46:45 +0100
From:   Tommaso Merciai <tomm.merciai@gmail.com>
To:     Sergei Shtylyov <sergei.shtylyov@gmail.com>
Cc:     linuxfancy@googlegroups.com,
        Richard Leitner <richard.leitner@skidata.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: usb251xb: add boost-up property support
Message-ID: <20220129104645.GA2196@tom-desktop>
References: <20220127231437.10893-1-tomm.merciai@gmail.com>
 <978bc09c-b963-566b-8fa4-a53f1e5c569b@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <978bc09c-b963-566b-8fa4-a53f1e5c569b@gmail.com>
Precedence: bulk

On Sat, Jan 29, 2022 at 01:32:21PM +0300, Sergei Shtylyov wrote:
> Hello again!
> 
> On 1/28/22 2:14 AM, Tommaso Merciai wrote:
> 
> > Add u8 property to support boost-up register of usb251xb hub.
> > boost-up property control USB electrical drive strenght
> 
>    Strength.
> 
> > This register can be set:
> > 
> >  - Normal mode -> 0x00
> >  - Low         -> 0x01
> >  - Medium      -> 0x10
> >  - High        -> 0x11
> > 
> > (Normal Default)
> > 
> > References:
> >  - http://www.mouser.com/catalog/specsheets/2514.pdf p29
> > 
> > Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
> > ---
> > Changes since v1:
> >  - Fix patch as suggested by RLeitner
> > 
> >  drivers/usb/misc/usb251xb.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
> > index 507deef1f709..b60ab148e6ac 100644
> > --- a/drivers/usb/misc/usb251xb.c
> > +++ b/drivers/usb/misc/usb251xb.c
> > @@ -543,6 +543,8 @@ static int usb251xb_get_ofdata(struct usb251xb *hub,
> >  	if (of_property_read_u16_array(np, "language-id", &hub->lang_id, 1))
> >  		hub->lang_id = USB251XB_DEF_LANGUAGE_ID;
> >  
> > +	of_property_read_u8(np, "boost-up", &hub->boost_up))
> 
>    Isn't it hub->boost_up left uninitialized if an error occurs here?

Hi Sergey,
Thanks for your review. I invite you to check v3 of the patch.

 - https://lkml.org/lkml/2022/1/28/915

Tommaso

> 
> [...]
> 
> MBR, Sergey