Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <fb90b0a5-a8cf-0c94-ebbe-a0d5343fe3b9@amd.com>
Date:   Sat, 29 Jan 2022 05:49:06 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.0
Cc:     brijesh.singh@amd.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Andi Kleen <ak@linux.intel.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v8 36/40] x86/sev: Provide support for SNP guest request
 NAEs
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
References: <20211210154332.11526-1-brijesh.singh@amd.com>
 <20211210154332.11526-37-brijesh.singh@amd.com> <YfLGcp8q5f+OW72p@zn.tnic>
 <87d4999a-14cc-5070-4f03-001dd5f1d2b1@amd.com> <YfUWgeonL4tfGf8P@zn.tnic>
From:   Brijesh Singh <brijesh.singh@amd.com>
In-Reply-To: <YfUWgeonL4tfGf8P@zn.tnic>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUJ1QkhZSHVtQjdueUxCM3BtckQxem4xTzlFY3RjRytlN2dRQmh5U01UTDcy?=
 =?utf-8?B?M1B3VEM2eXFIbkFtb0NtNFNMRm5yQnBBS3hMeDJtQ0NhN3ZDVTJQVHNwWGhU?=
 =?utf-8?B?c25OWEV2U242cm5TYzlCNy9kczBZd1Nrc2VyaU9uYk1YYzVhY1pmeGUrR3Ax?=
 =?utf-8?B?SEZGMktNL3dxUVdEUFRiakUwV1VaQi9EUW9aNUhHTjJoZCtQTWJvTldrWWZ0?=
 =?utf-8?B?U0g3NnQ4bWFxNXFCK1hFQ3BoTkVBdlhpUHNZOFpuY1NxRm05dEhxblFFc3ln?=
 =?utf-8?B?dU5GY2VHM242L3lwTGlIVlN6T1VESFNRTGRGbkViaFB3S3JNVklBMVN6QUdP?=
 =?utf-8?B?VkhFdDZkM0YvK1hyYXg0QlpxQTRuMEFDMElhSWxJRDBlVElIWXlCUEh0SXZq?=
 =?utf-8?B?N09EZnJjTTNCQVowd09DVWY0L2VBUmY2SWQwUk5WTjVobVo3TGZuUEg1K0JZ?=
 =?utf-8?B?UkZ3emd1U3IrQzZGQ2ZOd0EwT0RHR0orTkkzbUtZWkJXYU92NjBJby91cnZQ?=
 =?utf-8?B?QmFwK1gvZEEyN3BxWjVpdmRsbmxJeUhzWk9PQ29ESEl5VTFVQ05SbzFrNVZG?=
 =?utf-8?B?cFA4VDdPUm81MlY2VDNaOTFlQnhTN25Eb2F1U2xjaXBKTmkveElrTkc0TFd2?=
 =?utf-8?B?aWpBeWhMK2VkZitUN0YwV3NTemttcEs4MVFQY1hjVnF3MlhQalZHekh0b0dy?=
 =?utf-8?B?MnRSZkRQWVFMN2RqR3BJM2hxbGtjWEhvcURSK2lRWGpIbGtrc3hUb2E2b2Rk?=
 =?utf-8?B?eEw2a3FHZlBJZGl0TFE0TXBSRE9xdXJVNFV2MHhDRHlpUzMyR0tDTHBHa1NE?=
 =?utf-8?B?Q1VvZDJ0YU5qYTFLTlM4S01mUjZpQ05hQWNMZVRERDdwblBYcWJteXpQTXlk?=
 =?utf-8?B?NlNqdlJTcUJhd1dUNkNvakxYZ0Z3WmJDS1pHQVJpTlhhZGlhYjEyWkJ4eUpq?=
 =?utf-8?B?REJxT0lvS2hCV2toM21hYUFJVjA4VUN6R1oyRlY1Zk40OGx1cFlYMlZ5aDR3?=
 =?utf-8?B?ckN1UHRtaHhWRG9sdDY2U1k0WGd5WWdVZVdaOUdSS0l4aldIZ3h1WlNkRFh6?=
 =?utf-8?B?RGlqRDIrVjBwOVozWXF4aFJNOGcraVNJbjdFOFNxbWhKR0tRdlg2ZHVrVHA4?=
 =?utf-8?B?TEs5bFp0Z1hJM3AwVjh6MUk5bFVJWHkyblRmT3dLRGFWWFNTUkNNTDlsTWNm?=
 =?utf-8?B?UzRsMVBrRkpaMVhwQ3ZoeWR4MFZTZmdTQjlqYWswOUYwVCtyZXg4WGdNWmh4?=
 =?utf-8?B?U2dGaHBOaVVhME9YQ2xidEx1QW5DZHNnbnRoTXpxNHYrNk5HUUI3UUVlS3Aw?=
 =?utf-8?B?YkJodWlIUTVCaXF1NzNoZWRucUNjTStEWVRTaFN6K2ZPVmIxNUhrUllRRlV1?=
 =?utf-8?B?WEF4ODEzNjYxSEs0UzB1dFNkL3l1cEZibU4zajduZmxLVllqenNoRmpSaFZy?=
 =?utf-8?B?eEtZdWsvVWc0K0hpSml0QmZEdFJhMlZpNjdIRGg3OFU1RkE5dE1Fb2hZd3hQ?=
 =?utf-8?B?QzJqSXBaUDEyTERxSFlac2g5ekFsSTU2ZGpiMVNTaWh3SGtML1pRakFWUjFY?=
 =?utf-8?B?RzF3MTJLSUdTU2VNbTJNMWhKUk9vb2FMays2SmxDOFB2NDF4Rkc2MkZwSUlS?=
 =?utf-8?B?ZC9EQ29oRkxPWDdYeXNKMmhDcDdYY1VJYnZzYmpOTElqeHJtR0VUMzZBNm5X?=
 =?utf-8?B?UVFiNFEyU1c3NGIzZ3NUdFg5R1dydEkzL3pKWUlKem0xZ0w3UTVXbU4wRCtj?=
 =?utf-8?B?cUd4UnhxMnRMb0F0N3B2TllGSXcxWnMxUWRXeWNFc3hFZGRWdGJnSlpFK3RJ?=
 =?utf-8?B?cUpNaWRTVlMyMTZ3THMvQkJVbVExRk5pMXNnMW5HZ041Z1dZcGNGYWtHN094?=
 =?utf-8?B?THdpa1ZETDdzejZtbmZRWGkzeWJvNEorOUt1dE1ScGZuQ3pURyswTUl6U21E?=
 =?utf-8?B?c1ZNbk1CaSt5QXlqaUdvaVpWeTFlZ09pajRVS1VNeUNDK01FeXNBbHg1Ky9o?=
 =?utf-8?B?c1o4TnZNRm5QSzJOTjdvbklaTHYxVElZQ3I4N1U1L0VodnJ0OFlURloyZFlH?=
 =?utf-8?B?bmRncWRzbjA5VWlGTTJkMDdtWlJQa0JSTkFRaWhFdlhXVmJ3WjVYS1hqcDVH?=
 =?utf-8?B?cVFiZ09Xd2xFSnE2Ry92T3dDdHYvRkJkallNQ2ZnSTF4WVBvV0tidnlCVjc4?=
 =?utf-8?Q?vrcOqmUatzdLlp4zP6xqo5I=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11c363bf-8878-45ff-c058-08d9e31d4e2a
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2022 11:48:45.7117
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 99jELdhg8I76TgIewNaOnhsoA+RRojuNzkjs57ZMOwa9aYScvMjK11GM4NBoiWl/18zrdzLXyIP5aEMBi9cgEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB2537
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/29/22 4:27 AM, Borislav Petkov wrote:
> On Thu, Jan 27, 2022 at 11:02:13AM -0600, Brijesh Singh wrote:
>> I am okay with using SZ_4G but per the spec they don't spell that its 4G
>> size. It says bit 32 will should be set on error.
> What does the speck call it exactly? Is it "length"? Because that's what
> confused me: SNP_GUEST_REQ_INVALID_LEN - that's a length and length you
> don't usually specify with a bit position...

Here is the text from the spec:

----------

The hypervisor must validate that the guest has supplied enough pages to
hold the certificates that will be returned before performing the SNP
guest request. If there are not enough guest pages to hold the
certificate table and certificate data, the hypervisor will return the
required number of pages needed to hold the certificate table and
certificate data in the RBX register and set the SW_EXITINFO2 field to
0x0000000100000000.

---------

It does not spell it as invalid length. However, for *similar* failure,
the SEV-SNP spec spells out it as INVALID_LENGTH, so, I choose macro
name as INVALID_LENGTH.

thanks