Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp176425pxb; Mon, 31 Jan 2022 18:47:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJxqKmUtXgtuclmYuONLh4pJvy3HVLCtsBY6I+wUBjQPTn3huVSxOOLGvVu1XC1r3MgIWnB3 X-Received: by 2002:a17:90a:b114:: with SMTP id z20mr27858628pjq.94.1643683640262; Mon, 31 Jan 2022 18:47:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643683640; cv=none; d=google.com; s=arc-20160816; b=pxZmJb0rAkuqJ+R8ei97wrkcwUJkRLhsFLtd9xEC1fBuzuHh1J6tPLIlEwDWwilgrx v+sD9a0Jnj/fIqQ8ltNi68AcHMBJ877+ONRrFQNTG+B5QK8/NfdbZQl7mFLDyFkP5d1e wVVgUVq2D7aEbm64NDO0P5SRatmSF0u/zn4+7VwIWlqTExKbm1k/6aXEXlZyObWbWNVK /xue9t4DvEOP6MhLsExS0nKbGPc/hiHws5rqEhEQk0xwbNLp9uAmNASAkW0QyNrsue0V cjmdH48t2J7DbzAe11Wk2Ppld1DiKIHT1YPGCvQwP8/e42Wnarobt9ROkAsuDW9bdNQR Uq1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=31GtAtozxIAbYu2fcxuIJ0ssFhQMM45afowSfajVZ7k=; b=kC4RDNyHdACbVAhfjrc9cfsjMU1UlWr6c/GPDYcJTk1jyQAbqhPqBJ9NNhr7w1sEPj 1DEsQftHv8MnICwFpaSwnrH0HPTn1+4vPIZ4GQGOnqScCMrPzh7DaWSf3/kSJI7FESU9 khmTryKFfu4zkUqcCXcaFBSewZU5hDNae13b//Bue6X7JZ1xq/E08Gx32D8NJUVJt61F CrloGYaZVLUEK6KP7yWqbTNVhuSN0xjrlkrqiF26ORLMDyUaCo9geicF4utxb8YyHiVb RiT9JzUqcw9aLhP19ZRWPbeY3/20s/9R+XRFz1J0nhwfbi3iOyQBKjGAq6yafrgaQNI3 JMBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=dfS2BCG1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h8si15785057pfh.359.2022.01.31.18.47.08; Mon, 31 Jan 2022 18:47:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=dfS2BCG1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352704AbiA2Qbt (ORCPT + 99 others); Sat, 29 Jan 2022 11:31:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352711AbiA2Qbq (ORCPT ); Sat, 29 Jan 2022 11:31:46 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3B52C06174E for ; Sat, 29 Jan 2022 08:31:44 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id g15-20020a17090a67cf00b001b7d5b6bedaso182687pjm.4 for ; Sat, 29 Jan 2022 08:31:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=31GtAtozxIAbYu2fcxuIJ0ssFhQMM45afowSfajVZ7k=; b=dfS2BCG1tJ1YlJ8hD0HkFk8j+DSZ4faQbbQrySqr+fx9awuWxbsRaR9+AoIOQyj/oB C2Py6wKfw0AIDfbzJUp7DFxSEgiFhZ5LF798yGGVmJ6EEXO9p81yqgyllc7wFOkQ8+ay ETwn3V3GopEg4peLiZ11vbOWtiIlqAg2xb73euxynkqHeUqKdIneFymqPS3H6/1ULp85 NkNMCOMxJGs8JZdFuMfzeAd+VyiqzqIGg+WlrqhtIpqETDAhdd+SYQmHjYErLKABARIe bvpABVN/8a/l/yQwtt+cRtXedv8sfNLGWqdZqfLlCczpqVWNu+jbgMtjp7aAG0wfo4HG TAaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=31GtAtozxIAbYu2fcxuIJ0ssFhQMM45afowSfajVZ7k=; b=iLJHiOSEI8DoaIJxeiu404YiErJe32qfWKyeAvmo/91UGtOAIXxp01yJBltib8ryHo AJHEmiI73VIyLolq8D256iI7yOlDGqTwuce5AOFj1GJ6oA/owwVb697Etj1DWhNlva+B +Vw+zSNTSWaKS5F3iT13Gsm5yAFW3ADE/Mi0EYPMvZyOgOFS2/muR7vWVcUF8Rkp+9OG TkBCt0xObEI4Jgdi5uUN0UAP44h1wWsqZBOZSlauNk+tyRGcwXvNjsRtCBMFYpZVKMv/ rKLe3dgZaiIJbGHd6ADKBwS2i0nzxD5ZQLwMpW8h24d4Tnwk7e03Rh4eXWuowkvKouUa kmww== X-Gm-Message-State: AOAM530qGJ9AHqqpmKC4yby4UwwVvhgvt0Hrng92oBAeezh/uXJUilz7 7xDe2ZfSlBhttFg18dHmeVaJjVANLo8= X-Received: by 2002:a17:90b:1912:: with SMTP id mp18mr25454989pjb.152.1643473904583; Sat, 29 Jan 2022 08:31:44 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:31:44 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 09/23] staging: r8188eu: propagate error code in rtw_p2p_get2 Date: Sat, 29 Jan 2022 21:58:01 +0530 Message-Id: <818aad89738b66942bb66568081f1953a9494078.1643466748.git.abdun.nihaal@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rtw_p2p_get2 calls functions that can fail with -EFAULT. Return the error code from the called functions. Signed-off-by: Abdun Nihaal --- - Newly added in V4 drivers/staging/r8188eu/os_dep/ioctl_linux.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c index 35f7ba66a7cf..99c7f9369d2a 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -3452,19 +3452,19 @@ static int rtw_p2p_get2(struct net_device *dev, DBG_88E("[%s] extra = %s\n", __func__, (char *)wrqu->data.pointer); if (!memcmp(extra, "wpsCM =", 6)) { wrqu->data.length -= 6; - rtw_p2p_get_wps_configmethod(dev, info, wrqu, &extra[6]); + ret = rtw_p2p_get_wps_configmethod(dev, info, wrqu, &extra[6]); } else if (!memcmp(extra, "devN =", 5)) { wrqu->data.length -= 5; - rtw_p2p_get_device_name(dev, info, wrqu, &extra[5]); + ret = rtw_p2p_get_device_name(dev, info, wrqu, &extra[5]); } else if (!memcmp(extra, "dev_type =", 9)) { wrqu->data.length -= 9; - rtw_p2p_get_device_type(dev, info, wrqu, &extra[9]); + ret = rtw_p2p_get_device_type(dev, info, wrqu, &extra[9]); } else if (!memcmp(extra, "go_devadd =", 10)) { wrqu->data.length -= 10; - rtw_p2p_get_go_device_address(dev, info, wrqu, &extra[10]); + ret = rtw_p2p_get_go_device_address(dev, info, wrqu, &extra[10]); } else if (!memcmp(extra, "InvProc =", 8)) { wrqu->data.length -= 8; - rtw_p2p_get_invitation_procedure(dev, info, wrqu, &extra[8]); + ret = rtw_p2p_get_invitation_procedure(dev, info, wrqu, &extra[8]); } return ret; -- 2.34.1