Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp176696pxb; Mon, 31 Jan 2022 18:48:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJysD08SFLsiFcaCV13vY+NM5sGSdFbDMrzUyMnxJSCFOYF0/ajo9ytX5f+a9IiQKUdkqN45 X-Received: by 2002:a05:6a00:23c3:: with SMTP id g3mr22947889pfc.51.1643683685354; Mon, 31 Jan 2022 18:48:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643683685; cv=none; d=google.com; s=arc-20160816; b=GCMBSqsLDX1oJap7lFgPD2qOHKC5MppgKbsU5W6v0mPFkjkPsIojxq7a16yvTSCws9 ohjNvihkwKpFMxglNXdg6P+dNJPDhQXRtHHyPvPUy3VkODH08gNeyChpvIGKgrs7Fooh hC8DR3Tpp9CfshKiKmcEbqMywHMhYojXMkbdhvByuhllxvxvbChFXPHKqJDSDmCzfReY oJYL77sltezsuWnv8qbdnjseh/gkHIWSyBgyEiq8PSsprLuqCkZGR/NzRGnW6QglkCAD zp3QmgKbCufIqrVWMBPE4+VW/5OTww3A4pRwuNwerOshjiT7lJTGZYYE/5JSZqmcyE+z NFxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Th8PVyYelZWCsFcO3s4hWSpijYoiPjQX9yudaKFZQco=; b=mF+mwEDQTFQCf6wq6tevHRYf9zuQX2yLUi8ijjcGY5auUzEPseU+KHpb4bRHwSh0a2 K79m77VvPqyZaOIAkOU2JouXSXjAM7uzEnsIa5eEwHlWM1HPo12yfiOF1ikP+rf9Kgps RPaCO4CA15C2uNpZ6Yx8xhzXbQDDtccB36bDrp+/ygeVStGOfoRfJXrpwjoJwsUQiv2Z DApgYsrryp3nf5rJnKwsqpiIdWQsJnXYyRAxjcZYV/S3e0RKSlyqTVlg+fKc6C3w9UbA oiH/XZaw4U0m3f2fP24TsLiadfm2uVFGzXz5PeX3tuGO9Od4z2hIV9761DVGZFlObXVk Uy+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=UTdYPZZp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s8si16047032plr.498.2022.01.31.18.47.53; Mon, 31 Jan 2022 18:48:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=UTdYPZZp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352695AbiA2Qbv (ORCPT + 99 others); Sat, 29 Jan 2022 11:31:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352674AbiA2Qbt (ORCPT ); Sat, 29 Jan 2022 11:31:49 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03E5FC061714 for ; Sat, 29 Jan 2022 08:31:49 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id h14so8883298plf.1 for ; Sat, 29 Jan 2022 08:31:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Th8PVyYelZWCsFcO3s4hWSpijYoiPjQX9yudaKFZQco=; b=UTdYPZZph8EsAJuRqYnss+oruj9Z7o1I+TKpquPsJv5MGwF93vsHmNWTUr/hutsjJg Dge+8mILBYWEOKQMnzqXz8x5W3xIRUdZYk6x0YabTfDtCQAt/ddIpaE+op9XV+fk9MMe PER/0j6n9askSdZgwS1tPC/MOWkQe94pMafJMb9vpuJ+0CzxnC6dpOYpDc5cxyNDDqQw vwRrVaSvgpxK24Vn2orj2sDPZ2WoIwVARu0kBBkIpCHX7t1cn+eqXonzJY06hzV55Ryu MjCsP3/B2y8dvNqpgJxr0D0P6fAp8QIk9BQ3QBatZ00HTvcOx0uHKd+uS/REfV4h33++ 14pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Th8PVyYelZWCsFcO3s4hWSpijYoiPjQX9yudaKFZQco=; b=IRv+Bj+FesFdW4a6KN9X/WonMIFwlv5oTrDXdeE/LJAbR4jPeJIvCGlXv1JI1XFRGo 8TTBHa7tXC1lxNKclzBAcTzZ8c7Ki/Lj1JBBYHgxeHlYOTD2X2C2G7wIrmJJBl7JMQrd 2Oyte6Z2M3kBuiOn0ROZPqBsx0v293r9H81+58qN2BKXIWet3umMeNDPmLzB1mFrZSmu 7CLdrEpJPiYOISLLz4b1EVb5WmEkauxCZZusi40m599XRYzVYMUQbbP+wH6liRw+96Xx CAqKfXL1Ad9y0S6sTgytfiGluwQTO5aMUzwt2CjzoDN9mQwIrK0Ll4lU44fAqKuSMMSz JA6A== X-Gm-Message-State: AOAM530jyOxYnX1w0yYKD9Rz2nR5yyFrM17eXX4oXS1iiel4o2AlEE/R NRnX5D+uAQA7Y2DNsEozpzI= X-Received: by 2002:a17:902:758c:: with SMTP id j12mr13491819pll.34.1643473908565; Sat, 29 Jan 2022 08:31:48 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.31.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:31:48 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 10/23] staging: r8188eu: convert rtw_p2p_set_go_nego_ssid to return void Date: Sat, 29 Jan 2022 21:58:02 +0530 Message-Id: <90e2b3e4ff99131423c11b8f9206916791f742d9.1643466748.git.abdun.nihaal@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rtw_p2p_set_go_nego_ssid always returns 0 and it's return value is not used. Convert it to return void. Suggested-by: Greg Kroah-Hartman Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c index 99c7f9369d2a..c761c06cf6e8 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2308,19 +2308,16 @@ static int rtw_wext_p2p_enable(struct net_device *dev, return ret; } -static int rtw_p2p_set_go_nego_ssid(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static void rtw_p2p_set_go_nego_ssid(struct net_device *dev, + struct iw_request_info *info, + union iwreq_data *wrqu, char *extra) { - int ret = 0; struct adapter *padapter = (struct adapter *)rtw_netdev_priv(dev); struct wifidirect_info *pwdinfo = &padapter->wdinfo; DBG_88E("[%s] ssid = %s, len = %zu\n", __func__, extra, strlen(extra)); memcpy(pwdinfo->nego_ssid, extra, strlen(extra)); pwdinfo->nego_ssidlen = strlen(extra); - - return ret; } static int rtw_p2p_set_intent(struct net_device *dev, -- 2.34.1