Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp184392pxb; Mon, 31 Jan 2022 19:01:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJwGEN8KTn5t7Qtn9h0rOGsvoyqT19RPX9CrauBYJ83BP4RMuCk0RvTPGQFKOJqLSu7avi3x X-Received: by 2002:a17:906:4c47:: with SMTP id d7mr12287547ejw.192.1643684502475; Mon, 31 Jan 2022 19:01:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643684502; cv=none; d=google.com; s=arc-20160816; b=hoNrZm0NwBQEN/P1bFsypcOLpUD7WkZdg8HLfvQkEuf2sW2FAEP9GGMscVm5aLTekL JAy7nsns+qQXfAmC4E+fcnxKDAc2h7DHGfLEv50enp8Ba1+HDRlyuXauRuTvEdm8tMOe OMdOL6GIYmlngxOMUR5VxSeehIkxShVoETr9z7eGCPOJTRifHXvRlAIfMhOIqdY8JN4Z ABS4QWtcY2sdzvDfYPOboASZ072cJruBQimbxYXmUjsrmv0PzmDmMKNXXjRJXr8szKgT X3BiKyHAYjJeoe1kvo/E4i9+96rD719ugtAg+WBAfScMeXxCdjk3Lupoz0OxMctlawAC l2TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=k1fC8pgJCKW2AtBxBMf1LhdlL3aFtmP7ejxI3861g2c=; b=iijaAFbmAmuQiGH+vlRIvuVetQIebUjogiSX3vgCGbF5Se8g0lpuoMoNx9LNInhrZP Qy415FtEn0t8JimzeR0KTkxe61NUfvWmQAyxGZMFBtct7NzSDJ5KowXKpgpS1CX19jXN 4oa01WVREzBlCUE9RArwi6+hlmj8Sq/xedRXOecWsqoU2W+V/sxX2Bvdrp7zhXTXdMIt OFTzHy+PNJXUZJgl4/pvFbFzAQIKt6zLIeI3sKVj1AJFknCWd363TibuoDvNFN+DkORN 5sxn+eviMED9aNZVXSugP4yu2bEfe+Ukdis/q4vo5y8SJS7NWbHjAH861pMKeoXA1AuP aaDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=UaZWcvkx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i9si2495589ejw.648.2022.01.31.19.01.17; Mon, 31 Jan 2022 19:01:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=UaZWcvkx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352793AbiA2Qcd (ORCPT + 99 others); Sat, 29 Jan 2022 11:32:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352780AbiA2QcO (ORCPT ); Sat, 29 Jan 2022 11:32:14 -0500 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE458C06173B for ; Sat, 29 Jan 2022 08:32:07 -0800 (PST) Received: by mail-pl1-x62c.google.com with SMTP id s6so3316309plg.12 for ; Sat, 29 Jan 2022 08:32:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k1fC8pgJCKW2AtBxBMf1LhdlL3aFtmP7ejxI3861g2c=; b=UaZWcvkx9dAVtN7KfWy0oIgSfqKPRE2rClc31qACpThl9h9edITZpYue6sqp45SIfG 5hVx/tvB7ovb76LJzfmvtyqrvk6NPGIcz/U0Z+4f/hrYV08laT83kIorCEj5tdBV0zxh 9/VRkIS8ig6fDWhYa1rxgq6sVdQOpFk6wwIH7q0NDNYzIPHVfd3sfObcaGdKNAoYtRQT UFxp/8Jd9FcF4Z7g9ExOLk5utUhiMAVMtvZfovXLALdhE+uSEa27oNGBMutMCTFr3vQH nO6CShVQRzisz6UOHsK6GIDxyESb49cWA2stlgYpX5GAiECB2mFE76kF33bYzOYrD+2H oxag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k1fC8pgJCKW2AtBxBMf1LhdlL3aFtmP7ejxI3861g2c=; b=a9I+yUoIzQqoDxLOFdcsFafLUHXvTcr2DUbczhwtcyVaZjVnErO4rHvGYw5W5UfE29 iV4569SQO/DnJCdsaikGlSzc38yLaNl1Vdmrdh212ppcAmPijr3LE/5ZiOuUyKnxpBh3 4NLwmrdJKHzbhAsYUpdCHvaoJuvHI3AcnDYNHdZZge1c96NsoloIbQQJ/czG3ElpbROV Og4k+0UEl2U9dXCJNHo29qPqjYK5Y5SkayCDki1dygpi+jYj/FiK/2bRe2sNJhK6tpFN xx+O5bDgdw0PSc45uZlCV6KIbTFF4C3oqm4/z251aCNWGhF2Vo9J0tsbmBECNHaokuJL YMNg== X-Gm-Message-State: AOAM530RAZq1Bq89/MYgQau15GyFJ7mz4qPMCzr0+ZsjrhKQQoAXOK22 jrQ0DDGRyp981c6HWVMAey8= X-Received: by 2002:a17:902:f205:: with SMTP id m5mr13573098plc.71.1643473927298; Sat, 29 Jan 2022 08:32:07 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:32:06 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 15/23] staging: r8188eu: convert rtw_p2p_get_peer_ifaddr to return void Date: Sat, 29 Jan 2022 21:58:07 +0530 Message-Id: <4a51963ce86a5f6bed4c07e545cd64091eeb0a8a.1643466748.git.abdun.nihaal@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rtw_p2p_get_peer_ifaddr always returns 0 and it's return value is not used. Convert it to return void. Suggested-by: Greg Kroah-Hartman Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c index 343b4ad6ce65..1f89f4fe4d8e 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2516,11 +2516,10 @@ static void rtw_p2p_get_role(struct net_device *dev, wrqu->data.length = strlen(extra); } -static int rtw_p2p_get_peer_ifaddr(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static void rtw_p2p_get_peer_ifaddr(struct net_device *dev, + struct iw_request_info *info, + union iwreq_data *wrqu, char *extra) { - int ret = 0; struct adapter *padapter = (struct adapter *)rtw_netdev_priv(dev); struct wifidirect_info *pwdinfo = &padapter->wdinfo; @@ -2530,7 +2529,6 @@ static int rtw_p2p_get_peer_ifaddr(struct net_device *dev, sprintf(extra, "\nMAC %pM", pwdinfo->p2p_peer_interface_addr); wrqu->data.length = strlen(extra); - return ret; } static int rtw_p2p_get_peer_devaddr(struct net_device *dev, -- 2.34.1