Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp186210pxb; Mon, 31 Jan 2022 19:04:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJyXbaBNiMeROlncIQBfH7wS88ddc2dwJ7Ae+LeT2AsOTW/ZCug5ILKg5ar6AZrCzT4cWU+7 X-Received: by 2002:a17:902:b495:: with SMTP id y21mr23393534plr.82.1643684681130; Mon, 31 Jan 2022 19:04:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643684681; cv=none; d=google.com; s=arc-20160816; b=rRhUTjyjD9JqFQl5aqq5BhL3iZs9hV234kFacL/hVUnPQxWc+oOf3EFnEtSwA0JiyN z37p7SW0r1KBgpra771wwtoqudWRSaGw5ZCdoBV+O0k52tkbrVh8BzQ9oFUBFztMHy5b SV39gB7ivhctb3xmC+J09zpgFqb1SbR5XcGyaT08O5pPrPYkRWao8IXNI1E3s05KR7Nl MzxpWC1hs1JVHCZ1HdW+9S9jDnMLqcfOxvxJPGMUXrbo42eW2gqqOUZfxbKOPH0bEXfR EVD8Z7f+MzuZSI4HozQ9oYsLcqsnI7jJVgITlRyBzCoB9/TRXHm3FF1e6ZbjB0hRZB9q R/Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mk12BTSCM2+mq3xJbziWeOLcSVGsDqsbYqmoTpChlQM=; b=dB7+pt9cPN5El1NbHRD6lPQc+bC9lrCCN2yE5ZUl3iaUB2UCbaTBqBxL2Sit/fT4Zy jkKNJ6fS3nIFlB4mLlHDDnOWdyE2raEmEMSe7k8w69i8xl2bvV9KIQEKmZK7JNDowqRG 3+OJlm9D9H5O8QMDSGgv53QEUTVjhWgiZlRumoYfpFJapscEn7nJHpZlvskcoSW+w/6M /itIzVqoDGG69V/QwgqEIb133KUCyro2PPv3+da1eqSOOEwedsqx0qFS2sjC1NO6+PrQ MKZoHtmUbBDwGDbP4qJzzrhGPYMth1DdiGzJP3oRST31a3uaibEUYs1vh0CyGm6vPTeH JVFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ae1z82YS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f10si13679545pgc.276.2022.01.31.19.04.28; Mon, 31 Jan 2022 19:04:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ae1z82YS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352852AbiA2QdH (ORCPT + 99 others); Sat, 29 Jan 2022 11:33:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352644AbiA2QcS (ORCPT ); Sat, 29 Jan 2022 11:32:18 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5CF7C061748 for ; Sat, 29 Jan 2022 08:32:15 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id c3so8860433pls.5 for ; Sat, 29 Jan 2022 08:32:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mk12BTSCM2+mq3xJbziWeOLcSVGsDqsbYqmoTpChlQM=; b=ae1z82YShCLldmO4lu1B2Nf5vJMnS3IS+SkfIuouT3SGDC0i92Joxo5b9sAR3T4s/u xMQnB7RCnrAhj3b3w348Ql6yn3+xLjWBotBRShWZjexpKPhom4EUeL0KzUVgEYDNvEOs nB3ZR9IHqdXYBEW1n9kzavhQJ1d5w/swDuzgzEbKXNSAHxpnOgnc39NCuq6MpEzBSsC8 wogeK7lBFtuV6n+XcsFnuThxAb6IWLH7KNqsi/sQ7g8xYoBQq7M/abJm6srYn9EQTGGm K2NE0b96HY6MAN6i6FkP4M3MD+4dtJeikuu0k+8mfscxfj03bmt+rLoBrkX3t7vqprsB UEGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mk12BTSCM2+mq3xJbziWeOLcSVGsDqsbYqmoTpChlQM=; b=eax4e3sMJx48l/cLVPCRrAxvA4qmtpbkSBibR90f1RG4G8l+xCzQrr/LQfM2/hw8SM opGvQpVwdibs5gSasgrjy/8WnzhY/HvaoDVIkbjkCb4BAEGO+/2sXBwigAb5ehHVG+N7 5lGoQjjTUXEe8RHwOVVPAy0zp75DafMx66t4tqMwZnrw9YlN7fpSf6bYyStFIr06W1pb AtXq+K7Y+SRJa65piRj2PcTFFJSjb6ZjAURzJLQ5ZyhoNd4Xv3dekfg43dOr+o6syX0s hibK/ZVqWEKTuxmvGxkKNal56glv+EDIb/c7xzMjasXJMGa3ZgWgV0A56dnyyGZgg4P2 n3aw== X-Gm-Message-State: AOAM532VW3PlALN/zYonc39MTBNi9O5N9KPDsBSxeKJQ938PDMBGkwC4 8Jast6aB672CaWXdej3MlFprXHjxwGw= X-Received: by 2002:a17:90a:a385:: with SMTP id x5mr17242737pjp.129.1643473935287; Sat, 29 Jan 2022 08:32:15 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.32.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:32:14 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 17/23] staging: r8188eu: convert rtw_p2p_get_peer_devaddr_by_invitation to return void Date: Sat, 29 Jan 2022 21:58:09 +0530 Message-Id: <06e2dce5de14c1abe457a40ec9ca597a06095437.1643466748.git.abdun.nihaal@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rtw_p2p_get_peer_devaddr_by_invitation always returns 0 and it's return value is not used. Convert it to return void. Suggested-by: Greg Kroah-Hartman Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c index dfd19a649803..9ee647de5ba7 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2547,12 +2547,12 @@ static void rtw_p2p_get_peer_devaddr(struct net_device *dev, wrqu->data.length = strlen(extra); } -static int rtw_p2p_get_peer_devaddr_by_invitation(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static void rtw_p2p_get_peer_devaddr_by_invitation(struct net_device *dev, + struct iw_request_info *info, + union iwreq_data *wrqu, + char *extra) { - int ret = 0; struct adapter *padapter = (struct adapter *)rtw_netdev_priv(dev); struct wifidirect_info *pwdinfo = &padapter->wdinfo; @@ -2562,7 +2562,6 @@ static int rtw_p2p_get_peer_devaddr_by_invitation(struct net_device *dev, sprintf(extra, "\nMAC %pM", pwdinfo->p2p_peer_device_addr); wrqu->data.length = strlen(extra); - return ret; } static int rtw_p2p_get_groupid(struct net_device *dev, -- 2.34.1