Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp186574pxb; Mon, 31 Jan 2022 19:05:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJxatYJMgXsdTTzYs8BO8/Ab4saEFrXw16psu4sOV4vt5G0aky0fgmaSpnXJ4j+0m0h3yc64 X-Received: by 2002:a17:902:b7c1:: with SMTP id v1mr23995598plz.44.1643684720006; Mon, 31 Jan 2022 19:05:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643684720; cv=none; d=google.com; s=arc-20160816; b=1JS+64W7Aszy5zx+HNfxsj60VQDamMUXUu1UJj/TBobVRbq55tgfjvBGrzvr6W8V44 aGOhlxRwnpML1/+f19N1yYrNmqXHO5WxWd3fNCVXe2KCAt4RzMz5T/1INxpQNYFW1aOe ikUeE694zWEOD+DwLUY0gGau1HBShRzMdD/ga7dIt/8v9oXZvnnpb7vmGhSu8gSlnF6Z 4ZJ0MGhNddye3UUHCAPE4znxzj0lBpKv+3wKiBPWbufH7cs8nqDRIYdMuTA09X7dC/x9 tgZ9X+MEWW4W3qqsiuMor8G0ITAPnaZzFZ4UN+NHZ/L/beAVHt1qV/l8jGcr+M13bGwf yXAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VpVRaJzkm+JbIjqlEl728sQqMfSlR+afyO5cWMLCT/U=; b=BaBEbCiwuTYU9DWwmK2NDRa2g8FwPyJMfr2rx6lt8+d7jiTRq26fonxye+Jpv8lxhS e+RTdDwkNcnhx8XyBr1SmDvvTJpFfjOh0CMbfx4AvqfSk+ey2Y3BSUBPaMWAG4LZrtaU zotRHUWtdk378TfjTjFGiT3dOV6k7bZiwjhqfam1pYPLVhGtrJWD6e+yOBEZyUnxwIMn nLpsnfrqH7k20B75eWDVE1cvfqHaYRYSA2CUX9Fyayc7PEzCwZw9FGpZ93BFceB2kfBW sM5OVwBNhllC6Kqb/YPgOn65WBfsLSGmMaMiYj/gttZgwEA9mPbisivaSP7nqA2fDC52 ABEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="ZZQAq/ag"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w24si13592266pll.11.2022.01.31.19.05.07; Mon, 31 Jan 2022 19:05:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="ZZQAq/ag"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352878AbiA2QdR (ORCPT + 99 others); Sat, 29 Jan 2022 11:33:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352738AbiA2QcT (ORCPT ); Sat, 29 Jan 2022 11:32:19 -0500 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA6F5C061749 for ; Sat, 29 Jan 2022 08:32:19 -0800 (PST) Received: by mail-pg1-x52c.google.com with SMTP id h23so8036974pgk.11 for ; Sat, 29 Jan 2022 08:32:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VpVRaJzkm+JbIjqlEl728sQqMfSlR+afyO5cWMLCT/U=; b=ZZQAq/ag6BwNihmNPCYUtvhU11+52KEkNN0Gqs6Q/mrsVMdpr/RVp9bEOEnl7IgWNH EIgA02xreBYGRLTBtAnKgXO3RIVM8sTeUQ6BVRTdFQeFpF7fZw1JJFeeT1xVVSFs4A8f zD+E/mGoQvNX1Y1Lcslyejr1mvHULEquMkjiSxSMmtsRTMMtl4NC9s0wsd5lUn4RaB1z IRGo5WB7gYRfrOzTOJB76AN4T4BWi8EyodgP+KojS1yCu+0GUSQoFwS6uo3HvQ0+FDup rJwAND2V5r8AbprT89qgQ/G3TWYDf7ieNwKhwZ9HBTG2KqU9quTFT+2zyAGuhyMZYicM cTnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VpVRaJzkm+JbIjqlEl728sQqMfSlR+afyO5cWMLCT/U=; b=w0YkKPfNPicUjTb2GDk2jyhB/zh0B+Qz82jJzFIEC2L+dH4MgN5eIeqCzUfeJgrWpu D15RurDy6s64SmKmhlGyT9o2mCjYUeGSmqRDTy37A4hyO2W+1A12COonwcbTKQS+ozJx BuLWMrF1Mk9CLmdekLLDW1a7dH/Mcc+CBatgpu+Kou2mH2YMRKyk+FRLhKUGA3C8KFag a87YzZKOs4QOg9oqbH94sNc2C0NmKUxzhYNpYuCkBNLkUhlD1TlYlhxzmFSxEVBe7ZZs LEMGtyA42yhwtf+6Zmx51IlceLa5CVpMFejowR+WnArfCHTFmhq/0xJmhXiyuaVr+6v2 Sk/g== X-Gm-Message-State: AOAM531VUXEU0VEMVa9lzy5s9NamZc6U+V56FvyvaJx1y6Xx2822pUsZ QmzC0jgp5wPik2ap6AwdW+U= X-Received: by 2002:a65:538e:: with SMTP id x14mr10615001pgq.58.1643473939501; Sat, 29 Jan 2022 08:32:19 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.32.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:32:19 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 18/23] staging: r8188eu: convert rtw_p2p_get_groupid to return void Date: Sat, 29 Jan 2022 21:58:10 +0530 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rtw_p2p_get_groupid always returns 0 and it's return value is not used. Convert it to return void. Suggested-by: Greg Kroah-Hartman Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c index 9ee647de5ba7..4c47e9bb7fc3 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2564,12 +2564,11 @@ static void rtw_p2p_get_peer_devaddr_by_invitation(struct net_device *dev, wrqu->data.length = strlen(extra); } -static int rtw_p2p_get_groupid(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static void rtw_p2p_get_groupid(struct net_device *dev, + struct iw_request_info *info, + union iwreq_data *wrqu, char *extra) { - int ret = 0; struct adapter *padapter = (struct adapter *)rtw_netdev_priv(dev); struct wifidirect_info *pwdinfo = &padapter->wdinfo; @@ -2579,7 +2578,6 @@ static int rtw_p2p_get_groupid(struct net_device *dev, pwdinfo->groupid_info.go_device_addr[4], pwdinfo->groupid_info.go_device_addr[5], pwdinfo->groupid_info.ssid); wrqu->data.length = strlen(extra); - return ret; } static int rtw_p2p_get_op_ch(struct net_device *dev, -- 2.34.1