Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <964539a8-334d-37d4-99e7-d2dd76887fa1@infradead.org>
Date:   Sat, 29 Jan 2022 09:03:23 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 4/8] arm64: Add Kconfig/Makefile to build hardware
 prefetch control driver
Content-Language: en-US
To:     Kohei Tarumizu <tarumizu.kohei@fujitsu.com>,
        catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        x86@kernel.org, hpa@zytor.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20220125071414.811344-1-tarumizu.kohei@fujitsu.com>
 <20220125071414.811344-5-tarumizu.kohei@fujitsu.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20220125071414.811344-5-tarumizu.kohei@fujitsu.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 1/24/22 23:14, Kohei Tarumizu wrote:
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 6978140edfa4..c2256dbb0243 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig

>  	def_bool y
>  	depends on STACKPROTECTOR && CC_HAVE_STACKPROTECTOR_SYSREG
>  
> +config ARM64_HWPF_CONTROL
> +	tristate "ARM64 Hardware Prefetch Control support"
> +	depends on HWPF_CONTROL
> +	default m

Don't enable random drivers unless they are required for booting etc.
So can you justify having this driver enabled by default?

I see that the X86 driver is not enabled by default.

> +	help
> +	  This adds Hardware Prefetch Control driver support for ARM64.

thanks.
-- 
~Randy