Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220129093907.2196730-1-j.neuschaefer@gmx.net> <c2ec8677-e7a2-c9cd-b291-9785e7e2800c@infradead.org>
In-Reply-To: <c2ec8677-e7a2-c9cd-b291-9785e7e2800c@infradead.org>
From:   Tali Perry <tali.perry1@gmail.com>
Date:   Sun, 30 Jan 2022 09:46:55 +0200
Message-ID: <CAHb3i=vxghPw57Z=aEe-ns=LaD69eYyCv5VqbKBaARn9ZLfL8w@mail.gmail.com>
Subject: Re: [PATCH] i2c: npcm7xx: Fix typos
To:     Randy Dunlap <rdunlap@infradead.org>,
        =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
Cc:     Linux I2C <linux-i2c@vger.kernel.org>,
        Avi Fishman <avifishman70@gmail.com>,
        Tomer Maimon <tmaimon77@gmail.com>,
        Patrick Venture <venture@google.com>,
        Nancy Yuen <yuenn@google.com>,
        Benjamin Fair <benjaminfair@google.com>,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kfting@nuvoton.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Reviewed-by: tali.perry@nuvoton.com

Thank you very much !

On Sat, Jan 29, 2022 at 6:18 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
>
>
> On 1/29/22 01:39, Jonathan Neusch=C3=A4fer wrote:
> > The comments in this driver have a few typos. Let's fix them.
> >
> > Signed-off-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>
>
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
>
> Thanks.
>
> > ---
> >  drivers/i2c/busses/i2c-npcm7xx.c | 16 ++++++++--------
> >  1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-=
npcm7xx.c
> > index 2ad166355ec9b..71aad029425d8 100644
> > --- a/drivers/i2c/busses/i2c-npcm7xx.c
> > +++ b/drivers/i2c/busses/i2c-npcm7xx.c
> > @@ -781,7 +781,7 @@ static void npcm_i2c_set_fifo(struct npcm_i2c *bus,=
 int nread, int nwrite)
> >               /*
> >                * if we are about to read the first byte in blk rd mode,
> >                * don't NACK it. If slave returns zero size HW can't NAC=
K
> > -              * it immidiattly, it will read extra byte and then NACK.
> > +              * it immediately, it will read extra byte and then NACK.
> >                */
> >               if (bus->rd_ind =3D=3D 0 && bus->read_block_use) {
> >                       /* set fifo to read one byte, no last: */
> > @@ -981,7 +981,7 @@ static void npcm_i2c_slave_xmit(struct npcm_i2c *bu=
s, u16 nwrite,
> >  /*
> >   * npcm_i2c_slave_wr_buf_sync:
> >   * currently slave IF only supports single byte operations.
> > - * in order to utilyze the npcm HW FIFO, the driver will ask for 16 by=
tes
> > + * in order to utilize the npcm HW FIFO, the driver will ask for 16 by=
tes
> >   * at a time, pack them in buffer, and then transmit them all together
> >   * to the FIFO and onward to the bus.
> >   * NACK on read will be once reached to bus->adap->quirks->max_read_le=
n.
> > @@ -1175,7 +1175,7 @@ static irqreturn_t npcm_i2c_int_slave_handler(str=
uct npcm_i2c *bus)
> >                               /*
> >                                * the i2c module can response to 10 own =
SA.
> >                                * check which one was addressed by the m=
aster.
> > -                              * repond to the first one.
> > +                              * respond to the first one.
> >                                */
> >                               addr =3D ((i2ccst3 & 0x07) << 7) |
> >                                       (i2ccst2 & 0x7F);
> > @@ -1753,8 +1753,8 @@ static void npcm_i2c_recovery_init(struct i2c_ada=
pter *_adap)
> >       /*
> >        * npcm i2c HW allows direct reading of SCL and SDA.
> >        * However, it does not support setting SCL and SDA directly.
> > -      * The recovery function can togle SCL when SDA is low (but not s=
et)
> > -      * Getter functions used internally, and can be used externaly.
> > +      * The recovery function can toggle SCL when SDA is low (but not =
set)
> > +      * Getter functions used internally, and can be used externally.
> >        */
> >       rinfo->get_scl =3D npcm_i2c_get_SCL;
> >       rinfo->get_sda =3D npcm_i2c_get_SDA;
> > @@ -1768,10 +1768,10 @@ static void npcm_i2c_recovery_init(struct i2c_a=
dapter *_adap)
> >
> >  /*
> >   * npcm_i2c_init_clk: init HW timing parameters.
> > - * NPCM7XX i2c module timing parameters are depenent on module core cl=
k (APB)
> > + * NPCM7XX i2c module timing parameters are dependent on module core c=
lk (APB)
> >   * and bus frequency.
> > - * 100kHz bus requires tSCL =3D 4 * SCLFRQ * tCLK. LT and HT are simet=
ric.
> > - * 400kHz bus requires assymetric HT and LT. A different equation is r=
ecomended
> > + * 100kHz bus requires tSCL =3D 4 * SCLFRQ * tCLK. LT and HT are symme=
tric.
> > + * 400kHz bus requires asymmetric HT and LT. A different equation is r=
ecommended
> >   * by the HW designer, given core clock range (equations in comments b=
elow).
> >   *
> >   */
> > --
> > 2.34.1
> >
>
> --
> ~Randy