Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <bebb72d9-f9cc-c247-2d1c-96495aaf5f54@amd.com>
Date:   Sun, 30 Jan 2022 09:56:12 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 2/2] drm/radeon/uvd: Fix forgotten unmap buffer objects
Content-Language: en-US
To:     zhanglianjie <zhanglianjie@uniontech.com>,
        Alex Deucher <alexander.deucher@amd.com>
Cc:     linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>
References: <20220129073524.31534-1-zhanglianjie@uniontech.com>
 <20220129073524.31534-2-zhanglianjie@uniontech.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220129073524.31534-2-zhanglianjie@uniontech.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmg2LzBFOUc3SnJZc0E2RkVhV0VaR0hFVnhCeTNMZkRyQW83M3dnNXhCUkpZ?=
 =?utf-8?B?aGVGYnBTeHpOQnhwUkpmcEFya0R0RW8yNFFUQlJmRk1MajZYTFBTR3VqRzVj?=
 =?utf-8?B?WThaYjVjRlRRZUhYYklwaTdxREZYNmlHSDNNZCs4bUJrSkxqVlYwaFJQalF3?=
 =?utf-8?B?ZU5zOVVhM0U3L0I2bGpHemFwQjE5UVNHN2ljeWNEWVQwVFh2WXVHc2xWL09i?=
 =?utf-8?B?VURLbnZXR25mbktxK0hndHdOWmsrNHJyY0dkdVpxTmUvbHlkQ2lROXBIYkYz?=
 =?utf-8?B?bW02L3ZtMTJZMnd5bnU0QXROSG12K1hLSHp1Z2poeE9ZNkRyMVp3MFpnVUlY?=
 =?utf-8?B?Q0FmRS9rYjdkQzNYV1ozekhUL01vT0NLYTh4Ykt2alAvUkx6MEtHQjZBcVZv?=
 =?utf-8?B?UlhDWVlwK05yeHl6ekNHbWYrdVRGdWc5YjEwTVEybmhTRkhEUEhnRDNsQ2pQ?=
 =?utf-8?B?dytwalFIZEFaZnNMYzlNRFNSTnY5cExFUWErdlhQbG9GckYvS3FJNlZ4RGMx?=
 =?utf-8?B?MXVnQkFaYURTTWkxWExScC93dEs3N01MTW5ESGlJODQ5ay9VTXJicnNhamRt?=
 =?utf-8?B?c1p6ZHZpekVnTVhTMzQ2YkNUVHEwbVg0L0lMMWhvcUtZNUUwdzZCa2RiV0R2?=
 =?utf-8?B?bjZqWG5zRE1mVm1SdTRFSEIyWERIR3FLb1VXcXpIWkFGWFNvNk5mM04rK2ky?=
 =?utf-8?B?T3M0dXFWOU9UU0VKNUF1TSs5czR5c3J0by9LRXlENmhiWHgyTGduZWZ1UWpp?=
 =?utf-8?B?Vm03L1J3UmptQ3pIcDU2VmkvUktxQzVPMUZ3aVFxVUo2QVFQbzRkWklFNkZW?=
 =?utf-8?B?eDFSN0dBNDFURm43Qk9DRThsdi8yc1l2bS9Ib1JKVnFoT0gyNndERCt2V29s?=
 =?utf-8?B?M1hVSnNzY2VOZUczaVZXaUhvWE9FUGJhTVlWVEpJVjZQNllESk9GditEYWpi?=
 =?utf-8?B?a3J1TVpNbmVOT0ZDQ1UxT2ZVMXJ4b0JnUnpvdSsyRHVzeXZkeGdRTFJMY2s2?=
 =?utf-8?B?cEwxTFU0ejNzR3kxVVF1YlFEVnFkUE0wSWtFV1dBMWxESHJlNGtkV2F5dktw?=
 =?utf-8?B?VGFJanlPUGlUWDRxSytQZEN1Z2RqUlg0NG1UT3NkbGRJd0RnamJJbFRrbjhD?=
 =?utf-8?B?eDZJUHp2ZHlhWm9SbHRPbk95UTV4ME81T3hLMk1QS2hVMzVuMFVRamExVTZz?=
 =?utf-8?B?SEsyNkNmUkVsQ0pzNlB6cFE5YU1uY3M4Q0k5Rlg0Tks2eFV6eVJsVzJZMzg3?=
 =?utf-8?B?WlRiZmxzaEpwdlRKb2czU3drdSttMEFYUmdyMFpQTWIvQ1A2NmVpa0I5TFo5?=
 =?utf-8?B?djlNcndKZmMwZUdEU2hNc214bHpWczBJWlV0YndLcDZKcW45aW96cDcyTHlO?=
 =?utf-8?B?S2E0ejJKZHh5Ymg5V0pJSGRaWExpbGRFRmJhSVlmOC9iUm1TdUJweDhMRlkr?=
 =?utf-8?B?eTFid2RUR3VWMzNLd3ZWZFpmSjQ4QVI1ZEpRWjNpRytpT1hyQXE4UG9udTFw?=
 =?utf-8?B?bjRxQnF2eFZCdWRGQW5uS3BBYXhuN0FIQUVZNmdRY3ZkWTZWajlEU2pyNEs0?=
 =?utf-8?B?YjY4TnRNWXBsTmhkblo0MFpqdTdBa2VLOGIyUlN6aGdzOTE1aGtYRUJRTWFm?=
 =?utf-8?B?bTJLeWNscHc2bnRCdHVsamErZ2xKalJNTXJuTGgwNkpCUjFNVy9jQVlGZTJ2?=
 =?utf-8?B?SHl5UTlURHdMRzFlOXFVditzVStsRElyOXVtYmxXTW8wcHNDUDdLUGhQdEFJ?=
 =?utf-8?B?bWwxVjJqY3JJOWM5TEdOQUg0bzlTbVZnNDRJWEU2R1A4SXBhc21weE5hR0lJ?=
 =?utf-8?B?UUtabnI4K3hSc1pPdnJOcFVZNEpTdUdEUk5XSHRqT0VpVm1TYSsrQll3M1Vj?=
 =?utf-8?B?c0QxQXNMTHpFdi9XWFhQaFZHSm40TWV5cGk1ZURZSmpPbThzdTdZeHAvaXFF?=
 =?utf-8?B?citlNzJENmpoV2plQU5VbHpnbGhUbERjYmc3Q1prcTFHQmxhaVkzN3kxWFV2?=
 =?utf-8?B?RHNqemhETnc0MXV6SThwMDNyL3hvQXlqN1c4ZDFrVUsvSHNJWHVRRzVmc2h1?=
 =?utf-8?B?cDE3cmtuLzJzRHNQWlJ6TjFnZ1o1YUNSeHBpQ2ZML2cvZkNnVFJFcDZTUkp0?=
 =?utf-8?B?ZTdpeFIzZkVLbXo4Z0Evb094MW5KT0VTSnlFU1NwZ0tPb2FjTEpQem5PMk5o?=
 =?utf-8?Q?r/Cgm1ERrSu/+WGLCKQSKAU=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b8688487-e49f-45eb-f9d4-08d9e3ce6082
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2022 08:56:17.4100
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cRDzwn1WmWh9XnDjSy3z0dj8ZarUDUnUYybR5sBZ2SryZ5p4Qms/SPWoUVyXSxAT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5340
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Am 29.01.22 um 08:35 schrieb zhanglianjie:
> after the buffer object is successfully mapped, call radeon_bo_kunmap before the function returns.
>
> Signed-off-by: zhanglianjie <zhanglianjie@uniontech.com>
>
> diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c
> index 377f9cdb5b53..c5482f7793db 100644
> --- a/drivers/gpu/drm/radeon/radeon_uvd.c
> +++ b/drivers/gpu/drm/radeon/radeon_uvd.c
> @@ -497,6 +497,7 @@ static int radeon_uvd_cs_msg(struct radeon_cs_parser *p, struct radeon_bo *bo,
>   	handle = msg[2];
>
>   	if (handle == 0) {
> +		radeon_bo_kunmap(bo);
>   		DRM_ERROR("Invalid UVD handle!\n");
>   		return -EINVAL;
>   	}
> @@ -559,11 +560,10 @@ static int radeon_uvd_cs_msg(struct radeon_cs_parser *p, struct radeon_bo *bo,
>   		return 0;
>
>   	default:
> -
>   		DRM_ERROR("Illegal UVD message type (%d)!\n", msg_type);
> -		return -EINVAL;
>   	}
>
> +	radeon_bo_kunmap(bo);
>   	BUG();

That looks like it will trigger this BUG() now. Please also remove that 
line.

Apart from that the patches look good to me.

Regards,
Christian.

>   	return -EINVAL;
>   }
> --
> 2.20.1
>
>
>