Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <0fe601eb-2993-79a5-bb45-6eafc7f9d0ba@wolfvision.net>
Date:   Sun, 30 Jan 2022 10:49:54 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 2/3] arm64: dts: rockchip: rk356x: Add pdm node
Content-Language: en-US
To:     Samuel Holland <samuel@sholland.org>,
        Heiko Stuebner <heiko@sntech.de>
Cc:     Alex Bee <knaerzche@gmail.com>, Chen-Yu Tsai <wenst@chromium.org>,
        Levin Du <djw@t-chip.com.cn>, Liang Chen <cl@rock-chips.com>,
        Peter Geis <pgwipeout@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Tianling Shen <cnsztl@gmail.com>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-rockchip@lists.infradead.org,
        Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
References: <20220130053803.43660-1-samuel@sholland.org>
 <20220130053803.43660-2-samuel@sholland.org>
From:   Michael Riesch <michael.riesch@wolfvision.net>
In-Reply-To: <20220130053803.43660-2-samuel@sholland.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sk85bXlpSUhuR0hiY1gyWjlWc1kydmprSk84b29xbU1hWEZmeHhFTzltSHFM?=
 =?utf-8?B?eTBJcVF3eHZLak9OdmV5S0tsRlp2VE5CTUlyN3U3TllHaEU4Rm0rTy9ESE9N?=
 =?utf-8?B?WlROUEtlNDVlb0EyU1RCS3ZienVONDh6L1lWc2xSaUdaRSs1Yjl1SGRZa0Yw?=
 =?utf-8?B?YjRqZnprOTZKaWk1Q2xwQUJNbCs0Tlh3bDhqMTh3TlRVWCt1dlNGMkR4ODUw?=
 =?utf-8?B?ODVlK0hyMWV6dG1kNnBEREdqaGV2amtGeEthZExWak53Z1dJSnZqMk9iSHpw?=
 =?utf-8?B?VnpiYTA5OG1tV1plVDloWEhUMGpyYlNoeXBBeWJKY0hhVmZhZ21CQ05veEJu?=
 =?utf-8?B?dXRJNVlQd3FvWU96cldSelYrZUN5eFVGejBRcmhYS0tsY24zVE02TjRIekFU?=
 =?utf-8?B?bnpiMlA1Tk1laHZvL3JxSkVrU1R1UlFwbndyc0lTRGpiMnRMZFB3OC9TWXhW?=
 =?utf-8?B?TGF5Qy9VMlF5aWhYV0wwQksyWEdYamdTN1BpdVJ2Yi8wTmVqL3BNbDAvTkZr?=
 =?utf-8?B?VU1mTWhZeUdQdit5eW1DdXdPNnJuSFdnMHFqUkJ5NHVpOWVmZ0VNZGNseFk3?=
 =?utf-8?B?YVpIbjRlRCtIWVk1dFBLUlFvN1ZFbmpMM0svaVNjWW9yeFRKdjlKempLY1lV?=
 =?utf-8?B?UkFpQ2gvWVFuK2d6aGxkRVVndkYwSnV5RENBdkIzR25sUlVjelQ2Sk5YcHBt?=
 =?utf-8?B?RU5qUGdSMmlKSWkwajNGNWZOdmh1cXhPbmpqWUxYVXQzdWYxT1lKdDh2UUl2?=
 =?utf-8?B?M1d4eHgwZ1Y5WS9vU1Jod2dxYmNXZEJGMjI4dTVFZXEySHNvRFk1Qko2dlVv?=
 =?utf-8?B?M01PZXIrYXY5RFlDeUdIMGh6ZXJGQ0JCSk9hOXp1YVk2Vnh6c2dXb3ZIcXpG?=
 =?utf-8?B?L2pjZGl6aE8rSGp3ZlBpN2tkTTI0dlo0cytxVkxMMS9RZ1RWaWhmZ0hMNHFD?=
 =?utf-8?B?K1hCNFJzOWZtOHVFUzB4clZqcDI2cDNPQzFIa1VvQUpUbnFKb3BTYkx6UFBa?=
 =?utf-8?B?SEh2aXZWWEdHRjVhTmNhbkFFOExPK21CeHRyMDlDZDhhb3RpWXlaRVRGZktw?=
 =?utf-8?B?b2VvcnpMdENLOFloNTBuaE5mL2xHeHMzQ3VzVTgvUVRKWkNQMmFzL08vV3dZ?=
 =?utf-8?B?dEVzdVcwY0VEYnJFUVJXU2pzaW9aUUdFOW1EajRiWXl6S01YY25UVG55bWhJ?=
 =?utf-8?B?QmNSOExzY0pWTlNjRHVrL3crS1Rnc2Rzd2hmRFp3WG52UUcwNUM5WjgyRmpo?=
 =?utf-8?B?cTJnUjVJcGRVNVdvS1l5WndlRWNuQjRmcElCaVlFd2lXU3JRRXdBV3ZTdGZ4?=
 =?utf-8?B?bEJCNnpCSTdLK1lMd2UxUjhadWlXbmMxcithalp2d1RPbVN3OHZXekc4VG1J?=
 =?utf-8?B?WldRMC9xY0loWEVSRHZ6aXZwL1N2NGYwS3dWbnp3Qnl0L0pxeGF6aFdnNEVh?=
 =?utf-8?B?SDJTVFllNW51VEkzVGk0ZVhhcWQ3c202NkdCbDUzSFQrekwwSko0L1lNdXFj?=
 =?utf-8?B?QzRDUkIxMUFKS25pUmZxLzBxa29XOTBlKzdNZHhLenRYWTR6ZEZlaG5McUll?=
 =?utf-8?B?QWR4cUV3VXN5TDhlQ1JtYmQvMmY3REF6cFY5QkRvOThXZFlxRW5Id09ZZ1ov?=
 =?utf-8?B?ZTZvV1lLbHVPV09CMnZCa204V1BVb25UQ3QzSFF6bWxnMlFreFV2OHFMQTg2?=
 =?utf-8?B?V1BLU3JRaXVYTE54N0gzRHYzTnVCOUJEOFpqaS9QWGUweFExalY4NEJVSHB3?=
 =?utf-8?B?UzJRbzlSYWJIZEJ1NWJnbENuSktuM295aDZvQmFUOU5JQXJqWmNUaTdpVFFP?=
 =?utf-8?B?Z3VWamFyS2RyZG51cVFKVmN5YkFSSU83cnZ0UURnR291MmtRTkdISjZlcUd4?=
 =?utf-8?B?VGExZnByTkxmSloxaU43N24zellwdmxMRm1DWkV5amREVlB4QmE1ZEZ3d05R?=
 =?utf-8?B?ZjlGTTdoRU1jdXVPT1g3cVJtOHoyY2ZWcUlRaVZYa1J0KzR5aWZKZjhqalov?=
 =?utf-8?B?a244RFVuTXUxczJiVGtwbERhRmR0TnUvUEZxUE12SkhHQTZSYllEWVMxaDV6?=
 =?utf-8?B?aXp0SlhGbEJUM1gwVnUyWHRHK01Od0tJNWRXUWFINU5FMmdoQ0pEOUg2a1Q5?=
 =?utf-8?B?cEQ4Z0Q0bmRsR2MydE0vTDMzL0JXUlZWd0JWSXhtb2xmYnhwbGk0UytpbG8x?=
 =?utf-8?B?QkVSOVN0TDl1VHU0alFGZDkzbm5NTFN5SEovU2JUOXpIbHZSbkM1aFBKUjJG?=
 =?utf-8?B?K0NldE1jZkQ0eG9vTlc4NFJsTStvQTI5ZitPbDloNjVOSlQwUW12TkFoWm1i?=
 =?utf-8?B?b2NYRlNxejNlTmdzdmJsd2g5M2MreFhlV0xjcEdtcnN2eEZCZ2RUdz09?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 205a647d-3795-4c82-7ac6-08d9e3d5e002
X-MS-Exchange-CrossTenant-AuthSource: HE1PR0802MB2426.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2022 09:49:57.8246
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TiyzCM6efAYHYlSL36wGnwUHOOlToaE6FsDtI4jxUNhExYrdJ+vjf7oU/0sZK8eTBCYLCOEL/84Bf+me6RrHwBCKQ+5ECdyhrSI16BDejOo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4543
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Samuel,

On 1/30/22 06:38, Samuel Holland wrote:
> rk356x contains a PDM microphone controller which is compatible with the
> existing rockchip,pdm binding. Add its node.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>  arch/arm64/boot/dts/rockchip/rk356x.dtsi | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> index a68033a23975..f2f3cdeab0aa 100644
> --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> @@ -651,6 +651,27 @@ &i2s1m0_sdo0   &i2s1m0_sdo1
>  		status = "disabled";
>  	};
>  
> +	pdm: pdm@fe440000 {
> +		compatible = "rockchip,rk3568-pdm";
> +		reg = <0x0 0xfe440000 0x0 0x1000>;
> +		interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&cru MCLK_PDM>, <&cru HCLK_PDM>;
> +		clock-names = "pdm_clk", "pdm_hclk";
> +		dmas = <&dmac1 9>;
> +		dma-names = "rx";
> +		resets = <&cru SRST_M_PDM>;
> +		reset-names = "pdm-m";
> +		pinctrl-0 = <&pdmm0_clk
> +			     &pdmm0_clk1
> +			     &pdmm0_sdi0
> +			     &pdmm0_sdi1
> +			     &pdmm0_sdi2
> +			     &pdmm0_sdi3>;
> +		pinctrl-names = "default";

I think the pinctrl properties should go before the reset properties.

Apart from that this patch looks good to me.

Best regards,
Michael

> +		#sound-dai-cells = <0>;
> +		status = "disabled";
> +	};
> +
>  	dmac0: dmac@fe530000 {
>  		compatible = "arm,pl330", "arm,primecell";
>  		reg = <0x0 0xfe530000 0x0 0x4000>;