Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 30 Jan 2022 20:35:57 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     Joseph CHAMG <josright123@gmail.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, joseph_chang@davicom.com.tw,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com,
        andrew@lunn.ch
Subject: Re: [PATCH v16, 2/2] net: Add dm9051 driver
Message-ID: <YfbajbH86Q/enthp@unreal>
References: <20220129164346.5535-1-josright123@gmail.com>
 <20220129164346.5535-3-josright123@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220129164346.5535-3-josright123@gmail.com>
Precedence: bulk

On Sun, Jan 30, 2022 at 12:43:46AM +0800, Joseph CHAMG wrote:
> Add davicom dm9051 spi ethernet driver, The driver work for the
> device platform which has the spi master
> 
> Signed-off-by: Joseph CHAMG <josright123@gmail.com>
> ---
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: andy Shevchenko <andy.shevchenko@gmail.com>

<...>

> +static int dm9051_probe(struct spi_device *spi)
> +{
> +	struct device *dev = &spi->dev;
> +	struct net_device *ndev;
> +	struct board_info *db;
> +	int ret = 0;

<...>

> +	kthread_init_worker(&db->kw);
> +	kthread_init_work(&db->kw_rxctrl, dm9051_rxctl_delay);
> +	kthread_init_work(&db->kw_tx, dm9051_tx_delay);
> +
> +	db->kwr_task_kw = kthread_run(kthread_worker_fn, &db->kw, "dm9051");

It is very unlikely that simple driver like this will need kthreads, does it really need?

Thanks