Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp613640pxb; Tue, 1 Feb 2022 07:02:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJzkH9+aJrnpujIQW20I6EqyZYP3BBNtWHeiBtuDK+r8O2O2ARn/sVm7XUgVnBvKy1IFuNov X-Received: by 2002:a05:6402:1d4d:: with SMTP id dz13mr26390293edb.84.1643727757534; Tue, 01 Feb 2022 07:02:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643727757; cv=none; d=google.com; s=arc-20160816; b=DkFFbd7SRX1AJ1WXy4GmuY5sbvw7of2v5wUiAqrjPwJGZBXdM7E23FiqP50xIQ5Idw APXin2wRDgeWG5UeE4GaOhEwzZJatPf+tU3RtxgV45p/998tIWTprfD3J7eKQ1OrslMb I1npm8QYI43FZy92uHBizRYKB86AUAfCI0FxwIkTARPHlmsLUdt7KVP9YMoaAoT2/T4k u4tT+eLXLDD2EhdA/tJljZffMsnEzHaTXWQm4aoum9s7lT+hGcgHI+87VNY8AHgQquXa HXf99Xbn2Kr9rxxGSg/geW4qiRE70cW4VoOucBrVH8twUOgWWz6OK9tQNE0Kejb1REA9 AhpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=nlceKRR9XYG+70HrS2RmpUq7A6HORpYsEV0OXmBraE8=; b=matULBfP7ziGLF3Da21UPKkSF9TRCzaa1y5guUafRjsFzpwezOE6BtF8pRVJKOeB+t DSpsEu2Ay4myXH7WyabqxMZytoJ7bnrSQLosua/utmkFG1J9JfrT31EryNZO1//RYjWO XMAOo6Qdh371/gL7mVAaSyZgCa+JDlNUeqHJn9tQ4M50MKdbcB5HCy1P3EOgB7HCCtLr jshhe5J6EeqYy1mhzB+usVV9s+7kDVVRvA37CCK+nN4TCPOv6DawZkgesjTzhrDLljQs VHwlLXRb3hKesc/T5WYXwzs/75MEAFeljy8HlVrfYUOaYdZeQ+mgyG2lGAmnYQLU0O84 z08Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=XVrSm8A+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h3si8958091ejo.614.2022.02.01.07.02.11; Tue, 01 Feb 2022 07:02:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=XVrSm8A+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356095AbiA3UPt (ORCPT + 99 others); Sun, 30 Jan 2022 15:15:49 -0500 Received: from alexa-out.qualcomm.com ([129.46.98.28]:42867 "EHLO alexa-out.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231913AbiA3UPs (ORCPT ); Sun, 30 Jan 2022 15:15:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1643573748; x=1675109748; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=nlceKRR9XYG+70HrS2RmpUq7A6HORpYsEV0OXmBraE8=; b=XVrSm8A+s1oeFdaS80Ym7ftzf423ubsu+2Lmg+zITtvS0asdNfPQNxXA WWEiI7/i5k5+JqxqQQEkosgAKerHgnqTIjWmX6cTyo5UFzINQ542ugWL2 JuIjfmhRcsaNFUStGWE43heikeck7GO7NMp73gnLc8AAsfoKL8dvTsWHV s=; Received: from ironmsg09-lv.qualcomm.com ([10.47.202.153]) by alexa-out.qualcomm.com with ESMTP; 30 Jan 2022 12:15:48 -0800 X-QCInternal: smtphost Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by ironmsg09-lv.qualcomm.com with ESMTP/TLS/AES256-SHA; 30 Jan 2022 12:15:46 -0800 X-QCInternal: smtphost Received: from rajeevny-linux.qualcomm.com ([10.204.66.121]) by ironmsg02-blr.qualcomm.com with ESMTP; 31 Jan 2022 01:45:23 +0530 Received: by rajeevny-linux.qualcomm.com (Postfix, from userid 2363605) id 709A521AD2; Mon, 31 Jan 2022 01:45:23 +0530 (IST) From: Rajeev Nandan To: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Cc: Rajeev Nandan , linux-kernel@vger.kernel.org, sean@poorly.run, robdclark@gmail.com, robh+dt@kernel.org, robh@kernel.org, quic_abhinavk@quicinc.com, quic_kalyant@quicinc.com, quic_mkrishn@quicinc.com, jonathan@marek.ca, dmitry.baryshkov@linaro.org, airlied@linux.ie, daniel@ffwll.ch, swboyd@chromium.org Subject: [v5 2/3] drm/msm/dsi: Add dsi phy tuning configuration support Date: Mon, 31 Jan 2022 01:45:18 +0530 Message-Id: <1643573719-32095-3-git-send-email-quic_rajeevny@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1643573719-32095-1-git-send-email-quic_rajeevny@quicinc.com> References: <1643573719-32095-1-git-send-email-quic_rajeevny@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add support for MSM DSI PHY tuning configuration. Current design is to support drive strength and drive level/amplitude tuning for 10nm PHY version, but this can be extended to other PHY versions. Signed-off-by: Rajeev Nandan Reviewed-by: Dmitry Baryshkov --- Changes in v2: - New. - Split into generic code and 10nm-specific part (Dmitry Baryshkov) Changes in v3: - s/ops.tuning_cfg_init/ops.parse_dt_properties To parse phy version specific DT properties (Dmitry Baryshkov) - Address comments for phy tuning data structure (Dmitry Baryshkov) No change since v4 drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 6 ++++++ drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 4 ++++ 2 files changed, 10 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c index 8c65ef6..fcbca76 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c @@ -739,6 +739,12 @@ static int dsi_phy_driver_probe(struct platform_device *pdev) } } + if (phy->cfg->ops.parse_dt_properties) { + ret = phy->cfg->ops.parse_dt_properties(phy); + if (ret) + goto fail; + } + ret = dsi_phy_regulator_init(phy); if (ret) goto fail; diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h index b91303a..9e08081 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h @@ -25,6 +25,7 @@ struct msm_dsi_phy_ops { void (*save_pll_state)(struct msm_dsi_phy *phy); int (*restore_pll_state)(struct msm_dsi_phy *phy); bool (*set_continuous_clock)(struct msm_dsi_phy *phy, bool enable); + int (*parse_dt_properties)(struct msm_dsi_phy *phy); }; struct msm_dsi_phy_cfg { @@ -81,6 +82,8 @@ struct msm_dsi_dphy_timing { #define DSI_PIXEL_PLL_CLK 1 #define NUM_PROVIDED_CLKS 2 +#define DSI_LANE_MAX 5 + struct msm_dsi_phy { struct platform_device *pdev; void __iomem *base; @@ -98,6 +101,7 @@ struct msm_dsi_phy { struct msm_dsi_dphy_timing timing; const struct msm_dsi_phy_cfg *cfg; + void *tuning_cfg; enum msm_dsi_phy_usecase usecase; bool regulator_ldo_mode; -- 2.7.4