Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp632849pxb; Tue, 1 Feb 2022 07:22:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJzJbI2rd92A8TlNOrCwjzQFKy1X27KS3yjCgacG93HUf8ZyTQB05yKR9jf/10X1TbqIsi3V X-Received: by 2002:a05:6402:524b:: with SMTP id t11mr15962495edd.161.1643728920643; Tue, 01 Feb 2022 07:22:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643728920; cv=none; d=google.com; s=arc-20160816; b=jd+UvoTTvxZlSWdYSCQiTBCIsbZ3A35E6sBVgjHqoYk5Dm2MA0KsVxjfAOmJBFwk+o pX1fKgMySyYXfRZroNq4RT2reSUUgCD6PEVqIfRkH7cv/OT95QbY/za2imtIBwFXSsEK E8lkCLZFRsHBlMvFZqMCgORqpdqOl7y6jKTVErl7yNwM3tw7W36aj0SKDrsBGfds4flI V4smifIbOQ5hIzaukIg3/KzSN2JGLaua8cV3hnNMrYOgXJ11GW6eXWygvjyh7t8eB5A9 3/TAoFkuqZ6qBImviSV4zgy1aXdTJ1G6gSx3NrBR3iRxOOwTskESBeywWbeYK6rqox7E ktEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject:dkim-signature :dkim-signature; bh=a1hKKv4tQs0IkB2xFQLDfa5QVFGb4OvJBNqopkGrr6k=; b=o/CRdYOM4mRX6gNVyi8OWjqRxnhAtI3rBeyFz9K5WH0wmsxgt1Nkyv+Nh9dfd5NQU3 tSig1CHgKbiqnHdy6T01gDLcbpicvLjJSNSO1CTX+kehg3gL9zHS3lqS+hjGi0fEcvyD /b15aESBH8DhKTEXwQbZy7APJJYPSKyKDZ33AYx/nB5DebgiGnTX5wiptqeIGo4NeBs+ j3SgVdzbRu3EDyywTf31HVgP1L/7+CABKYESahSAem6C2dhx5RWZjJpV4dljiBP2UIoQ 57WngKXXo0K4UCyhd9B8bxdr2J1TADYimhK7jG+TLluVm3IvFPwrHkoZlkj1SUgEUibq 5sxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=fiVkEAwx; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ji7si9374396ejc.39.2022.02.01.07.21.34; Tue, 01 Feb 2022 07:22:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=fiVkEAwx; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357523AbiAaEEI (ORCPT + 99 others); Sun, 30 Jan 2022 23:04:08 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:38096 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237371AbiAaEEH (ORCPT ); Sun, 30 Jan 2022 23:04:07 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F2A5D1F37B; Mon, 31 Jan 2022 04:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1643601846; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a1hKKv4tQs0IkB2xFQLDfa5QVFGb4OvJBNqopkGrr6k=; b=fiVkEAwxRDflObUldBuKWNJQJVCMu9eTTko+720oBoKH20RkmraMDCjs0Iy00tjy/uphUk 128iAjXpmRCycvT2drQM/OATXxz69rsiprFbeB2pPwa9L9eR8aiP2KJRgd4bmESc8+RqhM 0lrloqgzFrVvw8R08CSdyUMX4lq4gLg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1643601846; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a1hKKv4tQs0IkB2xFQLDfa5QVFGb4OvJBNqopkGrr6k=; b=uob4sOy+PK8E9TZ09Wj6Bhv0xAVwnyLeFUUFdeVvKXtH0q63G8ED3ptWJSVL4uJG3uhlu4 DO1m665lXtn3d/Cw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B1220133A4; Mon, 31 Jan 2022 04:04:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id B7tCG7Jf92GMCQAAMHmgww (envelope-from ); Mon, 31 Jan 2022 04:04:02 +0000 Subject: [PATCH 0/3] remove dependence of inode_congested() From: NeilBrown To: Andrew Morton , Jeff Layton , Ilya Dryomov , Miklos Szeredi , Trond Myklebust , Anna Schumaker Cc: linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 31 Jan 2022 15:03:53 +1100 Message-ID: <164360127045.4233.2606812444285122570.stgit@noble.brown> User-Agent: StGit/0.23 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Miklos pointed out that the filesystems which set the bdi congestion flags do gain some value from that, and simply removing the code is not appropriate. Specifically, readahead and/or writeback are skipped when the congestion flags are set. We can mostly move this skipping into the filesystem. ->readahead can do nothing if reads are congested. ->writepage and ->wrtepages can do nothing for WB_SYNC_NONE if writes are congested. Currently only *some* WB_SYNC_NONE writes are skipped due to congestion. Those from sync_file_range() and those used for page migration are not. Also, shrink_page_list() will now cause PageActive to be set if ->writepage skips due to congestion. I don't expect these changes to be a problem, but I have no experience to base that on. Review/comments most welcome, Thanks, NeilBrown --- NeilBrown (3): fuse: remove reliance on bdi congestion nfs: remove reliance on bdi congestion ceph: remove reliance on bdi congestion fs/ceph/addr.c | 22 +++++++++++++--------- fs/ceph/super.c | 1 + fs/ceph/super.h | 1 + fs/nfs/write.c | 12 ++++++++++-- include/linux/nfs_fs_sb.h | 1 + 5 files changed, 26 insertions(+), 11 deletions(-) -- Signature