Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp653588pxb; Tue, 1 Feb 2022 07:45:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJzqcsBeQpnqTEi+3FUNGkpEESvEOMLLZOQX4Im82spsp2vg+SaqWKW1vdadQndn+Yksjq2v X-Received: by 2002:a05:6402:c8f:: with SMTP id cm15mr13032203edb.142.1643730356294; Tue, 01 Feb 2022 07:45:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643730356; cv=none; d=google.com; s=arc-20160816; b=xzursjUkwHfJSIeui2PoO+BXa5qFo5jfvO+AtbVRnjGZPBUbO4VQSVDHqefAn2sBmh u6Akmsah9b9JKQvXlzRIpCYMXdvudsRGc/KGYmSJLxqmmQeS4dXgW8MzHbu4Uu+4MmTT pS3bviI8lJnHHQjV17nFzbZoV65bn15GfHNoukg0RZYeo+iVYrKKPHxuzhRnTJa0jW95 vRAMUD0fDRSyeY+YQXuCI49cvf8RnBxk6ZKPkr8hr5pxVidIyztERwgsyJ+fr2PsRxN5 mfikA/mkE2Bc2H8lfOGknvQ+RuCq5W3gRXS+LX0t8WJHFD2PhRZhV6K87QqwotCX23Jn 4TRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=M5ATpzd25e+Sy/RCew0oyKft2+Dk493GtVbeEoXo7c0=; b=TKLDRleSiSO35GR5/CSVwK5X6YEwuLK5h3k8La5oh0HCvUhvUwHgK0YZQb4KaKBf2F H1WqeKbit+Z0m09yGFtnMGzzVgHRpZ6PRIA1eBOqff7HCgFlvg/BmJ3VrUbhvgOlbpSn kkyvDrbgo11d97tn2tbAOn2hkuGD2WIlKC35O+QzZghCrl8cJ4HU8Elf/+ZjlQbsHxT4 w5s9SQSHs2GFJLO5BKCvmJ+eJmnwWeq3pWpz+xErY0HxW0Jo/VTH7V61aMvnc7iEqwEo FmHvnYZMnjG5qvS5+sNWKwKp/5U/NY3EjsYbNyMyeJZyAPfabrHaI9GSWzs0C2Zq6yPY TpyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=O98YnZJu; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=VE6j3yVA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sg37si10136791ejc.314.2022.02.01.07.45.30; Tue, 01 Feb 2022 07:45:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=O98YnZJu; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=VE6j3yVA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244987AbiAaISy (ORCPT + 99 others); Mon, 31 Jan 2022 03:18:54 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:43718 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbiAaISw (ORCPT ); Mon, 31 Jan 2022 03:18:52 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id EBE54212B9; Mon, 31 Jan 2022 08:18:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1643617130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M5ATpzd25e+Sy/RCew0oyKft2+Dk493GtVbeEoXo7c0=; b=O98YnZJulMDnlClCc7g/XuZFuDXrv8AbQ0q1flmfnHGlulJ0DN074srYGKW5g095TT3UTt /9doB+C0oQJM8+6bktFqK1HM2bdJL8zjqUjUlfsW4EsbGzqFJUT4vNJ3vLzWrDk0OUzL3n C1Lbj5an1YSMMMfhhp0a5kz9xMdPHI8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1643617130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M5ATpzd25e+Sy/RCew0oyKft2+Dk493GtVbeEoXo7c0=; b=VE6j3yVAchvW60GzVd1DoxCun9XLJHEQ5hX4TRnK5puDZEUh/33GNhVUiwe1kWhtio+ZJI adZUbRGpzFIupMBg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id AF6B9A3B85; Mon, 31 Jan 2022 08:18:50 +0000 (UTC) Date: Mon, 31 Jan 2022 09:18:50 +0100 Message-ID: From: Takashi Iwai To: Stephen Boyd Cc: Greg Kroah-Hartman , Douglas Anderson , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Jaroslav Kysela , Takashi Iwai , Kai Vehmanen , Daniel Vetter , "Rafael J. Wysocki" , Rob Clark , Russell King , Saravana Kannan Subject: Re: [PATCH v6 29/35] sound: hdac: Migrate to aggregate driver In-Reply-To: <20220127200141.1295328-30-swboyd@chromium.org> References: <20220127200141.1295328-1-swboyd@chromium.org> <20220127200141.1295328-30-swboyd@chromium.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 Jan 2022 21:01:35 +0100, Stephen Boyd wrote: > > Use an aggregate driver instead of component ops so that we can get > proper driver probe ordering of the aggregate device with respect to all > the component devices that make up the aggregate device. > > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Kai Vehmanen > Cc: Daniel Vetter > Cc: "Rafael J. Wysocki" > Cc: Rob Clark > Cc: Russell King > Cc: Saravana Kannan > Signed-off-by: Stephen Boyd The patch looks good, but just a minor concern: > +static struct aggregate_driver hdac_aggregate_driver = { > + .probe = hdac_component_master_bind, > + .remove = hdac_component_master_unbind, > + .driver = { > + .name = "hdac_agg", Shouldn't we define some standard name scheme? This one has "hdac_agg", while the patch for HD-audio Realtek stuff has "realtek_aggregate". (And maybe the latter one should be something like "hda_realtek_agg" or such, as Realtek covers pretty different devices and there might be conflict in future.) With those considered: please take my ack Acked-by: Takashi Iwai thanks, Takashi