Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 31 Jan 2022 10:48:25 +0200
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Benson Leung <bleung@google.com>
Cc:     Prashant Malani <pmalani@chromium.org>,
        linux-kernel@vger.kernel.org, Benson Leung <bleung@chromium.org>,
        "open list:CHROMEOS EC USB TYPE-C DRIVER" 
        <chrome-platform@lists.linux.dev>,
        Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH] platform/chrome: cros_ec_typec: Make try power role
 optional
Message-ID: <YfeiWcPfOX5ctFHu@kuha.fi.intel.com>
References: <20220127191659.3560810-1-pmalani@chromium.org>
 <YfOLRBGmwGKwCksR@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YfOLRBGmwGKwCksR@google.com>
Precedence: bulk

Hi,

On Thu, Jan 27, 2022 at 10:20:52PM -0800, Benson Leung wrote:
> Hi Prashant,
> 
> On Thu, Jan 27, 2022 at 07:16:59PM +0000, Prashant Malani wrote:
> > Some boards prefer not to specify a try-power-role. Update the port
> > property parsing logic to not error out in case a try-power-role is not
> > specified.
> > 
> > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > Signed-off-by: Prashant Malani <pmalani@chromium.org>
> 
> This looks good to me.
> 
> Heikki, if this usage of TYPEC_NO_PREFERRED_ROLE looks good to you, I can
> merge it.

This is OK by me. FWIW:

Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

thanks,

> > ---
> >  drivers/platform/chrome/cros_ec_typec.c | 15 ++++++++-------
> >  1 file changed, 8 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> > index 5de0bfb0bc4d..ee12658009e5 100644
> > --- a/drivers/platform/chrome/cros_ec_typec.c
> > +++ b/drivers/platform/chrome/cros_ec_typec.c
> > @@ -115,17 +115,18 @@ static int cros_typec_parse_port_props(struct typec_capability *cap,
> >  		return ret;
> >  	cap->data = ret;
> >  
> > +	/* Try-power-role is optional. */
> >  	ret = fwnode_property_read_string(fwnode, "try-power-role", &buf);
> >  	if (ret) {
> > -		dev_err(dev, "try-power-role not found: %d\n", ret);
> > -		return ret;
> > +		dev_warn(dev, "try-power-role not found: %d\n", ret);
> > +		cap->prefer_role = TYPEC_NO_PREFERRED_ROLE;
> > +	} else {
> > +		ret = typec_find_power_role(buf);
> > +		if (ret < 0)
> > +			return ret;
> > +		cap->prefer_role = ret;
> >  	}
> >  
> > -	ret = typec_find_power_role(buf);
> > -	if (ret < 0)
> > -		return ret;
> > -	cap->prefer_role = ret;
> > -
> >  	cap->fwnode = fwnode;
> >  
> >  	return 0;

-- 
heikki