Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp679010pxb; Tue, 1 Feb 2022 08:13:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJwXA9jyBFc683hDymoAaGfwqhtOShjUWGTUJSwta7Dt5HYIYS1JPgdbhUsppU71uykZaFpb X-Received: by 2002:a05:6402:1e91:: with SMTP id f17mr26143590edf.407.1643731992684; Tue, 01 Feb 2022 08:13:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643731992; cv=none; d=google.com; s=arc-20160816; b=g37hlVv8R12IY5xJlN1fs9Q5LRzeCA6XM685mu0SU7lSv1T6iXqWlIV3CHLYuEQpc2 oNfhWx/2ie/kdNbnADGG3y5wq/rJ447zEFILbtwbm3Su0rdkQTZFV5UEOu8ru41bCh+K HwY5M5yltkT8vNCRcZ7FxEM1lxS0kVuqQOZWQcYwmCDovO+6hB+BNlzPftoycLeYzDf8 +NW1Jm2zaUJ+qCObIWxpTv+iNvExD8pfZuT28nYbt5oqiBQ9jy4PC0NBDHvYQI/N2kDn hG4LybyIvSCIeQp4LVq9uvHbyXeW/hnJ9nZNXlzlwwDa+T0ij4gkSOadtfOGwjhZkxn8 b3cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=u/YBcaEtqkn9ei62v6Egwwl5pdickHyLn/kPQ+zwaj0=; b=DXlA6WpqjbPqXjDoqfdCwMgs3U/Aj90q9o6WeW/+aExIPWDctlHRMOL6RkFSZD+XC1 vqYAnDfHbTWYjj+YlHFMf7kExyI8SUblN/M08ys0UGKGEODGJZ5ZZ7qZiR6+keqqVqP6 X5vjIS9XRKSUip4l13hcVhJiEmFgukKHWXfaY57yLGTUAebmbtdnz+u17NCInruCCRSy 5MV1XZ23ISyPw2cZeM1519eyAvKCXtcyljVwDfbMB2V1QRzcP1nGP4LwOm/Kbhtjvvmt gcFhh5dRTQPvAP9Sa3VNoEvcazgwGPEDOLTlKE2+bmYVmjhqgSAfYEtCJFGfL3PijvSv YKTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n2si1554507edo.657.2022.02.01.08.12.47; Tue, 01 Feb 2022 08:13:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348425AbiAaKQK (ORCPT + 99 others); Mon, 31 Jan 2022 05:16:10 -0500 Received: from muru.com ([72.249.23.125]:44646 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232024AbiAaKQJ (ORCPT ); Mon, 31 Jan 2022 05:16:09 -0500 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 5F72B8027; Mon, 31 Jan 2022 10:15:59 +0000 (UTC) Date: Mon, 31 Jan 2022 12:16:06 +0200 From: Tony Lindgren To: Drew Fustini Cc: Daniel Lezcano , Thomas Gleixner , Keerthy , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tero Kristo , Suman Anna Subject: Re: [PATCH 2/2] clocksource/drivers/timer-ti-dm: Handle dra7 timer wrap errata i940 Message-ID: References: <20210323074326.28302-1-tony@atomide.com> <20210323074326.28302-3-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, * Drew Fustini [220129 21:05]: > On Tue, Mar 23, 2021 at 09:43:26AM +0200, Tony Lindgren wrote: > > There is a timer wrap issue on dra7 for the ARM architected timer. > > In a typical clock configuration the timer fails to wrap after 388 days. > > > > To work around the issue, we need to use timer-ti-dm percpu timers instead. > > > > Let's configure dmtimer3 and 4 as percpu timers by default, and warn about > > the issue if the dtb is not configured properly. > > Hi Tony, > > This causes a conflict for IPU2 which is using timer 3 and 4. > > From arch/arm/boot/dts/dra7-ipu-dsp-common.dtsi: > > &ipu2 { > mboxes = <&mailbox6 &mbox_ipu2_ipc3x>; > ti,timers = <&timer3>; > ti,watchdog-timers = <&timer4>, <&timer9>; > }; OK, sorry I missed that part. > I noticed an error ("could not get timer platform device") when booting > mainline on a BeagleBoard X15 (AM578): > > omap-rproc 55020000.ipu: assigned reserved memory node ipu2-memory@95800000 > remoteproc remoteproc1: 55020000.ipu is available > remoteproc remoteproc1: powering up 55020000.ipu > remoteproc remoteproc1: Booting fw image dra7-ipu2-fw.xem4, size 3747220 > omap-rproc 55020000.ipu: could not get timer platform device > omap-rproc 55020000.ipu: omap_rproc_enable_timers failed: -19 > remoteproc remoteproc1: can't start rproc 55020000.ipu: -19 > > I switched this errata fix to use timer 15 and 16 instead which resolves > the error. Do you think that is an acceptable solution? I think the only difference is that timers 15 and 16 are in l4_per3 instead of l4_per1. I doubt that matters as they are pretty much always clocked in this case. If you want to check you can run cyclictest :) > If so, I will post the patch to the list. OK thanks, Tony