Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 31 Jan 2022 13:40:20 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
Cc:     gregkh@linuxfoundation.org, realwakka@gmail.com,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: remove unnecessary new line escape
 sequence characters
Message-ID: <20220131104020.GI1951@kadam>
References: <YfYtsiKbOXghIN+5@mail.google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YfYtsiKbOXghIN+5@mail.google.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?j3j6Uz2Dgu+aNRV8BsXO+WQlleQy056o9/fzaYN2xiom5geI9t7vN1y/Kw45?=
 =?us-ascii?Q?LTTDe+wgQOsIOdoLR5jRGv7bgJltEjVYmfT69ycR3X6UyO1podzrnqSJGyS/?=
 =?us-ascii?Q?0yZpqYH+9CYPfjYP7rFQ6B/hQ0O0kVBWsz2q3z73kmx6s1eFidYaeMY6+YBv?=
 =?us-ascii?Q?zCB0jLIiQE4dUop81NUVFzU2hkCTUARU9hggh9xx33Vh5kRwmofuEmleHDTy?=
 =?us-ascii?Q?yvs3I1X3EZbGWqRNybFqe/T2+xf541D9P/VmNpiXUp2ErY5QEb9wBH7YGcT6?=
 =?us-ascii?Q?i/GwWwi4tsgQQee+pNISa0RTnkSpqQNil5ititoSWTJ8U/uUk06jNrMUpisX?=
 =?us-ascii?Q?rR5VIcF1CFbBu95g6NfINYPDTcINQhZc7SlozG5X4v1EilXIZKc8bOB1raOQ?=
 =?us-ascii?Q?xwcRs+qEnq678ZKSKL0+PaXe+pids+14t+1SIewJveL3cGCe6a+EgLG7SvLi?=
 =?us-ascii?Q?94RhQFTTzPqPOwAFAPVaIMUAq4fGZDs+o4o0dvOT8Pkf9t5unjMDQ4pXimoa?=
 =?us-ascii?Q?QvMWKWXORIKyjp7lIujmBQ7MuZMZYPSMjd6asjKHTlLJ38tylzWbAIT0Ubpl?=
 =?us-ascii?Q?mViMiNkTJfbhbhYmjk4axCDgh/HYGPiF2kDRkyhF8VfFf7WEZkhwzZc5TN0s?=
 =?us-ascii?Q?YO+0DHtZUEDxm6/MZMlBRjnx022jz5ire/fQiU7nyDEUiTlWDGSXX6984zFW?=
 =?us-ascii?Q?75fAQ2U9fdT+vghUa2EW1wfRG1L/t2ctV1+RFm/Fetp5tWfsjUbIio8BQjbh?=
 =?us-ascii?Q?utr1QqrRA8jDkPD4dioCNRS4z1rhLmVLawSUHJJDPqXyrFk57qKQsmHCygx/?=
 =?us-ascii?Q?8NPNCrqMtLSutH08VMOBmjDA4Kue9XW0oTjCxvGMNNWAcm3v9gkAzGHivh4G?=
 =?us-ascii?Q?S/y/Um7phgnfhoPptfKmuRgJyKv+65p1IlU3EzW/uIMYEAzIpviitkJS9Jr+?=
 =?us-ascii?Q?sAX/b1Q2ZMBt2CyyFpiuAD+NAMrIRO2N2zzoHW4lRMBftHgvm2cZfkbTNofD?=
 =?us-ascii?Q?6ZrgCAh50Voyy4XB2AgVmpP3Rlrs373a+P1BoAghbb9wxk6LbJvBiYehv7xw?=
 =?us-ascii?Q?QQLSdOyYPNFaN9bxr6EdX32XE7f25Vor9ajk+RKe2ZF7FFww2FO2vBLPg93H?=
 =?us-ascii?Q?T6oqdDLAh8FWb4e0bpmcU4jKY9BGOZ0cyQMP+50CRqeFQk0Brz8wuoYup1W6?=
 =?us-ascii?Q?49nqUjWyuKqRopvotyJ3DWTdeswrP04gGSea++GTc6J6Mh5sXQw2J10IJjqB?=
 =?us-ascii?Q?kodbfrEoE8ngOz4mxnD9j/Fn3qjdighBa2JiHTZW21+miJ1hlHziBOUJ6V8e?=
 =?us-ascii?Q?77cpL2CEkZaikN2jH2D0e+Wo74X/P9EhCK5SkTrC6stWxxmL+reCc1NgLn70?=
 =?us-ascii?Q?dZerXXxWIK+9ENbMGof3vGgEeaVWHFobX3f70I2VGTybMNMuTOvX3mGx4ktR?=
 =?us-ascii?Q?79wnCynmExAeLrkuIlNqEDtQrj7Wm1tTcdHHA4+aXzYEqsTFSZxeSifqhHnO?=
 =?us-ascii?Q?R6rafVxM3Lpo+5t/EVCdkzT7dKOU9NSbGlKXPx/pQ36IeMMizafZ+ySpdQPF?=
 =?us-ascii?Q?ellcn2QkRlejtqHrdd7KbGv6qLG4gmS9oX/VN7Qymf9CbrVrEkw8z2bPq1IS?=
 =?us-ascii?Q?1k40Zbb41Io1t9Ski0KAmS+5w4CHpyNiMyaA3MyncEDW4ZN87usnZv7K/FKk?=
 =?us-ascii?Q?SnlCsg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38406b73-806c-4a94-8a8a-08d9e4a61ff9
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2022 10:40:40.6943
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r8JihbssCcQmTQhP2ClCYttWdzihMjJzvvWj0MxlkzKM9zezok4jJNXRV/iR9vrQHAKvr4lW9mMQh7Td9GnWJnabtacSxs88753DFJwG1E0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1586
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10243 signatures=673430
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 spamscore=0
 bulkscore=0 adultscore=0 mlxlogscore=999 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2201310071
X-Proofpoint-ORIG-GUID: IvxG8Cs_ixi_zDW5VBouSQYIMaTTyYSk
X-Proofpoint-GUID: IvxG8Cs_ixi_zDW5VBouSQYIMaTTyYSk
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jan 30, 2022 at 07:18:26PM +1300, Paulo Miguel Almeida wrote:
> In this driver there were occurences of '\n'-ended strings when using
> dev_dbg function which isn't required which most likely were leftovers
> from a previous printk/pr_<level> implementation.
> 
> This patch removes the extraneous '\n' characters to make it consistent
> with the other dev_dbg instances.
> 
> Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
> ---
> Patch dependencies:
> 
> The following patches must be applied first given that changes are made
> to the same set of files:
> 
> - https://lore.kernel.org/lkml/YfYdVokxsQ+Adl+T@mail.google.com/
> - https://lore.kernel.org/lkml/YfX+llwDWZZMz+NY@mail.google.com/
> ---
>  drivers/staging/pi433/pi433_if.c | 14 +++++++-------
>  drivers/staging/pi433/rf69.c     | 16 ++++++++--------
>  2 files changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 02d4ccebf..db1b092e8 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -124,13 +124,13 @@ static irqreturn_t DIO0_irq_handler(int irq, void *dev_id)
>  
>  	if (device->irq_state[DIO0] == DIO_PACKET_SENT) {
>  		device->free_in_fifo = FIFO_SIZE;
> -		dev_dbg(device->dev, "DIO0 irq: Packet sent\n");
> +		dev_dbg(device->dev, "DIO0 irq: Packet sent");

Both the old and new code will do the same thing.  You are correct.
However in terms of style, I believe the preference is to add a newline.

I don't remember the reasoning behind this.  But a lot of these style
rules are just decided by consensus.  If you do a
`git grep -w dev_dbg | grep \;$` then it is 12391 places that add a
new line and 622 which don't.  Adding a newline is the clear winner.

regards,
dan carpenter