Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp866729pxb; Tue, 1 Feb 2022 12:04:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJw/x4+FrNLkw+olwckMigpjIFbeNWmflEXTzKzK7Tc07anVXCsBujw8zbzPVW2OQ2AWTc20 X-Received: by 2002:a05:6402:2052:: with SMTP id bc18mr26542046edb.63.1643745844435; Tue, 01 Feb 2022 12:04:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643745844; cv=none; d=google.com; s=arc-20160816; b=iOZLNFzBRiFw4NkNmCnToQS+FwWk/ig4nz6HeCE8u9BTuZPrbxr55PYeyRRXXe3tyv 3WHMiYf2UPEIx3/ikVfSPl+zdplxAidmZ8g4RQCtpJ2DfAIbo/aCwU+hmfyHdp0jTKB0 4i8VMY0AaE6p9eloK6ouIEh+kETwAAk+Jlwy+bfgIG0Ca07YU59mh5X9R+ZJC+bwzYdH W7rK/OAqYDKwAP7ebb2tdnVPQ4TYfnJ/OzWrLJaNP5cbz6JSRhMQel3NRbzavZqyagKV LTHG74RuJ/BF1aUS/xfR9DEKvL2YdYjYYXZIDJSmhtq3PFG8Fehxhz4l1EOWokTruU/5 aZvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=StZt4/mif8urUha8Q+fPoOSZ+nb5jB3NIlOMgXnXWLo=; b=dGChwmxW9FSd0Tuh0A5FnerpOKRBt28ljHUVxBy57C6xaqddphPZW7w0ui20ECxT4m TPQPp3Fb8/KqpkFH+IUpAzU92opEzq/AST3aH9n31XmPcMOcz+i4yhUD4OPv0PIWFpAl o1OSdPJYw5GpbjIwP8epa0SykQInFv8K4OpIt7CSjfsxufOT3IlnaR0NKtwFNKkqfxKB qqskBTUNwrq5K4PYEnx4cY38QHfe8sYQVT5O4WJ1FASgq1PhYvpnBOXpyl15JvvnkD6Y plaf7RYxrOM8okVoKIYFSXLDJZtdYpR9MeZnbc6jWEVsJTmaFUIctWDoaNk7G9mtzn12 huBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=1LjTjTWJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n6si10051324ejl.34.2022.02.01.12.03.34; Tue, 01 Feb 2022 12:04:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=1LjTjTWJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377030AbiAaLNg (ORCPT + 99 others); Mon, 31 Jan 2022 06:13:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377388AbiAaLJ7 (ORCPT ); Mon, 31 Jan 2022 06:09:59 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EB38C0604EE; Mon, 31 Jan 2022 03:07:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2E6F660E76; Mon, 31 Jan 2022 11:07:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10AECC340EE; Mon, 31 Jan 2022 11:07:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643627253; bh=TEQ4QtW897KUpyACEqK/a2F+QVmtupwqDs42RMlB7oc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1LjTjTWJ2WKsaJDBD9aHrTwuTAJ5hplR8xBao1yrLrN4PtKEwXLHqUPo1yXLSOC7O am7i/z8Ps2YGV6o1qlcGzuPzu57PhdMrEQvpS12nP52x8tWXPXsUljt9Nmziy0BmCs e1ja2nwmFVuo4K+b0awPNkGH+TtHkNsXk37SGfCc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jeff Layton , Ilya Dryomov Subject: [PATCH 5.15 023/171] ceph: properly put ceph_string reference after async create attempt Date: Mon, 31 Jan 2022 11:54:48 +0100 Message-Id: <20220131105230.806451264@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220131105229.959216821@linuxfoundation.org> References: <20220131105229.959216821@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jeff Layton commit 932a9b5870d38b87ba0a9923c804b1af7d3605b9 upstream. The reference acquired by try_prep_async_create is currently leaked. Ensure we put it. Cc: stable@vger.kernel.org Fixes: 9a8d03ca2e2c ("ceph: attempt to do async create when possible") Signed-off-by: Jeff Layton Reviewed-by: Ilya Dryomov Signed-off-by: Ilya Dryomov Signed-off-by: Greg Kroah-Hartman --- fs/ceph/file.c | 2 ++ 1 file changed, 2 insertions(+) --- a/fs/ceph/file.c +++ b/fs/ceph/file.c @@ -744,8 +744,10 @@ retry: restore_deleg_ino(dir, req->r_deleg_ino); ceph_mdsc_put_request(req); try_async = false; + ceph_put_string(rcu_dereference_raw(lo.pool_ns)); goto retry; } + ceph_put_string(rcu_dereference_raw(lo.pool_ns)); goto out_req; } }